389-ds-base

#48887 Config set on off issues in libglobs
Closed: wontfix by spichugi. Opened by firstyear.

Closed: wontfix
Reopen Issue

It looks like in libglobs we have lots of this pattern:

    retVal = config_set_onoff ( attrname, value, &(slapdFrontendConfig->auditfaillog_logging_hide_unhashed_pw),
                                errorbuf, apply);
    if(strcasecmp(value,"on") == 0){
        auditfaillog_hide_unhashed_pw();
    } else {
        auditfaillog_expose_unhashed_pw();
    }
    return retVal;

In the case this value is set to say "512" or anything that is not "on" or "off" this has the behaviour of leaving the value set to current state (ie "on"), but on the running instance it acts as though off was taken.

As well, we aren't checking if we should be applying the value.

I think we should update all these to be like:

    retVal = config_set_onoff ( attrname, value, &(slapdFrontendConfig->logging_hr_timestamps),
                                errorbuf, apply);
    if (apply && retVal == LDAP_SUCCESS) {
        if(strcasecmp(value,"on") == 0){
            log_enable_hr_timestamps();
        } else {
            log_disable_hr_timestamps();
        }
    }
    return retVal;

Metadata Update from @firstyear:
- Issue set to the milestone: 1.3.6 backlog

Metadata Update from @firstyear:
- Custom field reviewstatus adjusted to new
- Issue close_status updated to: None
- Issue tagged with: Easyfix

Metadata Update from @firstyear:
- Custom field reviewstatus reset (from new)
- Issue set to the milestone: 1.3.7 backlog (was: 1.3.6 backlog)

Metadata Update from @ilias95:
- Issue assigned to ilias95

Which test suites would you run in order to make sure that such a change in libglobs.c didn't break anything?

Hmmm, that's a difficult question. I think that we've never been good about putting config tests in one place, because the tests normally relate to a feature. So the tests are all through out the code base. I'd say in that light, you need to do the full suite/ticket test.

Metadata Update from @ilias95:
- Assignee reset

Metadata Update from @mreynolds:
- Custom field reviewstatus adjusted to None
- Issue set to the milestone: 1.4 backlog (was: 1.3.7 backlog)

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/1946

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix
- Issue status updated to: Closed (was: Open)
Metadata
None

Easyfix

None
None
Normal
Community
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.