#49264 Broken slapi-plugin header in 1.3.6.4
Closed: wontfix Opened by darix.

Issue Description

slapi-nis failed building with 1.3.6.4

configure:12546: gcc -c -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -g -I/usr/include/mozldap -I/usr/include/nss3 -I/usr/include/nspr4  conftest.c >&5
In file included from conftest.c:31:0:
/usr/include/dirsrv/slapi-plugin.h:31:23: fatal error: slapi_pal.h: No such file or directory
 #include <slapi_pal.h>
                       ^
compilation terminated.
configure:12546: $? = 1
configure: failed program was:

After i fixed slapi-plugin.h to use:

#include <dirsrv/slapi_pal.h>

It failed with

configure:12546: gcc -c -fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -g -I/usr/include/mozldap -I/usr/include/nss3 -I/usr/include/nspr4  conftest.c >&5
In file included from /usr/include/dirsrv/slapi-plugin.h:31:0,
                 from conftest.c:31:
/usr/include/dirsrv/slapi_pal.h:22:20: fatal error: config.h: No such file or directory
 #include <config.h>
                    ^
compilation terminated.

IMHO requiring config.h here seems wrong.

Can this be fixed for 1.3.6.6?

This also might be the reason for the build failures of the freeipa package in F26 reported by @tkrizek.

Package Version and Platform

389-ds 1.3.6.4 on openSUSE Tumbleweed


It seems @vashirov already applied a patch to fix the issue in 9563d299.

I am not sure i really like the config.h part ... because if slapi-nis might have a config.h ... then it might not contain what you expect from a 389-ds config.h, no?

Does slapi_pal.h really need config.h?

No, slapi_pal.h doesn't need config.h. I'll have a look at this in the related ticket.

No, slapi_pal.h doesn't need config.h. I'll have a look at this in the related ticket.

Metadata Update from @firstyear:
- Issue assigned to firstyear

48864 resolves this.

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/2323

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: fixed)

Metadata