389-ds-base

#50073 Fix and re-enable filter optmiser
Closed: wontfix by spichugi. Opened by firstyear.

Closed: wontfix
Reopen Issue

Issue Description

@mreynolds disabled the filter optimiser due to a bug. We should investigate it, and fix it for re-enabling it. In order to prevent it being reverted, we should feature gate it as well in case of future issues.

Metadata Update from @mreynolds:
- Custom field component adjusted to None
- Custom field origin adjusted to None
- Custom field reviewstatus adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None
- Issue set to the milestone: 1.4.1

So I'm starting to work on this. @mreynolds Part of this will be that I'll provide #defines and will initially define-out the optimising code so that we don't reintroduce issues, and then later, we can enable it. If we have issues, we can just toggle the define and rebuild. Does that seem reasonable?

So I'm starting to work on this. @mreynolds Part of this will be that I'll provide #defines and will initially define-out the optimising code so that we don't reintroduce issues, and then later, we can enable it. If we have issues, we can just toggle the define and rebuild. Does that seem reasonable?

Of course

@lkrispen is also working on a similar issue, and has a fix out for review. Just make sure to keep in sync with his work :-) Thanks!!!

No problem! I've been paying attention to his work, especially on the filter bypass fix for onelevel (which I think seems like the same symptom of why this feature was reverted in the first place). I wonder if the optimisation was in fact highlighting a different issue? Anyway, I'll try to finish this up today then :)

https://pagure.io/389-ds-base/pull-request/50252

The PR causes a regression in FreeIPA installation during the client install DNS setup. I'm attaching the access logs from a good install (without this fix), and a log with this fix. Please investigate this, and let me know if I can help get more information from the env.

Success log:

access.success

Failure log:

access.failed

This is the full debug log from the failing query. For analysis see: https://pagure.io/389-ds-base/pull-request/50252#comment-85208

ipa_failure_query_2.log

@firstyear - any progress on this one?

Metadata Update from @mreynolds:
- Issue assigned to firstyear
- Issue priority set to: normal
- Issue set to the milestone: 1.4.3 (was: 1.4.1)

I haven't touched it in a while, but I will return to it eventually as I think it's super valuable (especially for sssd/freeipa).

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/3132

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
High
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.