From bea29c40a59caa54c32c567ee0f2816b69d5caeb Mon Sep 17 00:00:00 2001 From: Thierry Bordaz Date: Tue, 21 Nov 2017 17:23:29 +0100 Subject: [PATCH] Ticket 49460 - replica_write_ruv log a failure even when it succeeds Bug Description: Minor issue If the update of the DB RUV returns a success LDAP_SUCCESS (internal modify), it however logs an error as if it failed side effect of https://pagure.io/389-ds-base/issue/48118 Fix Description: Log a message only on failure https://pagure.io/389-ds-base/issue/49460 Reviewed by: ? Platforms tested: F23 Flag Day: no Doc impact: no --- ldap/servers/plugins/replication/repl5_replica.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ldap/servers/plugins/replication/repl5_replica.c b/ldap/servers/plugins/replication/repl5_replica.c index 77f4f18..db3a8a0 100644 --- a/ldap/servers/plugins/replication/repl5_replica.c +++ b/ldap/servers/plugins/replication/repl5_replica.c @@ -2808,8 +2808,7 @@ replica_write_ruv(Replica *r) /* this includes an internal operation - but since this only happens during server startup - its ok that we have lock around it */ rc = _replica_configure_ruv(r, PR_TRUE); - } else /* error */ - { + } else if (rc != LDAP_SUCCESS) { /* error */ slapi_log_err(SLAPI_LOG_REPL, repl_plugin_name, "replica_write_ruv - Failed to update RUV tombstone for %s; " "LDAP error - %d\n", -- 2.5.5