From f147c876f56794f23729668d2018ba97854f2095 Mon Sep 17 00:00:00 2001 From: Thierry Bordaz Date: Wed, 25 Oct 2017 11:13:04 +0200 Subject: [PATCH] Ticket 49412 - SIGSEV when setting invalid changelog config value Bug Description: If admin configures attribute of "cn=changelog5,cn=config" with empty value, it can trigger a sigsev Fix Description: Testing empty value https://pagure.io/389-ds-base/issue/49412 Reviewed by: ? Platforms tested: F23 Flag Day: no Doc impact: no --- ldap/servers/plugins/replication/cl5_config.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ldap/servers/plugins/replication/cl5_config.c b/ldap/servers/plugins/replication/cl5_config.c index ab2c53d..5d88d60 100644 --- a/ldap/servers/plugins/replication/cl5_config.c +++ b/ldap/servers/plugins/replication/cl5_config.c @@ -307,7 +307,9 @@ changelog5_config_modify(Slapi_PBlock *pb, /* We don't support deleting changelog attributes */ } else { int j; - for (j = 0; ((mods[i]->mod_values[j]) && (LDAP_SUCCESS == rc)); j++) { + for (j = 0; ((mods[i]->mod_values) && + (mods[i]->mod_values[j]) && + (LDAP_SUCCESS == rc)); j++) { char *config_attr, *config_attr_value; config_attr = (char *)mods[i]->mod_type; config_attr_value = (char *)mods[i]->mod_bvalues[j]->bv_val; -- 2.5.5