Copied from bugzilla, because it seems to be ignored.
fedorapeople.org has a wildcard dns setup, so <anything>.fedorapeople.org is valid, and they all point to fedorapeople.org. In the interest of ssh known hosts checking it would be best if fedora-create-review just uploaded to fedorapeople.org not a subdomain. See: https://pagure.io/fedora-infrastructure/issue/10240 for more info.
fedorapeople.org has a wildcard dns setup, so <anything>.fedorapeople.org is valid, and they all point to fedorapeople.org.
In the interest of ssh known hosts checking it would be best if fedora-create-review just uploaded to fedorapeople.org not a subdomain.
See: https://pagure.io/fedora-infrastructure/issue/10240 for more info.
In fact, my ~/.config/fedora-create-review has upload_target = fedorapeople.org:public_html/, but upload_target specifically tries to workaround that https://pagure.io/FedoraReview/blob/master/f/src/FedoraReview/create_review.py#_296
~/.config/fedora-create-review
upload_target = fedorapeople.org:public_html/
upload_target
Having created a review with the upload_target patched to use an SSH host alias, I see what the problem is. The ReviewRequest.upload_target() is also used to determine the download URL.
ReviewRequest.upload_target()
I think this is wrong; the upload target and the download URL are different things, and there is no inherent relation between them in general. For fedorapeople.org, there does exist one, and the host substitution should only be done when determining the download URL, not the upload target.
fedorapeople.org
Will there be a release at some point to fix this? It's been merged for 2 months now.
@qulogic : just checking---did the fix make it to the latest release (if yes, please close this one).
Login to comment on this ticket.