#453 make_release does not work
Opened 2 years ago by salimma. Modified 2 years ago

Per @ngompa this is a known issue and when cutting 0.8.0 he used make_release only to get the source tarball. Filing to track.

FedoraReview on  master [⇡] via 🐍 v3.10.6 took 18s                                  
❯ ./make_release --help                                                               
Using branch:  master                                                                 
Last commit : b93191c fix flake8 E713                                                 

Running tests on tarball before finalizing release                                    
/home/michel/src/fedora/pagure/FedoraReview/make_release: line 93: restore-links.sh: N
o such file or directory                                                              
/home/michel/src/fedora/pagure/FedoraReview/make_release: line 94: ./run-tests: No suc
h file or directory                                                                   
Some tests failed. Review test logs and fix all problems                              
before doing a release.                                                               
Aborting. Temporary files left in /tmp/fedora-review-release-MYWSp

Metadata Update from @salimma:
- Issue set to the milestone: 0.9.0

2 years ago

Metadata Update from @salimma:
- Issue set to the milestone: Future (was: 0.9.0)

2 years ago

This is related to https://pagure.io/FedoraReview/c/07c45043b34d1b967d15490ae072f79772bff767?branch=master switching from distutils to setuptools: the resulting tarball is missing a lot of test files.

Repro: in the temp directory that make_review creates,

git checkout 07c45043b34d1b967d15490ae072f79772bff767^ setup.py
PYTHONPATH=src python3 setup.py build sdist

examine the tarball in dist and it now has a full set of directories in test/ and also test/restore-links.sh

The weird thing is @ngompa cut a 0.8.0 release after that which has all the required files, so I wonder if there's been an incompatible update to setuptools in the past few months.

Log in to comment on this ticket.

Metadata