#468 fedora-review incorrectly marks the license file
Opened 2 years ago by ksurma. Modified 7 months ago

There's a false positive in the output of a package (this: https://bugzilla.redhat.com/show_bug.cgi?id=2150785)

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file licenses_app.cpython-311.opt-1.pyc is not marked as
  %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

Interestingly, neither the other byte-code file /usr/lib/python3.11/site-packages/jupyterlab_server/__pycache__/licenses_app.cpython-311.pyc nor the original file /usr/lib/python3.11/site-packages/jupyterlab_server/licenses_app.py were included in the warning.
The listed file should have not be caught by fedora-review, it's not a license file.


Also met this issue with bug:
https://bugzilla.redhat.com/show_bug.cgi?id=2150574

though the LICENSE file is a license file and should already be covered by using %{pyproject_files}

  • licenses_app.cpython-311.opt-1.pyc from 2150785 is not a license (false report by fedora-review)
  • LICENSE from 2150574 is a license (correct report by fedora-review)

FTR I've seen the same error many times when mentioning license.png

- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file license.png is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

Log in to comment on this ticket.

Metadata