Issue #493: Incompatibility with Fedora 39 because of dead dependency - FedoraReview

FedoraReview

#493 Incompatibility with Fedora 39 because of dead dependency

Opened 8 months ago by rominf. Modified 8 months ago

I've tried to use fedora-review in Fedora 39 - it is incompatible.

$ fedora-review -b 2237913
Traceback (most recent call last):
  File "/usr/bin/fedora-review", line 22, in <module>
    from FedoraReview.review_helper import ReviewHelper
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 34, in <module>
    from .checks import Checks, ChecksLister
  File "/usr/lib/python3.12/site-packages/FedoraReview/checks.py", line 28, in <module>
    from straight.plugin import load  # pylint: disable=F0401
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/straight/plugin/__init__.py", line 1, in <module>
    from straight.plugin import loaders 
  File "/usr/lib/python3.12/site-packages/straight/plugin/loaders.py", line 7, in <module>
    from imp import find_module                                                                                                                                
ModuleNotFoundError: No module named 'imp'

The reason is that the dependency https://github.com/ironfroggy/straight.plugin/ is not maintained anymore, and it uses imp module which is dropped from Python 3.12.