FedoraReview

Clone
Source Code
GIT

#510 fedora-review fails repoquery cache-only calls
Opened a year ago by tflink. Modified 9 hours ago

Open
Close issue as:
not-a-bug fixed need-info

currently, fedora-review attempts fail with the following:

Error: Cache-only enabled but no cache for 'fedora'
ERROR: Exception down the road... (logs in /home/tflink/.cache/fedora-review.log)

Looking into the specified logfile, I find:

02-14 12:45 root         DEBUG    Running: mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean -qn --enable-network shell -- dnf-3 repoquery -C -l filesystem
02-14 12:45 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 236, in run
    self._do_run(outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 226, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 117, in _run_checks
    self.checks.run_checks(output=output, writedown=not Settings.no_report)
  File "/usr/lib/python3.12/site-packages/FedoraReview/checks.py", line 389, in run_checks
    run_check(name)
  File "/usr/lib/python3.12/site-packages/FedoraReview/checks.py", line 364, in run_check
    check.run()
  File "/usr/lib/python3.12/site-packages/FedoraReview/check_base.py", line 266, in run
    self.run_on_applicable()
  File "/usr/lib/python3.12/site-packages/FedoraReview/plugins/generic.py", line 477, in run_on_applicable
    filesys_dirs = set(deps.list_paths("filesystem"))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/FedoraReview/deps.py", line 304, in list_paths
    paths = check_output(cmd, universal_newlines=True)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['mock', '-r', 'fedora-rawhide-x86_64', '--no-cleanup-after', '--no-clean', '-qn', '--enable-network', 'shell', '--', 'dnf-3 repoquery -C -l filesystem']' returned non-zero exit status 1.

If I attempt the same command (mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean -qn --enable-network shell -- 'dnf-3 repoquery -C -l filesystem'), it does fail saying there is no cache. If I run mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean -qn --enable-network shell -- 'dnf-3 repoquery -l filesystem', that downloads the cache and succeeds. Additional calls with -C succeed after the cache is downloaded.

This is affecting my local rawhide install and appears to be affecting reviews in COPR (example of failed review in COPR) as well. I'm slightly unclear on if this is a problem with mock, dnf or fedora-review but I'm filing an issue to start with.

I think this should be fixed with mock 5.5?

Still fails...

Mock Version: 5.5
INFO: Mock Version: 5.5
INFO: Mock Version: 5.5
DEBUG: ensuring that dir exists: /var/lib/mock/fedora-rawhide-x86_64/root
DEBUG: ensuring that dir exists: /var/lib/mock/fedora-rawhide-x86_64-bootstrap
Start(bootstrap): chroot init

...

DEBUG: Running: mock -r fedora-rawhide-x86_64 -a http://dave.krotek.repo/fedora/releases/39 -a http://dave.krotek.repo/fedora/releases/40 --enable-network -v --no-cleanup-after --no-clean -qn --enable-network shell -- dnf-3 repoquery -C -l filesystem
Error: Cache-only enabled but no cache for 'fedora'
DEBUG: Exception down the road...

This started to happen to me after I rebuild a F40 toolbox image.

fedora-review 0.10.0 e79b66b 2023-07-24

Mock Version: 5.5

02-24 00:49 root         DEBUG    Running: mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean -qn --enable-network shell -- dnf-3 repoquery -C -l filesystem
02-24 00:49 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 236, in run
    self._do_run(outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 226, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 117, in _run_checks
    self.checks.run_checks(output=output, writedown=not Settings.no_report)
  File "/usr/lib/python3.12/site-packages/FedoraReview/checks.py", line 389, in run_checks
    run_check(name)
  File "/usr/lib/python3.12/site-packages/FedoraReview/checks.py", line 364, in run_check
    check.run()
  File "/usr/lib/python3.12/site-packages/FedoraReview/check_base.py", line 266, in run
    self.run_on_applicable()
  File "/usr/lib/python3.12/site-packages/FedoraReview/plugins/generic.py", line 477, in run_on_applicable
    filesys_dirs = set(deps.list_paths("filesystem"))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/FedoraReview/deps.py", line 304, in list_paths
    paths = check_output(cmd, universal_newlines=True)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['mock', '-r', 'fedora-rawhide-x86_64', '--no-cleanup-after', '--no-clean', '-qn', '--enable-network', 'shell', '--', 'dnf-3 repoquery -C -l filesystem']' returned non-zero exit status 1.
02-24 00:49 root         ERROR    Exception down the road... (logs in /var/home/kanru/.cache/fedora-review.log)
02-24 00:49 root         DEBUG    Report completed:  174.515 seconds

This is a duplicate of #511 but we didn't figure out the solution yet.

It started to work again. I didn't change anything.

It started working again some time ago and then it broke again a few days ago. I'm very confused what's going on here ...

Oh, I am confused too.
For the record, I am proposing this fix https://pagure.io/FedoraReview/pull-request/513
You can try if it helps in your situation.

@frostyx I think you deployed your proposed fix to the fedora-review service already? did it fix things?

If yes, it would be really great if we could get this merged and built for Fedora ... not being able to run fedora-review has really stalled package reviews for Rust stuff.

I just started seeing this for the first time today, running fedora-review on F39. I’m pretty sure I hadn’t updated any packages since the last time I ran fedora-review.

I think you deployed your proposed fix to the fedora-review service already?

@decathorpe yeah, I had to do something. Fedora Review Service was linking empty review.txt files and therefore was useless. Many people were reporting the problem.

I built https://koji.fedoraproject.org/koji/buildinfo?buildID=2418144 which contains the code from this PR as a downstream patch. This koji build is tagged in the infrastructure tags and therefore used by Copr (and transitively by Fedora Review Service). But I didn't submit a bodhi update for the users of fedora-review.

did it fix things?

A Copr build from today, the review.txt is fine for all chroots.

https://copr.fedorainfracloud.org/coprs/g/fedora-review/fedora-review-2269893-golang-github-makeworld-the-better-one-dither2/build/7173013/

I just manually installed fedora-review-0.10.0-7.fc39, and it fixed the problem for me.

Maybe we should go ahead and submit Bodhi updates.

Maybe we should go ahead and submit Bodhi updates.

There might be one issue though

The PR depends on https://github.com/rpm-software-management/mock/pull/1341 which was merged but not released yet

I'm still hitting this issue, and it's really affecting my ability to review packages. Can we finally do something here?

@decathorpe, I released a new version of Mock yesterday. I think it should help.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-95b3c15bef

Nope ...

[deca@neptune ~]$ rpm -q mock 
mock-5.6-1.fc40.noarch
[deca@neptune ~]$ rpm -q fedora-review 
fedora-review-0.10.0-5.fc40.noarch

Hit this today out of the blue: 

$ fedora-review --version
fedora-review version 0.10.0 e79b66b 2023-07-24 17:28:48 -0500
external plugins:
$ mock --version
5.6

The command I am running is:

fedora-review -b 2299129 --mock-options=--config-opts=mirrored=false

(because the new package depends on a freshly reviewed package that may not have made it to the new compose yet).

The log is:

07-30 11:46 root         DEBUG    Running: mock -r fedora-rawhide-x86_64 --config-opts=mirrored=false --no-cleanup-after --no-clean -qn --enable-network shell -- dnf-3 repoquery -C -l filesystem
07-30 11:46 root         DEBUG    Exception down the road...
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 236, in run
    self._do_run(outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 226, in _do_run
    self._do_report(outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 99, in _do_report
    self._run_checks(self.bug.spec_file, self.bug.srpm_file, outfile)
  File "/usr/lib/python3.12/site-packages/FedoraReview/review_helper.py", line 117, in _run_checks
    self.checks.run_checks(output=output, writedown=not Settings.no_report)
  File "/usr/lib/python3.12/site-packages/FedoraReview/checks.py", line 389, in run_checks
    run_check(name)
  File "/usr/lib/python3.12/site-packages/FedoraReview/checks.py", line 364, in run_check
    check.run()
  File "/usr/lib/python3.12/site-packages/FedoraReview/check_base.py", line 266, in run
    self.run_on_applicable()
  File "/usr/lib/python3.12/site-packages/FedoraReview/plugins/generic.py", line 477, in run_on_applicable
    filesys_dirs = set(deps.list_paths("filesystem"))
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/FedoraReview/deps.py", line 304, in list_paths
    paths = check_output(cmd, universal_newlines=True)
            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 466, in check_output
    return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.12/subprocess.py", line 571, in run
    raise CalledProcessError(retcode, process.args,
subprocess.CalledProcessError: Command '['mock', '-r', 'fedora-rawhide-x86_64', '--config-opts=mirrored=false', '--no-cleanup-after', '--no-clean', '-qn', '--enable-network', 'shell', '--', 'dnf-3 repoquery -C -l filesystem']' returned non-zero exit status 1.
07-30 11:46 root         ERROR    Exception down the road... (logs in /home/asinha/.cache/fedora-review.log)
07-30 11:46 root         DEBUG    Report completed:  97.973 seconds

It looks like the dnf-3 repoquery bit is wanting to use the cache and causing the failure here. Perhaps we need to remove the -C options from everywhere and let it recreate the cache whenever needed (if that's the issue?)?

$ fedora-review --version
fedora-review version 0.10.0 e79b66b 2023-07-24 17:28:48 -0500

Is the shown version reliable?
I expected something like this to happen because of PR #521 but if the version is correct, you shouldn't have it yet.

Not sure, I'm afraid. This is what rpm says:

$ rpm -q fedora-review
fedora-review-0.10.0-5.fc40.noarch

I don't see a 0.10.0-6 build for F40, though.

Using fedora-review from this commit with the patch included seems to work. Any reason why we aren't making this available to F40 users @frostyx ? (There's no build + update for F40, rather the build was deleted)

https://src.fedoraproject.org/rpms/fedora-review/c/5b0311f6431f43d902c095cd39b7b148bdccd91b?branch=rawhide

Any reason why we aren't making this available to F40 users @frostyx ? (There's no build + update for F40, rather the build was deleted)

No idea, I thought we shipped it. Anyway, I submitted updates for it.

The updates work for me, thanks very much.

I hit this issue even with the following packages installed:

  • fedora-review-0.10.0-11.fc40.noarch
  • mock-5.6-1.fc40.noarch
Edited 10 months ago by mavit

This bug is still affecting me :(

I found a "workaround" (if you can all it that). I removed the -C from this line.

I won't pretend to understand what is going on here but I thought it might be useful to somebody.

Log in to comment on this ticket.

Metadata
None
None
None
None
None
Related Pull Requests
  • #513 Merged a year ago
Powered by Pagure 5.14.1
Documentation • File an Issue • About • SSH Hostkey/Fingerprint
© Red Hat, Inc. and others.