| |
@@ -292,7 +292,7 @@
|
| |
"/packaging-guidelines/#_tags_and_sections"
|
| |
)
|
| |
self.text = (
|
| |
- "Packager, Vendor, PreReq, Copyright tags should not be in spec file"
|
| |
+ "Packager, Vendor, PreReq, Copyright, Group tags should not be in spec file"
|
| |
)
|
| |
self.automatic = True
|
| |
self.type = "SHOULD"
|
| |
@@ -300,7 +300,7 @@
|
| |
def run(self):
|
| |
passed = True
|
| |
output = ""
|
| |
- for tag in ("Packager", "Vendor", "PreReq", "Copyright"):
|
| |
+ for tag in ("Packager", "Vendor", "PreReq", "Copyright", "Group"):
|
| |
if not self.spec.find_re(r"^\s*" + tag + r"\s*:"):
|
| |
continue
|
| |
value = self.spec.expand_tag(tag)
|
| |
thebeanogamer
commented 11 months ago
The Fedora Packaging Guide lists
Groupas a SHOULD not use tag. Adding it here as it tripped me up in my package review.Apologies it this causes test failures, I'm having a lot of issues getting the tests to run and any guidance for that would be appreciated.
Copyright:,Packager:,Vendor:andPreReq:are actually listed as MUST NOT instead of SHOULD NOT, and I plan to raise a separate PR to move those over.