PR#494: Fix TypeError Which Was Breaking All Builds - FedoraReview

FedoraReview

#494 Fix TypeError Which Was Breaking All Builds

Closed 9 months ago by thebeanogamer. Opened 9 months ago by thebeanogamer.

thebeanogamer/FedoraReview fixtypeerror into master

Fix TypeError Which Was Breaking All Builds

Daniel Milnes • 9 months ago

bef9561

src/FedoraReview/deps.py

file modified

+1 -1

		`@@ -334,7 +334,7 @@`
		`except ValueError:`
		`# E. g., when given '(contains no files)'`
		`continue`
		`- mode = int(mode, 8)`
		`+ mode = int(mode[0], 8)`
		`if mode & 0o40000:`
		`dirs.append(path)`
		`else:`

thebeanogamer commented 9 months ago

Since 8eeadf2, mode has been a list. However, int is expecting a string. Because of this mismatch, all runs of fedora-review are currently failing the "Package must build in mock" check.