GoSIG / go2rpm

#34 Wrong spec name with new naming default
Closed by gotmax23. Opened by mikelo2.

Closed
Reopen Issue

Creating a spec from a package that ends with a number and has versioned goipath causes it to create a wrong naming:

$ go2rpm -f https://github.com/AdamSLevy/jsonrpc2 github.com/AdamSLevy/jsonrpc2/v14
golang-github-adamslevy-jsonrpc2-v1_4.spec
$ go2rpm -f https://github.com/AdamSLevy/jsonrpc2 github.com/AdamSLevy/jsonrpc2/v14 --no-use-new-versioning
golang-github-adamslevy-jsonrpc2-v14.spec

The correct spec name would be golang-github-adamslevy-jsonrpc_2-v14.spec.

The problem is in https://pagure.io/GoSIG/go2rpm/blob/master/f/go2rpm/main.py#_135

I don't think that's correct either; if we're now following the standard rules for compat packages, then the correct spec name would be golang-github-adamslevy-jsonrpc2_14.spec.

Another example:

$ go2rpm -f https://github.com/apparentlymart/go-textseg/ github.com/apparentlymart/go-textseg/v15
golang-github-apparentlymart-textseg-v1_5.spec

Fixed in https://pagure.io/GoSIG/go2rpm/pull-request/35

Metadata Update from @gotmax23:
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.