#82 Add git submodule contents to Release artifacts
Closed: Fixed by polcak. Opened by fufexan.

Summary

Currently, the source for nscl isn't present in the release tarball/zip, which makes it hard to track and update the exact revision.

Setup

Pages affected: no page
JShelter Version: all

Popup information (open JShelter popup on affected pages:

How to reproduce

Download one of the artifacts and unpack it, then check the nscl directory.

Expected result

The nscl directory contains the appropriate source at the specified revision.

Actual result

The nscl directory is empty.

Reproducibility

Is reproducible everywhere.

Workarounds

I have tried making an update script but it's so much uglier than just adding nscl to the tarball/zip.

Have you tried other steps to solve the issue?

See above.

Additional information / notes


Hello fufexan,

I guess that you mean https://pagure.io/JShelter/webextension/releases?

That page is populated by Pagure.io. I created an issue at https://pagure.io/pagure/issue/5378. I will close this one. Please let us know, if I did not get the report right.

Metadata Update from @polcak:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)

It is possible to upload a custom file to pagure. I created make_release.sh in 732065a. The files need to be manually uploaded to Pagure and are available at https://releases.pagure.org/JShelter/webextension/.

Metadata Update from @polcak:
- Issue status updated to: Open (was: Closed)

This is our best we can do atm

Metadata Update from @polcak:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Thank you for the fix!

Metadata