#510 Incorrect error handling in group_show_trim_memberof_done() could lead to NULL pointer dereference
Closed: Fixed Opened by sgallagh.

From Coverity:

At conditional (1): "!state->direct" taking the true branch.
Comparing "state->direct" to null implies that "state->direct" might be null.
  596        if (!state->direct) {
  597            tevent_req_error(req, ENOMEM);
  598        }
  599
Dereferencing null variable "state->direct".
  600        state->direct[state->ndirect] = talloc_strdup(state->direct, name);

We need to return from the function after calling tevent_req_error()


This is a valid bug, but please note that is applies only to 1.2 branch before the sysdb rewrite

Fields changed

milestone: NEEDS_TRIAGE => SSSD 1.2.1

Fixed by cf16f9d120c8e2802927dd72d4de74b8ba42ff0a

fixedin: => 1.2.1
keywords: => coverity
resolution: => fixed
status: new => closed

Fields changed

rhbz: => 0

Metadata Update from @sgallagh:
- Issue assigned to jhrozek
- Issue set to the milestone: SSSD 1.2.1

SSSD is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in SSSD's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/SSSD/sssd/issues/1552

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata