#2 Fix systemd-cd script
Merged by dcavalca. Opened by daandemeyer.
centos-sig-hyperscale/ daandemeyer/systemd-releng ci-script  into  main

Download 2.patch

This commit updates the systemd-cd script to take into account the
hyperscale systemd rpm changes. Included is a rewrite of the script
from bash to python to keep things more manageable. We apply any
downstream patches to the main branch before starting a build using
cbs. Any upstream backports are skipped.

I'm not too excited about this part. We could create two branches of off main with the downstream patches but I'm not sure how we'd keep those up-to-date. The other thing we could do is mirror the necessary branches in the pagure repo so we don't need to add separate remotes on github to get the actual backports.

Probably doing a mirror makes sense.

rebased onto 3ef1e8dbabbf560b87695f18f6b1c8bac2813fba

Probably makes sense to do this in Python (e.g. using re) instead of shelling out

We're going to need to extend this to support c9s as well

Please test this on OpenShift and make sure it actually works, lgtm otherwise.

2 new commits added

  • Fix systemd-cd script
  • systemd-git-update: Mirror in-progress PR branches to the repo

2 new commits added

  • Fix systemd-cd script
  • systemd-git-update: Mirror in-progress PR branches to the repo

2 new commits added

  • Fix systemd-cd script
  • systemd-git-update: Mirror in-progress PR branches to the repo

2 new commits added

  • Fix systemd-cd script
  • systemd-git-update: Mirror in-progress PR branches to the repo

2 new commits added

  • Fix systemd-cd script
  • systemd-git-update: Mirror in-progress PR branches to the repo

2 new commits added

  • Fix systemd-cd script
  • systemd-git-update: Mirror in-progress PR branches to the repo

Not a blocker, but probably worth reimplementing in python down the road

This should also be done in python

I think this is good to merge, that's for working on it!

Pull-Request has been merged by dcavalca

Metadata