Learn more about these different git repos.
Other Git URLs
Hello,
In the documentation it is written:
COPR auto-recognizes two types of repositories: upstream and downstream: Downstream repo: is empty (except .spec, README, tito.props, hidden files, currently) or contains at least one source or patch mentioned in the specfile Upstream repo: is not a downstream repo, meaning it contains something significant not mentioned in .spec as source or patch
But when I build a specfile containing patches, my repo is considered as Upstream repo. During the build I find the patches in extra_content:
PackageContent({'spec_path': '/tmp/tmp20g9t4iw/tomcat.spec', 'source_paths': ['/tmp/tmp20g9t4iw/tomcat-named.service', '/tmp/tmp20g9t4iw/tomcat-server', '/tmp/tmp20g9t4iw/tomcat-preamble', '/tmp/tmp20g9t4iw/tomcat-functions', '/tmp/tmp20g9t4iw/tomcat-7.0-jsvc.service', '/tmp/tmp20g9t4iw/tomcat-juli-OSGi-MANIFEST.MF', '/tmp/tmp20g9t4iw/tomcat-api-OSGi-MANIFEST.MF', '/tmp/tmp20g9t4iw/jasper-OSGi-MANIFEST.MF', '/tmp/tmp20g9t4iw/jasper-el-OSGi-MANIFEST.MF', '/tmp/tmp20g9t4iw/el-api-OSGi-MANIFEST.MF', '/tmp/tmp20g9t4iw/tomcat-7.0.service', '/tmp/tmp20g9t4iw/tomcat-7.0-log4j.properties', '/tmp/tmp20g9t4iw/jsp-api-OSGi-MANIFEST.MF', '/tmp/tmp20g9t4iw/servlet-api-OSGi-MANIFEST.MF', '/tmp/tmp20g9t4iw/tomcat-7.0-tool-wrapper.script', '/tmp/tmp20g9t4iw/tomcat-7.0-digest.script', '/tmp/tmp20g9t4iw/tomcat-7.0.logrotate', '/tmp/tmp20g9t4iw/tomcat-7.0.wrapper', '/tmp/tmp20g9t4iw/tomcat-7.0.sysconfig', '/tmp/tmp20g9t4iw/tomcat-7.0.conf'], 'extra_content': ['/tmp/tmp20g9t4iw/tomcat-7.0-catalina-policy.patch', '/tmp/tmp20g9t4iw/tomcat-7.0.54-rebase.patch', '/tmp/tmp20g9t4iw/tomcat-7.0-tomcat-users-webapp.patch', '/tmp/tmp20g9t4iw/tomcat-7.0-bootstrap-MANIFEST.MF.patch']})
In the source code, I can't find references to patches, only sources: https://pagure.io/copr/copr/blob/master/f/rpmbuild/copr_rpmbuild/providers/scm.py#_139
Is the documentation right ? Am I missing something ?
Cheers Romain
Actually, spec_info.sources also includes patches. They are flagged differently than sources.
Can you, please, provide, link to your build or git repo? I will look at it closely.
Thank you clime
Closing for lack of info.
Metadata Update from @clime: - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.