PR#1889: frontend: show more of general package information - copr/copr

copr / copr

#1889 frontend: show more of general package information

Merged 2 years ago by praiskup. Opened 2 years ago by frostyx.

copr/ frostyx/copr general-package-info into main

frontend: move package non-denylisted chroots to general information

Jakub Kadlcik • 2 years ago

8cbb275

frontend: show more of general package information

Jakub Kadlcik • 2 years ago

44b47f1

frontend/coprs_frontend/coprs/templates/coprs/detail/package.html

file modified

+26 -8

		`@@ -36,6 +36,7 @@`
		`</div>`
		`<div class="panel-body">`
		`<dl class="dl-horizontal">`
		`+`
		`{% if package.dist_git_url %}`
		`<dt> Dist Git Repo:</dt>`
		`<dd>`
		`@@ -44,6 +45,31 @@`
		`</a>`
		`</dd>`
		`{% endif %}`
		`+`
		`+ {% if package.webhook_rebuild %}`
		`+ <dt>Webhook rebuild:</dt>`
		`+ <dd>Yes</dd>`
		`+ {% endif %}`
		`+`
		`+ {% if package.max_builds %}`
		`+ <dt>Max builds:</dt>`
		`+ <dd>{{ package.max_builds }}</dd>`
		`+ {% endif %}`
		`+`
		`+ {% if package.chroot_blacklist_raw %}`
		`+ <dt>Excluded chroots:</dt>`
		`+ <dd>{{ package.chroot_blacklist_raw }}</dd>`
		`+ {% endif %}`
		`+`
		`+ {% if package.chroots \| length != package.copr.active_chroots \| list \| length %}`
		`+ <dt>Built only for:</dt>`
		`+ <dd>`
		`+ {% for chroot in package.chroots %}`
		`+ {{ chroot.name }}{% if not loop.last %},{% endif %}`
		`+ {% endfor %}`
		`+ </dd>`
		`+ {% endif %}`
		`+`
		`</dl>`
		`</div>`
		`</div>`
		`@@ -64,14 +90,6 @@`
		`<dd>`
		`{{ describe_source(package.source_type_text, package.source_json_dict, is_package=True) }}`
		`</dd>`
		`- {% if package.chroots \| length != package.copr.active_chroots \| list \| length %}`
		`- <dt>Built only for:</dt>`
		`- <dd>`
		`- {% for chroot in package.chroots %}`
		`- {{ chroot.name }}{% if not loop.last %},{% endif %}`
		`- {% endfor %}`
		`- </dd>`
		`- {% endif %}`
		`</dl>`
		`</div>`
		`</div>`

frostyx commented 2 years ago

Fix #509

zuul commented 2 years ago

Build succeeded.

csdiff-pylint : SUCCESS in 1m 29s

praiskup commented on line 20 of frontend/coprs_frontend/coprs/templates/coprs/detail/package.html 2 years ago

There's the Built only for item ... (+ I'm mostly against using the baned keyword, even though I understand that we should stay consistent).

praiskup commented 2 years ago

Otherwise +1, the comment above can be ignored if you don't mind.

rebased onto 7b14a00de7d6917a4d412fe0ba9013b73280cebf

2 years ago

frostyx commented 2 years ago

I didn't see the "Built only for", it appears only when some chroot is in fact excluded (i.e. when you type a nonsense word into the Chroot blacklist field, the "Built only for" doesn't show up. Which is probably a good thing). Anyway, I moved it up to the General Information section. I kept the raw version of blacklist value as well but I renamed it to Excluded chroots

zuul commented 2 years ago

Build succeeded.