PR#2290: frontend: stg frontend instance should link to stg FAS instance - copr/copr

copr / copr

#2290 frontend: stg frontend instance should link to stg FAS instance

Merged 2 years ago by frostyx. Opened 2 years ago by nikromen.

copr/ nikromen/copr fix-sign-up-link into main

frontend: stg frontend instance should link to stg FAS instance

Jiri Kyjovsky • 2 years ago

a426bc8

file modified

		`@@ -145,6 +145,8 @@`
		`# 'measure.py' module for more info.`
		`DEBUG_CHECKPOINTS = False`

		`+ FAS_SIGNUP_URL = "https://accounts.fedoraproject.org/"`
		`+`

		`class ProductionConfig(Config):`
		`DEBUG = False`

frontend/coprs_frontend/coprs/context_processors.py

file modified

+1 -1

		`@@ -65,7 +65,7 @@`

		`if config['FAS_LOGIN']:`
		`menu.append({`
		`- 'link': 'https://accounts.fedoraproject.org/',`
		`+ 'link': config["FAS_SIGNUP_URL"],`
		`'desc': 'sign up',`
		`})`

nikromen commented 2 years ago

this logic applies to all non-production instances (test, local, devel)

Closes #2278

zuul commented 2 years ago

Build succeeded.

csdiff-pylint : SUCCESS in 58s

rebased onto ab531e129c3a3bac9d20a05f05799c4aeb47cd38

2 years ago

zuul commented 2 years ago

Build succeeded.

csdiff-pylint : SUCCESS in 1m 06s

zuul commented 2 years ago

Build succeeded.

csdiff-pylint : SUCCESS in 1m 03s

frostyx commented 2 years ago

Thank you for the PR @nikromen.

Feat(frontend): stg frontend instance should link to stg FAS instance

We try to follow this commit message format

frontend: stg frontend instance should link to stg FAS instance

frostyx commented on line 8 of frontend/coprs_frontend/coprs/context_processors.py 2 years ago

What if we put the URL into config.py and into /etc/copr/copr.conf for our devel and production instances?

We already have some of the production/staging URLs defined there (e.g. PUBLIC_COPR_BASE_URL or FEDMENU_URL)
https://pagure.io/fedora-infra/ansible/blob/main/f/roles/copr/frontend/templates/copr.conf

rebased onto 736e409eea15101f4c5f1ed900ffe62a36d14d65

2 years ago

zuul commented 2 years ago

Build succeeded.

csdiff-pylint : SUCCESS in 55s

frostyx commented 2 years ago

I like this better now :-)

Just nitpicking but since we are using the URL for the sign up button, I would rename the variable to something like FAS_REGISTER_URL or FAS_SIGNUP_URL.

Except for that, I like both this PR and the ansible PR.

rebased onto a426bc8

2 years ago

zuul commented 2 years ago

Build succeeded.