PR#740: [frontend] correctly describe "Create repositories manually" - copr/copr

copr / copr

#740 [frontend] correctly describe "Create repositories manually"

Merged 6 years ago by msuchy. Opened 6 years ago by praiskup.

Unknown source fix-739 into master

[frontend] correctly describe "Create repositories manually"

Pavel Raiskup • 6 years ago

33175fa

frontend/coprs_frontend/coprs/forms.py

file modified

+3 -4

		`@@ -285,10 +285,9 @@`

		`disable_createrepo = wtforms.BooleanField(default=False,`
		`label="Create repositories manually",`
		`- description="""When Fedora is branched from rawhide, the`
		`- respective chroots for the new branch are automatically`
		`- created for you (as soon as they are available) as rawhide`
		`- chroot forks.""",`
		`+ description="""Repository meta data is normally refreshed`
		`+ after each build. If you want to do this manually, turn`
		`+ this option on.""",`
		`false_values=FALSE_VALUES)`

		`unlisted_on_hp = wtforms.BooleanField(`

praiskup commented 6 years ago

This is C&P bug caused by 3e7c629.

Fixes: #739, PR#740

msuchy commented 6 years ago

frostyx commented 6 years ago

check the option above.

Feels a little confusing to me ("option above" sounds like we are talking about not this option, but the one even more above), I would prefer something like

"If you want to do it manually, turn this option off"

Just a suggestion, not a requirement, +1 even for the current version of this PR.

praiskup commented 6 years ago

I noticed this as well :-), I'll use your wording. Thanks.

rebased onto 9393a79194b4af004ec27ffcb57881a08d2e6289

6 years ago

rebased onto 33175fa

6 years ago

praiskup commented 6 years ago

OK to merge?