#2882 [CI] Removing duplicate tests
Closed 6 years ago Opened 6 years ago by edewata.

Currently some CI tests are executed twice. First, they run with Python 2. Then some files are copied/modified. Then the same tests run again with Python 3.

https://github.com/dogtagpki/pki/blob/92341c5be2cc631e5609049f8b16ed7c65058df4/.travis_run_task.sh#L71

 docker exec -i ${CONTAINER} ${SCRIPTDIR}/20-install-rpms
 docker exec -i ${CONTAINER} ${SCRIPTDIR}/30-setup-389ds
 # Test whether pki subsystem works correctly
 docker exec -i ${CONTAINER} ${SCRIPTDIR}/40-spawn-ca
 docker exec -i ${CONTAINER} ${SCRIPTDIR}/50-spawn-kra
 docker exec -i ${CONTAINER} ${SCRIPTDIR}/99-destroy
 # copy pki.server for Python 3
 docker exec -i ${CONTAINER} ${SCRIPTDIR}/py3rewrite
 docker exec -i ${CONTAINER} ${SCRIPTDIR}/30-setup-389ds
 docker exec -i ${CONTAINER} ${SCRIPTDIR}/40-spawn-ca
 docker exec -i ${CONTAINER} ${SCRIPTDIR}/50-spawn-kra
 docker exec -i ${CONTAINER} ${SCRIPTDIR}/99-destroy

Python 3 support is not actually required before Fedora 28. Also, there's already a separate IPA test that (possibly) runs with Python 3.

It would be better to test Python 3 with a platform that uses it by default, i.e. add CI test for Fedora 28, so the duplicate tests can be removed. The CI test should not need to modify the files provided by PKI packages.

Also, if PKI supports Python 3 on a specific platform, the PKI package for that platform should provide the proper Python 3 library files. The CI test should not need to copy the library files.


Metadata Update from @mharmsen:
- Custom field component adjusted to None
- Custom field feature adjusted to None
- Custom field origin adjusted to None
- Custom field proposedmilestone adjusted to None
- Custom field proposedpriority adjusted to None
- Custom field reviewer adjusted to None
- Custom field type adjusted to None
- Custom field version adjusted to None
- Issue set to the milestone: 0.0 NEEDS_TRIAGE

6 years ago

Per PKI Team Meeting of 20180109: 10.6

Metadata Update from @mharmsen:
- Issue set to the milestone: 10.6 (was: 0.0 NEEDS_TRIAGE)

6 years ago

Metadata Update from @dmoluguw:
- Issue assigned to dmoluguw

6 years ago

Metadata Update from @edewata:
- Issue set to the milestone: 10.6.2 (was: 10.6)
- Issue status updated to: Closed (was: Open)

6 years ago

Dogtag PKI is moving from Pagure issues to GitHub issues. This means that existing or new
issues will be reported and tracked through Dogtag PKI's GitHub Issue tracker.

This issue has been cloned to GitHub and is available here:
https://github.com/dogtagpki/pki/issues/3000

If you want to receive further updates on the issue, please navigate to the
GitHub issue and click on Subscribe button.

Thank you for understanding, and we apologize for any inconvenience.

Login to comment on this ticket.

Metadata