dotnet-sig / dotnet-2-2

#3 Clean up and prepare for RHEL 8 compatiblity
Merged by omajid. Opened by omajid.
dotnet-sig/ omajid/dotnet-2-2 master  into  master

Download 3.patch

  • Rename spec file to dotnet2.2 to meet Fedora guidelines:
    https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_multiple_packages_with_the_same_base_name
    This does not change the names of the binary packages.

  • Link executibles with -pie:
    https://fedoraproject.org/wiki/Changes/Harden_All_Packages#Detailed_Harden_Flags_Description

  • Build using python3. See
    https://fedoraproject.org/wiki/FinalizingFedoraSwitchtoPython3

  • Add RHEL 8 runtime ids

  • Conditionalize build to support bundled/system libunwind

  • Do not error out build on prebuilt baseline issues

rebased onto 3a74a659593522d43fca87575e6519c27196c164

Hey, @tmds, this removes the-sdk-2.2.1xx subpackage. Does that sound okay to you?

rebased onto 819ad382e5e2806d63b4c52c060fe9d2e4251d89

rebased onto fd5742f93442a4a1369bbf723e8088ec6e49480f

rebased onto ba661f23887490d6aa8fd82e41c92c335f4574b2

rebased onto 79d25f5b676594ea1d49e75d3c6e98f80da4bb4f

This message should be updated to reflect the desire for python3.

Other than my comment about in python install message, this looks good to me.

Hey, thanks for the review.

I didn't actually change the re-wording because Python 3 is implicit in "Python 2.7.9 or later". Does that make sense? Do you still think it's worth calling out explicitly?

Also, please note that this patch is a direct export via git show from upstream: https://github.com/dotnet/coreclr/pull/22145. We should fix this upstream if a fix is actually needed.

Honestly, it's not a big deal. I just figured if there was a preference for python3 then maybe that should be called out in the message. I don't think it really matter either way.

Thanks for the review! Merging.

Pull-Request has been merged by omajid
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.