The only property from elections-messages that does not conform to the fedora-messaging requirements was the "agent" property which needed to be changed to "agent_name".

Hmm, I remember a discussion that for services like this one, the agent property should be kept around so existing users don’t break.

There's a typo, should be agent_name.

Fixed the typo, pointed agent property to agent_name, included a deprecation warning for the agent property.

Should this return a list?

This should stay I guess.

Same here

… and here

… and here:

        "properties": {
            "agent": {"type": "string"},
            "agent_name": {"type": "string"},
            "election": ELECTION_SCHEMA
        },

… and here 🙂

Additionally I'd add a test for the compat functionality, i.e. access the agent property, verify it's the same result object as the agent_name property returns and that a warning has been logged (see the caplog pytest fixture).

i test the warning in bodhi messages tests with pytest.warns

i test the warning in bodhi messages tests with pytest.warns

Good idea, that's probably less complicated than having to set the log level and grepping for the right message.

Tests passed

Let's rather wrap the long strings above than bump the allowed line length. 😁

will do

Changes pushed

Looks good to me, would you trim the commit log message?

Commit message trimmed

No idea why I didn’t notice it before, but why is self.agent_name wrapped in a list here? I assume agent was a string before and it’s declared that way below.

You're right, changed it

Looks good to me, thanks!

@abompard, would you please merge?