Currently the readability of meeting detail is not the best. At first sight it't hard to tell what is the meeting description and what is the name of meeting and calendar.
In attachment I did quick propose of design improvement. Reasons of changes are from top to bottom:
attachment <img alt="proposal.png" src="/fedocal/issue/raw/files/1f22a31b98a7ca9fe17530ff6d26d8c3544ca2d6733e79e1de99266521dd2d15-proposal.png" />
The date/time/timezone information on how the meeting is stored in interesting as it gives you an idea if this meeting will change because of Summer/Winter time.
The clickable nick for the organizer is an idea but pointing to what? username@fp.o?
After the color depends on the header and blue is higher than orange, so compared to your proposal the colors will likely be inverted.
Finally note that in git, hovering over the date gives you the date/time in UTC.
The rest looks quite nice indeed. I only wonder if we want that in 0.7 (soon) or 0.8 (a little later)
The "Stored in" section is important, but I believe mainly for the meeting organizer. I assume the consumers won't really think about time shifts (which happen just twice a year) so deeply, so it's just a clutter for them. Also, they should see whether the meeting time will be the same or moved in some of the following weeks by simply looking into fedocal/their calendar application. They don't need to think too much about this, just scroll a bit in the time line.
So in order to simplify the interface, I'd like to show the "stored in" section only to people who have the permissions to edit the meeting. And after consulting with lbrabec, the logical conclusion was that those people can easily see the information when they click "edit" on the meeting details page, so it's not necessary to display it on the details page at all.
Screenshot revision #1 <img alt="Screenshot_fedocal.png" src="/fedocal/issue/raw/files/cab4af4bf05f94bbaebd78c75a48ad86bb5871107fe2a6c855ef1943a4a0d986-Screenshot_fedocal.png" />
I can easily apply the same check for the edit/delete button to the store in field. Maybe we can also move it down the page.
store in
Logged in as editor <img alt="Screenshot_fedocal2_logged.png" src="/fedocal/issue/raw/files/89fb5aceaea912b9c9aaaa667ebb7740f9368abaccd11b9c1b917d4897fb319d-Screenshot_fedocal2_logged.png" />
Logged out <img alt="Screenshot_fedocal2_logout.png" src="/fedocal/issue/raw/files/3e534a715f5ea46d8e11ad161ed30521ba4a0cfbe4c6f87323b2cf4911ac3a6a-Screenshot_fedocal2_logout.png" />
Proposals with the stored in field hidden for non-editor and lowered in the page
stored in
If you want to keep it in, it makes sense to move it to the bottom, yes.
Can we get rid of the "Displayed in: $timezone" line? It's not necessary, since the timezone is displayed along with the time anyway.
Otherwise it's fine I think.
(A great future feature would be to convert the timezone identifier behind the meeting time into a drop-down list. If the person selected a different timezone, the time would re-draw into the chosen timezone. It would be particularly helpful for logged out people).
This is already present in the main calendar view, for a specific meeting, I'm not sure.
Up for review at : https://github.com/fedora-infra/fedocal/pull/127
Merged
Log in to comment on this ticket.