#179 Port fedocal to fedora-messaging and drop fedmsg support
Merged by pingou. Opened by jlanda.
jlanda/fedocal fedora-messaging  into  master

Download 179.patch
no initial comment

Why this isn't calling the publish method from fedocal/fedocallib/fedmsgshim.py?

It looks good only one question.

Because fedmsg implementation was not using it either :D

The intent of this commit was just moving from fedmsg to fedora-messaging. No new logic, features etc.

This should be an ongoing work and continue evolving with an fedora-messaging scheme and perhaps a service like in release-monitoring for the periodic jobs instead of a cron script

In this case I'm giving :thumbsup:

@jlanda, could you rebase this PR?

rebased onto 4ab75725d13613fa0c037e3d2b5b7e3745c64609

@jlanda, could you rebase this PR?

done (and toggle changed)

@jlanda considering we're importing other parts of fedocal, I guess it makes sense to re-use the same code path here as well. Could you make the change?

@jlanda considering we're importing other parts of fedocal, I guess it makes sense to re-use the same code path here as well. Could you make the change?

Okido

@pingou Is there anything left to do on this one? or can it be merged?

@pingou Is there anything left to do on this one? or can it be merged?

I need to change the cron file to reuse the same code. I'll work on it today

rebased onto 7b327fb2051e3b00576b07c6b6dae8b6b9308448

rebased onto 8415a1b79d07668cc5840cac2782656927f535f2

Let's get this in, thanks @jlanda !

Pull-Request has been merged by pingou

Metadata