#212 Issue #152: Adding optional reminder_delta flag
Merged 6 months ago by humaton. Opened 2 years ago by rwright.
rwright/fedocal ical-reminder  into  master

file modified
+18 -2
@@ -619,7 +619,15 @@ 

      for calendarobj in Calendar.get_all(SESSION):

          meetings.extend(fedocallib.get_by_date(

              SESSION, calendarobj, startd, endd, extended=False))

-     fedocallib.add_meetings_to_vcal(ical, meetings)

+     try:

+         reminder = datetime.timedelta(

+             minutes=-1 * int(

+                 (flask.request.args.get('reminder_delta') or '').strip()

+             )

+         )

+     except ValueError:

+         reminder = None

+     fedocallib.add_meetings_to_vcal(ical, meetings reminder=reminder)

      headers = {}

      filename = secure_filename(

          'all_calendars-%s.ical' % (
@@ -650,7 +658,15 @@ 

      meetings = fedocallib.get_by_date(

          SESSION, calendarobj, startd, endd, extended=False, tzone=False)

      ical = vobject.iCalendar()

-     fedocallib.add_meetings_to_vcal(ical, meetings)

+     try:

+         reminder = datetime.timedelta(

+             minutes=-1 * int(

+                 (flask.request.args.get('reminder_delta') or '').strip()

+             )

+         )

+     except ValueError:

+         reminder = None

+     fedocallib.add_meetings_to_vcal(ical, meetings reminder=reminder)

      headers = {}

      filename = secure_filename(

          '%s-%s.ical' % (

Adds reminders flag similar to the single meeting option. Addressing Issue #152

I am not sure who the right person to review this is. @pingou is the creator and @bookwar is the maintainer. Not sure if any CPE team members could take a look at this PR?

CC: @abompard @ryanlerch @t0xic0der

In this issue @james noted this looks ready. @pingou @bookwar @abompard what are your thoughts?

I would :heart: to see this merged and deployed.

rebased onto fff15b0

6 months ago

I think this is good to go.

Pull-Request has been merged by humaton

6 months ago
Metadata