fedora-asahi / kiwi-descriptions

#10 remove grub2 x86_64 packages
Merged by ngompa. Opened by leifliddy.
Unknown source rawhide

Download 10.patch

This should be pretty self-explanatory.
I'm not sure why we're specifying x86_64 packages here in the first place.
Also....grub2-pc-modules is actually a noarch package that contains i386 grub modules -- so that doesn't pertain to aarch64 systems (unless you're cross-compiling images)
I'm not sure why we're not putting the kernel packages under "Asahi Packages" -- as these kernel rpms are located in the Asahi repo.
Also, I'm not sure why we're specifying kernel-modules-extra as a core boot package -- it's not.
However, I'm leaving open the possibility that I'm missing something here.
...as I'm often reminded of this quote:

"Whenever you remove any fence, always pause long enough to ask why it was put there in the first place."
— Gilbert K. Chesterton

They were originally added because I forked this from a set of descriptions to build generic Fedora x86_64 and ARM images. As for kernel-modules-extra, that's where the ARM Mac kmods live, so it'd be bad to not include it.

I'm not sure why we're not putting the kernel packages under "Asahi Packages" -- as these kernel rpms are located in the Asahi repo.

We're not doing this because it intentionally is supposed to allow either the stock kernel or ours depending on the repo configuration.

So I'm looking at the modules included in
https://download.copr.fedorainfracloud.org/results/ngompa/fedora-asahi-dev/fedora-37-aarch64/05159052-kernel/kernel-modules-extra-6.1.0-0.rc8.105.asahi.fc37.aarch64.rpm

...and I'm not seeing any arm mac-specific kmods there.
Which modules are you referring to?

They were originally added because I forked this from a set of descriptions to build generic Fedora x86_64 and ARM images.

So is there any issue with removing these non-pertinent x86_64 descriptions?

I don't get why we can't just use arch-specific descriptions like this (except for aarch64):
https://github.com/OSInside/kiwi-descriptions/blob/master/fedora/x86_64/fedora-37.0/config.xml

Otherwise, it might give the impression to the casual-user that multiple architectures are supported.

tbh, this is all pretty trivial. Just delete this PR if you feel that nothing needs to change.

Edited by leifliddy

Pull-Request has been merged by ngompa
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.