fedora-ci / general

#195 validate messages before sending them onto the bus
Opened by pingou. Modified

Open
Close Issue

Just before the break, a few messages (at least 5) have made it to the Fedora messaging bus which did not comply with the message schema (or my understanding of them). See https://pagure.io/fedora-infrastructure/issue/9545 for more information.

Would it be possible to have the pipeline check the validity of the message payload against the message schemas that are in https://pagure.io/fedora-ci/messages/ before they are sent onto the bus?

@mvadkert @msrb it seems pagure can sometimes send message with commit_stop being null, what cause the problem on old and new pipelines.

example of pagure message: https://apps.fedoraproject.org/datagrepper/id?id=2020-a9ff4dfb-d965-49dd-a052-397bb7631c41&is_raw=true&size=extra-large

What should the pipeline use as commit_hash in these cases, as commit_hash is a required field in the ci message?

https://pagure.io/fedora-ci/messages/blob/master/f/schemas/pull-request.yaml#_32
Edited by bgoncalv

I guess the correct solution is to get the HEAD of the master branch in this case and use that as commit_hash ... we can do that or make

Metadata
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.