Issue #284: rpminspect JSONDecodeError - general

fedora-ci / general

#284 rpminspect JSONDecodeError

Closed Oct 13, 2021 by msrb. Opened Sep 21, 2021 by msrb.

https://osci-jenkins-1.ci.fedoraproject.org/job/fedora-ci/job/rpminspect-pipeline/job/master/44875/testReport/junit/(root)/tests/_upstream/

Traceback (most recent call last):
  File "/usr/local/bin/rpminspect_json2text.py", line 115, in <module>
    process_results(args.rpminspectjson, args.resultsdir)
  File "/usr/local/bin/rpminspect_json2text.py", line 43, in process_results
    inspections = json.loads(f.read().decode('utf-8', 'ignore'))
  File "/usr/lib64/python3.10/json/__init__.py", line 346, in loads
    return _default_decoder.decode(s)
  File "/usr/lib64/python3.10/json/decoder.py", line 337, in decode
    obj, end = self.raw_decode(s, idx=_w(s, 0).end())
  File "/usr/lib64/python3.10/json/decoder.py", line 355, in raw_decode
    raise JSONDecodeError("Expecting value", s, err.value) from None
json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)

Metadata Update from @msrb:
- Issue assigned to msrb

Sep 21, 2021

msrb commented Sep 21, 2021

@mvadkert judging by the tmt-environment.yaml, it seems like TMT is receiving empty env. variable arches="" as arches="''".

Did something around env handling change recently in TMT/testing farm?

msrb commented Sep 21, 2021

This is how the API call looks like:

     "variables": {
        "ARCHES": "",
        "CONFIG_BRANCH": "rawhide",
        "DEBUG": "off",
        "DEFAULT_RELEASE_STRING": "fc36",
        "GIT_COMMIT": "802275e0e1b0d72860b24c9a2dc66a300b4b4ee3",
        "PREVIOUS_TAG": "f36-updates",
        "REPOSITORY_URL": "https://src.fedoraproject.org/rpms/pypy",
        "RPMINSPECT_PROFILE_NAME": "rawhide",
        "TASK_ID": "76019644"
      }

https://api.dev.testing-farm.io/v0.1/requests/83d69978-3fc0-45fb-9698-db1e9162f563

msrb commented Sep 21, 2021

Since we don't use the ARCHES option anymore, I am going to drop it from the pipeline. That should mitigate this issue.

mvadkert commented Sep 21, 2021

@msrb thanks, yes it did change (TFT-663), I will fix this, those variables should not be exposed at all in this case.

mvadkert commented Sep 22, 2021

@msrb maybe a similar problem in #285 ?

msrb commented Sep 29, 2021

@mvadkert yes, but I cannot workaround it for installability as I did for rpminspect.

root: /var/ARTIFACTS/workdir-repository-None-10BmOg
plans:
  - /installability
steps:
  - provision
  - discover
  - finish
  - prepare
  - execute
  - report
environment:
    ADDITIONAL_TASK_IDS: "''"
    PROFILE_NAME: fedora-36
    TASK_ID: '76050976'
remove: false

That ADDITIONAL_TASK_IDS params is either empty or it contains additional artifacts (for side-tags). So I cannot just drop it as I did in rpminspect pipeline.

We will need to get that TF fix in as this is causing failures for all installability runs in Fedora CI.

mvadkert commented Sep 29, 2021

ack, we will fix this, already tried, but was not able to finish it.

mvadkert commented Sep 29, 2021

hopefully later today

msrb commented Oct 13, 2021

This should be fixed!

Metadata Update from @msrb:
- Issue status updated to: Closed (was: Open)

Oct 13, 2021