Issue #298: Zuul runs TMT tests with an empty context - general

fedora-ci / general

#298 Zuul runs TMT tests with an empty context

Closed Dec 6, 2021 by fbo. Opened Nov 17, 2021 by happz.

Fedora CI dist-git tests (http://artifacts.dev.testing-farm.io/7a414080-a513-4c7b-b36b-33fe102479fa/work-defaultgNn_R4/log.txt):

16:01:35 info
16:01:35     environment: {}
16:01:35     context: {'trigger': ['commit'], 'arch': ['x86_64'], 'distro': ['fedora-36']}

Zuul's rpm-tmt-test (http://artifacts.dev.testing-farm.io/c5a7c098-c506-48c3-b3f6-cabe5b32f93f/work-defaultGj3fJg/log.txt):

13:39:36 info
13:39:36     environment: {}
13:39:36     context: {}

This cripples TMT's adjust, e.g.

adjust:
  - environment+:
      CXXLIB: "libc++"
    require:
      - clang
      - lld
      - compiler-rt
      - libcxx-devel
      - libcxx-static
      - glibc-devel
      - glibc-static
      - gcc
    when: "distro == fedora"
    because: testing against libcxx package in Fedora

would fail to apply because distro is not defined.

For more details, e.g. https://fedora.softwarefactory-project.io/zuul/buildset/547a70eaea844d439d0601c44742b430 and http://artifacts.dev.testing-farm.io/7a414080-a513-4c7b-b36b-33fe102479fa/ ran the same set of tests.

mvadkert commented Nov 17, 2021

indeed, this is actually something which slipped through review. @guyinger can you please add environemnts[].tmt.context to the role? We need to set it. It should have the advised content, i.e.

"tmt": {
    "context": {
        "trigger": "commit",
        "arch": "x86_64",
        "distro": "fedora-36"
    }
}

Metadata Update from @mvadkert:
- Issue assigned to guyinger
- Issue priority set to: High (was: Medium)
- Issue tagged with: Testing Farm, Zuul CI

Nov 17, 2021

guyinger commented Nov 17, 2021

@mvadkert https://pagure.io/fedora-zuul-jobs-config/pull-request/141#

Edited Dec 2, 2021 by guyinger

fbo commented Dec 3, 2021

A fix has been provided for this by @guyinger. Could you confirm the expected behavior ?

happz commented Dec 3, 2021

Ack, I restarted CI steps in https://src.fedoraproject.org/rpms/clang/pull-request/135, changes in that patch do depend on context and distro, we shall see the outcome.

fbo commented Dec 6, 2021

Thanks. It seems to be fixed. I'm closing the issue. Please re-open if needed.

Metadata Update from @fbo:
- Issue status updated to: Closed (was: Open)

Dec 6, 2021

happz commented Dec 6, 2021

Yep, everything looks green, thanks for the fix!