#507 Upgrade tmt to 1.38 in Fedora CI
Closed by msrb. Opened by fhrdina.

Hi,
we want to enable AVC testing In Testing Farm, which is disabled by default. It can be enabled for the fmf plans, like this:

  summary: Run all tests
  discover:
      how: fmf
+     adjust-tests:
+     - check+:
+       - avc
  execute:
      how: tmt

However, this functionality comes in tmt version 1.38. Could you upgrade tmt to this version or newer, please?

Thanks


@fhrdina howdy, Testing Farm should be using tmt-1.41 nowadays, I assume you are hitting this with Fedora CI, can you share some logs maybe?

@fhrdina howdy, Testing Farm should be using tmt-1.41 nowadays, I assume you are hitting this with Fedora CI, can you share some logs maybe?

Hello @mvadkert,

yeah, I mean Fedora CI.

https://artifacts.dev.testing-farm.io/deee6e6c-ea44-4fe0-a603-1b3b21cf80d6

Hello @fhrdina. I double-checked - we are running tmt-1.41 in the public ranch. I reproduced the issue and it looks like a bug in tmt. There are two conflicting definitions of checks:

  • One in Sanity/bodycheck/main.fmf - check: avc creates an str check object
  • The second one in plan definitions - - check+: - avc creates a list check object

tmt tries to concatenate two objects, and fails with the MergeError: Key 'check' in /Sanity/bodycheck (can only concatenate str (not "list") to str). error.

I will report it to tmt team, in the meantime you can define avc check as a list in the Sanity/bodycheck/main.fmf as a workaround - it seems these two definitions do not contradict with each other:

check:
  - avc

Hello @fhrdina. I double-checked - we are running tmt-1.41 in the public ranch. I reproduced the issue and it looks like a bug in tmt. There are two conflicting definitions of checks:

  • One in Sanity/bodycheck/main.fmf - check: avc creates an str check object
  • The second one in plan definitions - - check+: - avc creates a list check object

tmt tries to concatenate two objects, and fails with the MergeError: Key 'check' in /Sanity/bodycheck (can only concatenate str (not "list") to str). error.

I will report it to tmt team, in the meantime you can define avc check as a list in the Sanity/bodycheck/main.fmf as a workaround - it seems these two definitions do not contradict with each other:
check: - avc

Hm, that could be the issue, I will try to remove it from that test and see if it helps. Thanks!

Hello @fhrdina. I double-checked - we are running tmt-1.41 in the public ranch. I reproduced the issue and it looks like a bug in tmt. There are two conflicting definitions of checks:

  • One in Sanity/bodycheck/main.fmf - check: avc creates an str check object
  • The second one in plan definitions - - check+: - avc creates a list check object

tmt tries to concatenate two objects, and fails with the MergeError: Key 'check' in /Sanity/bodycheck (can only concatenate str (not "list") to str). error.

I will report it to tmt team, in the meantime you can define avc check as a list in the Sanity/bodycheck/main.fmf as a workaround - it seems these two definitions do not contradict with each other:
check: - avc

Hm, that could be the issue, I will try to remove it from that test and see if it helps. Thanks!

It still does not work. Not sure if the problem is the definition of avc check in fmf plan, or Testing Farm does not work at the moment.
https://artifacts.dev.testing-farm.io/c595af46-db43-44cc-9857-d94c9d51c5ed/

The rawhide job is failing due to move of the binaries:

14:24:35             err: No match for argument: /usr/sbin/ausearch
14:24:35             err: No match for argument: /usr/sbin/sestatus

We have a fix for that:

  • https://github.com/teemtee/tmt/pull/3471

Already merged, but not yet deployed in Testing Farm.

The rawhide job is failing due to move of the binaries:

14:24:35 err: No match for argument: /usr/sbin/ausearch
14:24:35 err: No match for argument: /usr/sbin/sestatus

We have a fix for that:

  • https://github.com/teemtee/tmt/pull/3471

Already merged, but not yet deployed in Testing Farm.

Thanks.
So this ticket can be closed from my pov.

Metadata Update from @msrb:
- Issue status updated to: Closed (was: Open)

Metadata