#51 Is original_spec_nvr still needed
Closed 4 years ago by jimbair. Opened 5 years ago by cverna.

Hi all when querying greenwave bodhi is sending the following parameter original_spec_nvr with the nvr of the koji build, this was due to historical reason when the ci pipeline changed the nvr ( see https://pagure.io/greenwave/issue/34)

Do you guys know if this is still happening ? or if it is safe for us to drop that param ?


Ping ? Anyone able to help answer this question ?

We do not use this param when using Greenwave, but I am not sure if it is needed in some cases or not ...

Maybe @gnaponie @lucarval or @ralph know?

I'm not aware of any change.
Please, let's wait some feedback from @adamwill.

Well, we need to use a query that will find the correct pipeline results. IIRC, Taskotron results include the NEVR of the package under test as the item. item is sort of intended to be used for this purpose, I think, but for whatever reason, the pipeline never adopted it, and gave it to us as original_spec_nvr instead, and that's what Bodhi queries for.

If the pipeline now provides it as item, that would be great, and would mean we could use the same query to find both Taskotron and pipeline results (openQA results still require a separate query, as openQA tests by update, not by package). If the pipeline now provides it as something else, then I guess we should adjust the query to request that instead.

Having a quick look at recent messages, it seems to give us both original_spec_nvr and nvr, but still not item...so we could switch original_spec_nvr to nvr, I guess, but that's all :/

I believe the new message format resolves this question and we could thus close this ticket :)

Closing this per pingou, but if it needs to re-open, let me know!

Metadata Update from @jimbair:
- Issue status updated to: Closed (was: Open)

4 years ago

Login to comment on this ticket.

Metadata