#2 New attribute "result"
Merged by psss. Opened by psss.
result  into  master

Download 2.patch

As discussed on the Best Practices meeting, this pull request is proposing a new attribute to handle different ways how to interpret test results. I am not completely sure about the attribute name result. Does anyone have a suggestion for a better name?

@mvadkert, @plautrba, @jheger, @pcahyna, @vdolezal could you please review? Thanks.

rebased onto 2b2c6edf275f7b037d07cfedb9a4084f2de5e4e4

Added default value. @plautrba, thanks for the idea.

Hmm, I thought this is expected fail. Maybe we need a better name?

Hmm, I thought this is expected fail. Maybe we need a better name?

imho name is fine (although I would prefer 'expfail'), however the description is confusing.

'make sure the test fails' sound to me like this attribute somehow makes the test fail.

right! we need a better description like: expect test to fail here. I.e. Fail will be perceived as pass, pass as a failure.

Yes, xfail should be expected fail. Let's try to find a better description:

xfail: expected fail (pass when test failed, fail when test passed)

@mvadkert, @jheger, does that sound better now? Any wording suggestions?

sounds good

1 new commit added

  • Update description for expected fail

Metadata Update from @psss:
- Request assigned

OK, description updated.

Pull-Request has been merged by psss

Metadata Update from @psss:
- Pull-request tagged with: test metadata

Metadata