fedora-commops / fedora-happiness-packets

#149 Update contributing guidelines for upstream contributions and response time on issues/PRs
Closed: complete by jflory7. Opened by jflory7.

Closed: complete
Reopen Issue

Summary

Update contributing guidelines to encourage issues before PRs in upstream and how long to expect a response in issues / PRs

Background

Contributing guidelines created in #98. These are helpful for old and new contributors alike to understand how the project is managed and how to adapt to the workflow of the project. Since they were written, we identified two new things to revise / add:

  • Instead of sending PRs to upstream, first file a thought-out ticket to see if upstream wants to accept the change
  • Explicitly say how long we expect to get feedback in issue / PR comments (3-4 days tops?)

This ticket should be taken by a project mentor and is not a ticket for an applicant to work on (however, if you have feedback about the contributing guidelines, we'd love to hear it).

Details

  • Revise upstream contribution explanation in existing doc
  • Add new section about mentor response time (need to agree among mentors how long is maximum time for feedback)

Outcome

  • Better relationship with upstream project so we don't flood them with changes they may or may not want
  • More clear to new contributors / applicants about how long it takes for mentors to get feedback to them
phoenixabhishek commented

I was about to open up a discussion about no responses on out PRs made to upstream.
Opening issues instead of PRs seems more appropriate since for the PRs we actually have to make the changes too to the codebase, and then push the PR.
This approach will make sure that change efforts are put in only when it is an accepted change.
Thanks @jflory7 :thumbsup: :thumbsup: :thumbsup: :thumbsup: :thumbsup:

Hello, can I work on this?

This approach will make sure that change efforts are put in only when it is an accepted change.

@phoenixabhishek Yes. Unfortunately our upstream project is not an active upstream, but it is still an alive project. To better respect both the upstream maintainer's and intern applicant's times, @jonatoni, @bt0dotninja, and I thought this is a better approach.

Hello, can I work on this?

Hi @eloisasmorais, this ticket needs more discussion by fedora-happiness-packets mentors first. A mentor will handle this ticket. If you are getting started, I recommend looking at #100 and #103 to begin. :smile:

chetanshinde911 commented

@jflory7 as this issue has got the pass ticket can i work on it. :)
phoenixabhishek commented

@chetanshinde911 as you can see in the comment by @jflory7 , this ticket is currently for the mentors to work on.

Hi @eloisasmorais, this ticket needs more discussion by fedora-happiness-packets mentors first. A mentor will handle this ticket. If you are getting started, I recommend looking at #100 and #103 to begin. 😄

You can have a look at other tickets in the mean time :smile: :smile: :smile: :smile: :smile:

Metadata Update from @jflory7:
- Issue assigned to jflory7

See PR #164.

Metadata Update from @jflory7:
- Issue close_status updated to: complete
- Issue status updated to: Closed (was: Open)
Metadata

PASSED improvement type - docs type - internal organization

None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.