fedora-commops / fedora-happiness-packets

#129 Remove Fedmsg as a dependency
Merged by jflory7. Opened by shraddhaag.
fedora-commops/ shraddhaag/fedora-happiness-packets remove-fedmsg-dependency  into  master

Download 129.patch

Q - What is a summary of your change?
A - This commit removes Fedmsg as a dependency for the project.

Q - Why is this change helpful?
A - Since Fedmsg is deprecated in favour of fedora-messaging, this commit removes the Fedmsg dependency for the project.
This solves ticket #66 and #69 and is the first step of many for #96. Since fedmsg is used only for assigning badges, it doesn't conflict with either of these issues and restores them back to full functionality. It's important to get this functionality in the codebase so others working on the project can work on things forward from here.

Note - The test suite was successfully passed.

@jflory7 Please find the time to review the PR. Thanks! :)

Metadata Update from @jflory7:
- Pull-request tagged with: improvement, type - backend, type - fedora-messaging, type - summer coding
- Request assigned

Hi @shraddhaag, excellent sleuthing on #66 and #69. :mag:

This change is easy and simple so I'm happy to merge it. Before merging, I want to test before/after on #66 and #69 to confirm your fix. I might not have a chance to do this until Tuesday or Wednesday, but I'll get it done soon.

Thanks for the PR! :thumbsup:

Metadata Update from @jflory7:
- Pull-request tagged with: needs testing

rebased onto bb7c9f28536309ab8bb23b627ce3e43bec7616d2

Metadata Update from @jflory7:
- Pull-request untagged with: needs testing

@shraddhaag I tested and confirmed your fix for #66. :tada: I will follow up with a reply in #69 in a little bit.

Thanks for this PR! Merging. :clapper:

Pull-Request has been merged by jflory7
Metadata
jflory7

improvement type - backend type - fedora-messaging type - summer coding

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.