#154 Fixes#146Active class is set to an element in sidebar for all pages.
Merged by jflory7. Opened by chetanshinde911.
fedora-commops/ chetanshinde911/fedora-happiness-packets fixes146  into  master

Download 154.patch

This is the change required in base.html This change assumes an class called active will be written by Phoenixabhikesh which will have the styling required to make the table appear been selected. the logic written here sets the class of the list element to active which is been selected.

This change will help in UI, which will appear more responsive.

Changes are performed on in base.html

rebased onto 8ebbcf6d26a98b34eb37320c8175d4d4f1fb7ac3

Metadata Update from @jflory7:
- Pull-request tagged with: improvement, needs info, type - frontend, type - summer coding
- Request assigned

@chetanshinde911 Hi, I'm not sure I understand your changes. As I understand, to fix #146, an underline or other indicator should appear in the sidebar for the page I am currently on. Is that correct? I tested the changes locally but I couldn't tell what changed in the front-end.

phoenixabhishek commented

@jflory7 Actually, I already have the code for the front end design for this.
But was unable to get around the django part of it where the URL is set.
This PR addresses the change in logic.

Once merged, I will open another PR with the corresponding design change.

For testing, what you can do is, run this locally, then navigate to the 'FAQ' page.
Now in the inspector, if you see only one active class in the sidebar, then the fix is made.
Currently, two active classes are present when navigated to other pages. see here

@chetanshinde911 will you be able to upload a screenshot with inspect element console while on the FAQ page.
This might help to see the results.

chetanshinde911 commented

FAQ_under_selection.png

When the FAQ is list element is selected it's class is been set as active.. and then the css code written under active class will take effect.

When the any other tab is selected the class of FAQ list element is not been set.

FAQ_is_not_under_selection.png

phoenixabhishek commented

@jflory7 How do you check the changes locally for PRs that are not merged.
Do you make the changes in your local files and see the result..???

I would like to help you out in this to check if the fix does what it's intended to do. :smile: :smile: :smile: :smile: :smile:

Okay, now I understand. I was confused because this looked like part of the work. I see now that both of you @chetanshinde911 @phoenixabhishek were pairing on this. Nice! :thumbsup:

In that case, this change makes sense, although I would like to see a PR so some sort of indication is shown to the user about what page they are currently on.

Merging! :checkered_flag:

@jflory7 How do you check the changes locally for PRs that are not merged.
Do you make the changes in your local files and see the result..???

I fetch the branch of a PR and test with the same commits from a PR. :grinning:

rebased onto 9bfd3ad6d163fb6f19b2b659456da637c5a24328

Metadata Update from @jflory7:
- Pull-request untagged with: needs info

Pull-Request has been merged by jflory7

chetanshinde911 commented

hey, @jflory7 thanks for the merge. @phoenixabhishek thanks, got my first merge done and learned great teamwork as well :)

phoenixabhishek commented

@chetanshinde911 Congratulations on your first merge :confetti_ball: :confetti_ball: :confetti_ball: :confetti_ball: :confetti_ball:

phoenixabhishek commented

In that case, this change makes sense, although I would like to see a PR so some sort of indication is shown to the user about what page they are currently on.

@jflory7 yes, that will be the next PR from me :smile: :smile: :smile: :smile: :smile: