fedora-docs / fedora-docs-ci

#2 Proposed changes
Merged by richardgreg. Opened by pingou.
fedora-docs/ pingou/fedora-docs-ci changes  into  master

Download 2.patch
no initial comment

I've tried to make the commit messages meaningful.

Of course all the changes proposed here are up for debate and can be discussed, accepted or rejected, they are just proposed changes.

2 new commits added

  • Add configuration for logging in fedoradocs_ci
  • Fix typo when requesting the list of projects of interest

rebased onto 983ddd86db6be6743a5fd6140db1c805cb9b151d

15 new commits added

  • Add configuration for logging in fedoradocs_ci
  • Fix typo when requesting the list of projects of interest
  • Make the queue durable
  • Adjust the name of the consumer function to what is in the config.toml
  • Rename a couple of method to reflect better what they actually do
  • Fix typos
  • Small changes to the config.toml
  • Add an __init__.py file to fedoradocs_ci and include a version in it
  • Rename the folder from build-scripts to fedoradocs_ci
  • Move the cron job used to clean up the old builds of the doc
  • Move the example config.toml file outside of the sources
  • Adjust the environment variable used to specify the API token for pagure
  • Drop a few dependencies from the dependency list as they are not used
  • Rework the consumer a little bit, drop the sites.py file
  • Few changes to the build

1 new commit added

  • Fix accessing the data in the JSON blob coming from the message on the bus

1 new commit added

  • Add time when logging to the console so we have an idea of speed

1 new commit added

  • Rename post_unsuccessful_build_comment to announce_unsuccessful_build

1 new commit added

  • TemporaryDirectory returns a string, no need to call .name on them

1 new commit added

  • Replace tabs with spaces in the delete_builds script

Alright, I have a few more changes I'd like to propose but it will make this PR bigger and I think it's big enough.

Review welcome :)
siddharthvipul1 commented

Looks really good so far, +1 to merge
@richardgreg what do you think?
Once this is in, I would like to collaborate with Richard on deployment side

I know it should work fine because, Pingou :)

When I try to run consumer.py I get ModuleNotFoundError: No module named 'fedoradocs_ci'. Removing the package name from the import statement works but I'm not sure if it's a good practice.

Also one of the functions in consumer.py is named 'consume' which conflicts with fedora_messaging's consume. Did you mean consumer? :D

When I try to run consumer.py I get ModuleNotFoundError: No module named 'fedoradocs_ci'. Removing the package name from the import statement works but I'm not sure if it's a good practice.

Try running it as: PYTHONPATH=. fedora-messaging --conf config.toml consume :)

Also one of the functions in consumer.py is named 'consume' which conflicts with fedora_messaging's consume. Did you mean consumer? :D

That import is not used, it'll be removed and it's part of the next PR I've
prepared but didn't want to pile onto this one :)

Okay. Looks good. +1 to merge

Pull-Request has been merged by richardgreg

Go ahead, you have the rights to do so ;-)
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.