#43 Fix for xrefs location
Merged by pbokoc. Opened by didiksupriadi41.
fedora-docs/ didiksupriadi41/install-guide master  into  master

Download 43.patch

79455de
A fix for *.adoc files that have internal xref errors.

e174aea
I also notice this xref is not referenced to the intended resource, and fixed it.

didiksupriadi41 commented

Do I have to report the issues first?

rebased onto 62312fd0233e43efccf6ac30d6caa6308f26fefa

This should just be xref:sect-troubleshooting-log-files[Log Files Generated During the Installation], without the install/ part. Like the filename, it's only used when linking to another source file, if it's in another directory (called "topic" by Antora).

Hi, thank you for the PR. Everything looks good except for the one problem I found (see above); otherwise I'm ready to merge this once you fix that too.

Regarding your question about reporting issues first: that's not necessary, people commonly just send us PRs for things they find, without opening issues.

1 new commit added

  • Merge branch 'master' of ssh://pagure.io/forks/didiksupriadi41/fedora-docs/install-guide

1 new commit added

  • Fix another xref location

3 new commits added

  • Merge branch 'master' of ssh://pagure.io/forks/didiksupriadi41/fedora-docs/install-guide
  • Fix link to the intended reference
  • Fix internal xrefs

1 new commit added

  • fix another xrefs in Troubleshooting.adoc
didiksupriadi41 commented

Okay, I just pushed another commit to fix the problem.
Is this sufficient?

rebased onto 2d1c944ba01711d31979d9324d8bd431ef8597fc

Looks good, thank you!

Pull-Request has been merged by pbokoc

Metadata