#3 Include Microsoft Teams
Merged by otaylor. Opened by otaylor.
otaylor/fedora-flathub-filter com-microsoft-Teams  into  main

Download 3.patch

This is currently the #11 app on Flathub. It appears well maintained, and there
are no bad issues on https://github.com/flathub/com.microsoft.Teams.

There are a few components built from source such as ImageMagick, but the
application itself is downloaded from Microsoft as extra-data.

2 new commits added

  • Include Microsoft Teams
  • Update to latest Flathub data

:thumbsup:

@otaylor Can you split out the Flathub data update into a separate PR so I can merge it?

@otaylor Can you split out the Flathub data update into a separate PR so I can merge it?

The thing is, that pretty much every pull request is going to involve updating the Flathub data. [*] To keep us from having to have a infinite series of "Update the Flathub data" pull requests, my intention was that we accept that a pull request will have the "unrelated" update as its first commit.

This has a couple of consequences:

  1. A maintainer needs to review pull requests commit-by-commit rather than by the total request
  2. Almost all pull requests will need to be rebased on merge - and the merge can't be an automatic Pagure merge.

Following my over-engineering approach to this repository, I added an option "./update.py --merge=PR" to allow a maintainer to easily do the rebase-and-merge. I tried using that on #2, but forgot to enable the Pagure hook to mark merge requests closed by magic word scanning.

Let me see if it works here now.

[*] We could reduce that bit by making the stats we use "last calendar month - Mar 1-Mar 31 rather than "last 30 days - Mar 7 - April 6", but there would still be updates from things changing on Flathub.

Commit 3484be61 fixes this pull-request

Pull-Request has been merged by otaylor

Metadata