#114 PEP8 Compatible Code
Closed: Fixed Opened by skamath.

Right now, the python code in here does not adhere to the PEP8 guidelines. It'd be really nice if a code clean-up is done and made PEP-8 compatible.

PEP8 Docs here.


If you think this should be done, I can work on it :)

+1 here. I'm a fan of PEP8, however this is worth watching for some context: https://www.youtube.com/watch?v=wf-BqAjZb8M

@skamath Do you have any update on this ticket?

@sayanchowdhury I'm a little reluctant to make a PR for PEP-8 fixes alone. If I get a green light from you guys, I can definitely go ahead and send a PR for this. This can definitely help me get started with Hubs as I'll be going through the whole code. Thoughts?

(Oops, sorry for double posting)

I came to this issue yesterday becoz this one came in the "triage" during the meeting and then i saw ralph's suggested video. After reviewing this pr on pagure, i have been scared of PRs that go throughout the code because even the best ones can let the gorilla pass a few times in such cases (video reference). Although, this is an easy fix and fixing one point shouldn't need a change at some other point in some other file, this still will be a big pr and will go throughout the code. Will it be better that rather than making one big pr, we can do PEP-8 fixes for the method/class/file we are touching for other bugs (in a different commit) ? I understand this will be time taking and will need effort from everyone contributing. It's just a thought.

Nope. I would not suggested the whole one big PR.

I would rather suggested multiple smaller PRs (widget level), maybe 1 or 2 widgets at a time. Continuously merging those PRs and updating it here in this ticket.

That sounds a lot better. :)

widgets done: contact, about, pagureissues, clean_input, bugzilla, library.

We now run the flake8 tests in the test suite to check the pep8 compliance of the code.

It all passes except for a recent addition E722 in two places. I have filed PR#420 to fix these. Pretty sure we can close this one out now.

Metadata Update from @abompard:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Metadata