#221 Library widget and module to clean user input text
Merged by pingou. Opened by pingou.
pingou/fedora-hubs library_widget  into  develop

Download 221.patch
no initial comment

is library widget supposed to be relative to the hubs domain or can it be any url?

The widget crashes when given unicode characters.

File "<snip>/library.py", line 21, in data
  if u.strip()
UnicodeEncodeError 'ascii' codec can't encode character u'\u200b'

Otherwise LGTM after rebase. The clean_input will be helpful for SavedNotifications

We may need to mention to the user that they need to append http:// to the links because what I was refering in my earlier comment is that when you type google.com it will redirect you to localhost:5000/skrzepto/google.com.

is library widget supposed to be relative to the hubs domain or can it be any url?

It can be any url

We may need to mention to the user that they need to append http://

Sure thing, just not quite sure how we could right now.

The widget crashes when given unicode characters

Which input did you test it with?

Sure thing, just not quite sure how we could right now.

We could put something in the help text along the lines of 'External links must include the whole link (that includes http://)'

Which input did you test it with?

I tested with a couple of different characters: £ © á etc

rebased

Thanks :)

Pull-Request has been merged by pingou

Metadata