#529 Address private fields in FAS
Merged by abompard. Opened by shaily.
shaily/fedora-hubs develop  into  develop

Download 529.patch

Thanks for the PR! So did you find any case where that information was missing in FAS?

I would recommend using fas_user.get("country_code") to avoid a KeyError if the key is absent.

I would recommend using .get() here too.

I couldn't test it in action because the FAS client was using my credentials to retrieve the details. This made my privacy setting irrelevant because the FAS server uses another mode of retrieval called self over privacy, which includes all fields.

However, I was getting KeyErrors on the country field for some sync_user calls, which stopped after this, proving that private fields were indeed not returned by FAS.

I've checked against the FAS server's source, so this information should be accurate.

1 new commit added

  • FAS private fields: Changes from review

rebased onto 2a355496312a6dc3a7ec73fff0fb84429a8a7796

Pull-Request has been merged by abompard

Metadata