#66 Adds a github issues widget
Closed by ralph. Opened by dhrish20.
dhrish20/fedora-hubs issue35  into  develop

Download 66.patch
no initial comment

@ralph Please review this PR.

This is the latest screenshot:
https://cdn.pbrd.co/images/2v3SHJi7.png

Looks good. Thanks @dhrish20!

Doh, actually, there is a merge conflict.

Can you rebase against the develop branch and see if that resolves it?

@ralph
1) There is a problem with the code.
In line number 64 of init.py file, The for loop has been set to 10 iterations only. Ideally, it should traverse all the open issues, right?

I am facing some trouble in getting the total number of issues

2) I tried rebasing using the following commands:
* git checkout develop
* git pull origin develop
* git checkout issue35
* git rebase develop

But the result is "Current branch issue35 is up to date.
"

Hm. Try pushing again? Perhaps the rebase just worked?

For the number of iterations... perhaps we can make that configurable by adding another @argument?

@ralph I have added "display_number" argument. Could you please check if its alright and whether it needs any more changes?

Hm. Does it work? I'd be surprised. It looks like it is still missing a new @argument decorator for the new argument.

Did you have any luck pulling all the PRs with the Link header like was talked about in #fedora-apps?

@ralph. It works perfectly without the @argument decorator.

@ralph do we really need to pull all the PR/issues? These widgets are used to display LATEST 3 or 4 or 10 PR/issues. If anyone wants to see ALL PR/issues we have provided a link to view all the PR/issues. Should we limit the maximum number of PR/issues (items) to be displayed on widget?

Heh, so, without the @argument decorator.. nobody will be able to change the value of display_number on their page.

But, once they can do that, then we'll need to be grabbing all of the issues.. or, at least we'll only have to grab the first display_number of them.

OK, this has been merged. Will continue to work on it.

Metadata