#2461 Use first uppercase letter for all handlers
Merged a month ago by kevin. Opened a month ago by zlopez.
fedora-infra/ zlopez/ansible handlers  into  main

file modified
+63 -63
@@ -2,207 +2,207 @@ 

  # Handlers for restarting services

  #

  ---

- - name: reload systemd

+ - name: Reload systemd

    ansible.builtin.command: systemctl daemon-reload

  

- - name: restart apache

+ - name: Restart apache

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh httpd httpd

  

- - name: reload apache

+ - name: Reload apache

    action: service name=httpd state=reloaded

  

- - name: restart collectd

+ - name: Restart collectd

    action: service name=collectd state=restarted

  

- - name: restart crond

+ - name: Restart crond

    action: service name=crond state=restarted

  

- - name: restart fedmsg-gateway

+ - name: Restart fedmsg-gateway

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fedmsg-gateway

  

- - name: restart fedmsg-hub

+ - name: Restart fedmsg-hub

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh {{ item }}

    with_items:

    - fedmsg-hub

    - fedmsg-hub-3

  

- - name: restart fedmsg-hub-3

+ - name: Restart fedmsg-hub-3

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh {{ item }}

    with_items:

    - fedmsg-hub

    - fedmsg-hub-3

  

- - name: restart fedmsg-irc

+ - name: Restart fedmsg-irc

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fedmsg-irc

  

- - name: restart fedmsg-relay

+ - name: Restart fedmsg-relay

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fedmsg-relay

  

- - name: restart fm-consumer@koji_sync_listener

+ - name: Restart fm-consumer@koji_sync_listener

    action: service name=fm-consumer@koji_sync_listener state=restarted enabled=yes

  

- - name: reload httpd

+ - name: Reload httpd

    ansible.builtin.command: /usr/local/bin/conditional-reload.sh httpd httpd

  

- - name: restart iptables

+ - name: Restart iptables

    action: service name=iptables state=restarted

  

- - name: restart ip6tables

+ - name: Restart ip6tables

    action: service name=ip6tables state=restarted

  

- - name: restart libvirtd

+ - name: Restart libvirtd

    action: service name=libvirtd state=restarted

  

- - name: restart virtnetworkd

+ - name: Restart virtnetworkd

    action: service name=virtnetworkd state=restarted

  

- - name: restart libvirtd.socket

+ - name: Restart libvirtd.socket

    action: service name=libvirtd.socket state=stopped

-   notify: restart libvirtd

+   notify: Restart libvirtd

  

- - name: restart mailman

+ - name: Restart mailman

    action: service name=mailman state=restarted

  

- - name: restart named

+ - name: Restart named

    action: service name=named state=restarted

  

- - name: restart ntpd

+ - name: Restart ntpd

    action: service name=ntpd state=restarted

  

- - name: restart sshd

+ - name: Restart sshd

    action: service name=sshd state=restarted

  

- - name: restart openvpn (Fedora)

+ - name: Restart openvpn (Fedora)

    when: ansible_distribution == "Fedora"

    action: service name=openvpn-client@openvpn state=restarted

    # notify:

-   # - fix openvpn routing

+   # - Fix openvpn routing

  

- - name: restart openvpn (RHEL7+)

+ - name: Restart openvpn (RHEL7+)

    when: ansible_distribution == "RedHat" and ansible_distribution_major_version|int >= 7

    action: service name=openvpn-client@openvpn state=restarted

    # notify:

-   # - fix openvpn routing

+   # - Fix openvpn routing

  

- - name: fix openvpn routing

+ - name: Fix openvpn routing

    action: shell /etc/openvpn/fix-routes.sh

  

- - name: restart xinetd

+ - name: Restart xinetd

    action: service name=xinetd state=restarted

    when: not inventory_hostname.startswith('proxy')

  

- - name: restart netapproute

+ - name: Restart netapproute

    action: command /etc/sysconfig/network-scripts/ifup-routes eth1

  

- - name: restart network

+ - name: Restart network

    action: service name=network state=restarted

  

- - name: rebuild postfix transport

+ - name: Rebuild postfix transport

    ansible.builtin.command: /usr/sbin/postmap /etc/postfix/transport

  

- - name: rebuild postfix bysender

+ - name: Rebuild postfix bysender

    ansible.builtin.command: /usr/sbin/postmap /etc/postfix/bysender

  

- - name: rebuild postfix tls_policy

+ - name: Rebuild postfix tls_policy

    ansible.builtin.command: /usr/sbin/postmap /etc/postfix/tls_policy

  

- - name: restart postfix

+ - name: Restart postfix

    service: name=postfix state=restarted

  

- - name: reload proxyhttpd

+ - name: Reload proxyhttpd

    ansible.builtin.command: /usr/local/bin/proxy-conditional-reload.sh httpd httpd

  

- - name: run rkhunter

+ - name: Run rkhunter

    ansible.builtin.command: rkhunter --propupd

  

- - name: restart moksha-hub

+ - name: Restart moksha-hub

    service: name=moksha-hub state=restarted

  

- - name: restart dhcpd

+ - name: Restart dhcpd

    service: name=dhcpd state=restarted

  

- - name: restart memcached

+ - name: Restart memcached

    service: name=memcached state=restarted

  

- - name: restart nagios

+ - name: Restart nagios

    ansible.builtin.shell: nagios -v /etc/nagios/nagios.cfg && systemctl restart nagios

  

- - name: restart bridge

+ - name: Restart bridge

    ansible.builtin.shell: /usr/lib/systemd/systemd-sysctl --prefix=/proc/sys/net/bridge

  

- - name: reload libvirtd

+ - name: Reload libvirtd

    service: name=libvirtd state=reloaded

    ignore_errors: true

    when: ansible_virtualization_role == 'host'

  

- - name: restart pagure_ev

+ - name: Restart pagure_ev

    service: name=pagure_ev state=restarted

  

- - name: "update ca-trust"

+ - name: Update ca-trust

    ansible.builtin.command: /usr/bin/update-ca-trust

  

- - name: restart stunnel

+ - name: Restart stunnel

    service: name=stunnel state=restarted

  

- - name: restart mirrorlist-server

+ - name: Restart mirrorlist-server

    service: name=mirrorlist-server state=restarted

  

- - name: restart NetworkManager

+ - name: Restart NetworkManager

    service: name=NetworkManager state=restarted

  

- - name: reload NetworkManager-connections

+ - name: Reload NetworkManager-connections

    ansible.builtin.command: nmcli c reload

  

- - name: restart basset-worker

+ - name: Restart basset-worker

    service: name=basset-worker state=restarted

  

- - name: apply interface-changes

+ - name: Apply interface-changes

    ansible.builtin.command: nmcli con up {{ item.split()[1] }}

    async: 1

    poll: 0

    loop: "{{ if_uuid.stdout_lines|flatten(levels=1) }}"

    when: item.split()[1] not in ansible_ifcfg_disabled

  

- - name: flush journald tmpfiles to persistent store

+ - name: Flush journald tmpfiles to persistent store

    ansible.builtin.command: pkill -f -USR1 systemd-journald

  

- - name: restart idmapd

+ - name: Restart idmapd

    service: name=nfs-idmapd state=restarted

  

- - name: restart buildmaster

+ - name: Restart buildmaster

    service: name=buildmaster state=restarted

  

- - name: restart rabbitmq

+ - name: Restart rabbitmq

    systemd:

      name: rabbitmq-server

      state: restarted

      daemon_reload: yes

  

- - name: restart chronyd

+ - name: Restart chronyd

    service: name=chronyd state=restarted

  

- - name: restart kojira

+ - name: Restart kojira

    systemd:

      name: kojira

      state: restarted

  

- - name: restart haveged

+ - name: Restart haveged

    service: name=haveged state=restarted

  

- - name: restart obs-signd

+ - name: Restart obs-signd

    service: name=signd state=restarted

  

- - name: restart swap.swap

+ - name: Restart swap.swap

    service: name="swap.swap" state=restarted

  

- - name: restart varnish

+ - name: Restart varnish

    service: name=varnish state=restarted

  

- - name: reload varnish

+ - name: Reload varnish

    service: name=varnish state=reload

  

- - name: restart systemd-oomd

+ - name: Restart systemd-oomd

    service: name=systemd-oomd state=reload

  

- - name: restart debuginfod

+ - name: Restart debuginfod

    service: name=debuginfod state=restarted

@@ -55,7 +55,7 @@ 

      ansible.builtin.copy: src="{{ files }}/debuginfod/sysconfig.debuginfod" dest=/etc/sysconfig/debuginfod owner=root group=root mode=644

      tags: debuginfod

      notify:

-       - restart debuginfod

+       - Restart debuginfod

  

    - name: Ensure systemd drop-in directory exists

      ansible.builtin.file: >
@@ -67,7 +67,7 @@ 

      tags: debuginfod

      ansible.builtin.copy: src="{{ files }}/debuginfod/debuginfod.service.d" dest=/etc/systemd/system/debuginfod.service.d/override.conf owner=root group=root mode=644

      notify:

-       - restart debuginfod

+       - Restart debuginfod

  

    - name: Ensure debuginfod is enabled and started

      service:

file modified
+1 -1
@@ -50,7 +50,7 @@ 

      service: HTTP

      host: "id{{env_suffix}}.fedoraproject.org"

      notify:

-     - combine IPA http keytabs

+     - Combine IPA http keytabs

  

    handlers:

    - import_tasks: "{{ handlers_path }}/restart_services.yml"

file modified
+1 -1
@@ -140,7 +140,7 @@ 

      ansible.builtin.copy: src=/root/ticketkey_{{env}}.tkey dest=/etc/httpd/ticketkey_{{env}}.tkey

            owner=root group=root mode=0600

      notify:

-     - reload proxyhttpd

+     - Reload proxyhttpd

  

    #

    # If this is an initial deployment, make sure docs are synced over.

@@ -19,7 +19,7 @@ 

          dest=/etc/httpd/conf.d/apps.fedoraproject.org/fedora-releng-dash.conf

          state=absent

        tags: releng-dash

-       notify: reload proxyhttpd

+       notify: Reload proxyhttpd

  

    roles:

  

@@ -23,7 +23,7 @@ 

      - meetbot.fedoraproject.org/reversepassproxy.conf

      - meetbot.fedoraproject.org/meetbot.conf

      notify:

-     - reload proxyhttpd

+     - Reload proxyhttpd

      tags:

      - httpd

      - httpd/reverseproxy

@@ -22,7 +22,7 @@ 

        - python3-copr-common

        update_cache: true

      notify:

-     - restart haveged

+     - Restart haveged

  

    handlers:

    - import_tasks: "{{ handlers_path }}/restart_services.yml"

@@ -21,7 +21,7 @@ 

        - python3-copr-common

        update_cache: true

      notify:

-     - restart haveged

+     - Restart haveged

  

    handlers:

    - import_tasks: "{{ handlers_path }}/restart_services.yml"

@@ -36,4 +36,4 @@ 

      ansible.builtin.copy: src=/root/ticketkey_{{env}}.tkey dest=/etc/httpd/ticketkey_{{env}}.tkey

            owner=root group=root mode=0600

      notify:

-     - reload proxyhttpd

+     - Reload proxyhttpd

@@ -1,7 +1,7 @@ 

  ---

- - name: restart httpd

+ - name: Restart httpd

    service: name=httpd state=restarted

  

- - name: restart postgresql

+ - name: Restart postgresql

    service: name=postgresql

             state=restarted

@@ -1,10 +1,10 @@ 

  ---

- - name: restart httpd

+ - name: Restart httpd

    service:

      name: httpd

      state: restarted

  

- - name: restart postgresql

+ - name: Restart postgresql

    service:

      name: postgresql

      state: restarted

@@ -52,53 +52,53 @@ 

      dest: /usr/lib/python3.6/site-packages/abrt-server-info-page/config.py

      regexp: 'ADMINS ='

      line: '    ADMINS = "infrastructure@lists.fedoraproject.org"'

-   notify: restart httpd

+   notify: Restart httpd

  

  - name: Configure MORE_FAF

    lineinfile:

      dest: /usr/lib/python3.6/site-packages/abrt-server-info-page/config.py

      regexp: 'MORE_FAF ='

      line: '    MORE_FAF = "https://github.com/abrt/faf/"'

-   notify: restart httpd

+   notify: Restart httpd

  

  - name: Configure MORE_RS

    lineinfile:

      dest: /usr/lib/python3.6/site-packages/abrt-server-info-page/config.py

      regexp: 'MORE_RS ='

      line: '    MORE_RS = "https://github.com/abrt/retrace-server"'

-   notify: restart httpd

+   notify: Restart httpd

  

  - name: Configure MORE_ABRT

    lineinfile:

      dest: /usr/lib/python3.6/site-packages/abrt-server-info-page/config.py

      regexp: 'MORE_ABRT ='

      line: '    MORE_ABRT = "https://github.com/abrt/abrt/"'

-   notify: restart httpd

+   notify: Restart httpd

  

  - name: Configure MORE_GABRT

    lineinfile:

      dest: /usr/lib/python3.6/site-packages/abrt-server-info-page/config.py

      regexp: 'MORE_GABRT ='

      line: '    MORE_GABRT = "https://github.com/abrt/gnome-abrt/"'

-   notify: restart httpd

+   notify: Restart httpd

  

  - name: Configure MORE_LR

    lineinfile:

      dest: /usr/lib/python3.6/site-packages/abrt-server-info-page/config.py

      regexp: 'MORE_LR ='

      line: '    MORE_LR = "https://github.com/abrt/libreport/"'

-   notify: restart httpd

+   notify: Restart httpd

  

  - name: Configure MORE_SATYR

    lineinfile:

      dest: /usr/lib/python3.6/site-packages/abrt-server-info-page/config.py

      regexp: 'MORE_SATYR ='

      line: '    MORE_SATYR = "https://github.com/abrt/satyr/"'

-   notify: restart httpd

+   notify: Restart httpd

  

  - name: Configure URL_FOR_FAF

    lineinfile:

      dest: /usr/lib/python3.6/site-packages/abrt-server-info-page/config.py

      regexp: 'URL_FOR_FAF ='

      line: '    URL_FOR_FAF = "https://{{ faf_server_name }}"'

-   notify: restart httpd

+   notify: Restart httpd

@@ -9,56 +9,56 @@ 

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^max_connections ='

      line: 'max_connections = 150'

-   notify: restart postgresql

+   notify: Restart postgresql

  

  - name: Set shared_buffers for PostgreSQL

    lineinfile:

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^shared_buffers ='

      line: 'shared_buffers = 25536MB'

-   notify: restart postgresql

+   notify: Restart postgresql

  

  - name: Set effective_cache_size for PostgreSQL

    lineinfile:

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^effective_cache_size ='

      line: 'effective_cache_size = 50608MB'

-   notify: restart postgresql

+   notify: Restart postgresql

  

  - name: Set work_mem for PostgreSQL

    lineinfile:

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^work_mem ='

      line: 'work_mem = 6MB'

-   notify: restart postgresql

+   notify: Restart postgresql

  

  - name: Set maintenance_work_mem for PostgreSQL

    lineinfile:

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^maintenance_work_mem ='

      line: 'maintenance_work_mem = 2GB'

-   notify: restart postgresql

+   notify: Restart postgresql

  

  - name: Set checkpoint_completion_target for PostgreSQL

    lineinfile:

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^checkpoint_completion_target ='

      line: 'checkpoint_completion_target = 0.9'

-   notify: restart postgresql

+   notify: Restart postgresql

  

  - name: Set wal_buffers for PostgreSQL

    lineinfile:

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^wal_buffers ='

      line: 'wal_buffers = -1'

-   notify: restart postgresql

+   notify: Restart postgresql

  

  - name: Set default_statistics_target for PostgreSQL

    lineinfile:

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^default_statistics_target ='

      line: 'default_statistics_target = 100'

-   notify: restart postgresql

+   notify: Restart postgresql

  

  - name: Drop faf database

    postgresql_db:

@@ -1,5 +1,5 @@ 

  ---

- - name: restart httpd

+ - name: Restart httpd

    service:

      name: httpd

      state: restarted

file modified
+2 -2
@@ -29,11 +29,11 @@ 

      src: etc-faf-plugins-web.conf.j2

      dest: /etc/faf/plugins/web.conf

    notify:

-   - restart httpd

+   - Restart httpd

  

  - name: Put webfaf on root (/) if configured

    ansible.builtin.template:

      src: etc-httpd-conf.d-faf-web.conf.j2

      dest: /etc/httpd/conf.d/faf-web.conf

    notify:

-   - restart httpd

+   - Restart httpd

@@ -1,5 +1,5 @@ 

  ---

- - name: restart httpd

+ - name: Restart httpd

    service:

      name: httpd

      state: restarted

@@ -4,18 +4,18 @@ 

      src: etc-retrace-server.conf.j2

      dest: /etc/retrace-server/retrace-server.conf

      mode: "0644"

-   notify: restart httpd

+   notify: Restart httpd

  

  - name: Retrace-server http config

    ansible.builtin.template:

      src: retrace-server-httpd.conf.j2

      dest: /etc/httpd/conf.d/retrace-server-httpd.conf

      mode: "0644"

-   notify: restart httpd

+   notify: Restart httpd

  

  - name: Configure retrace-server hooks config

    ansible.builtin.template:

      src: etc-retrace-server-hooks.conf.j2

      dest: /etc/retrace-server/retrace-server-hooks.conf

      mode: "0644"

-   notify: restart httpd

+   notify: Restart httpd

file modified
+6 -6
@@ -25,7 +25,7 @@ 

    service: name=httpd enabled=yes

    ignore_errors: true

    notify:

-   - reload apache

+   - Reload apache

    tags:

    - service

    - apache
@@ -36,7 +36,7 @@ 

          owner=root group=root mode=0755

    when: ansible_distribution_major_version|int < 30 and ansible_distribution == 'Fedora'

    notify:

-   - reload apache

+   - Reload apache

    tags:

    - config

    - hotfix
@@ -48,7 +48,7 @@ 

          owner=root group=root mode=0755

    when: ansible_distribution_major_version|int <= 8 and ansible_distribution == 'RedHat'

    notify:

-   - reload apache

+   - Reload apache

    tags:

    - config

    - hotfix
@@ -57,7 +57,7 @@ 

  - name: Add appserver headers.conf

    ansible.builtin.template: src="{{ files }}/httpd/headers.conf.j2" dest=/etc/httpd/conf.d/headers.conf

    notify:

-   - reload apache

+   - Reload apache

    tags:

    - config

    - apache
@@ -67,7 +67,7 @@ 

    ansible.builtin.template: src="{{ files }}/httpd/h2.conf.j2" dest=/etc/httpd/conf.d/h2.conf

    when: ansible_distribution == 'Fedora'

    notify:

-   - reload apache

+   - Reload apache

    tags:

    - config

    - apache
@@ -76,7 +76,7 @@ 

  - name: Add apache_status location for collectd

    ansible.builtin.template: src="{{ files }}/httpd/apachestatus.conf" dest=/etc/httpd/conf.d/apachestatus.conf

    notify:

-   - reload apache

+   - Reload apache

    tags:

    - config

    - apache

@@ -9,7 +9,7 @@ 

      src=apps.fp.o.conf dest=/etc/httpd/conf.d/{{website}}/apps.fp.o.conf

      owner=root group=root mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - apps-fp-o

  

file modified
+2 -2
@@ -246,7 +246,7 @@ 

    - config

    - base

    notify:

-   - flush journald tmpfiles to persistent store

+   - Flush journald tmpfiles to persistent store

  

  - name: Enable journald persistence

    ansible.builtin.file: path=/var/log/journal state=directory
@@ -257,7 +257,7 @@ 

    - config

    - base

    notify:

-   - flush journald tmpfiles to persistent store

+   - Flush journald tmpfiles to persistent store

  

  - name: Install rh ca for splunk

    ansible.builtin.copy: src={{ private }}/files/splunk-certs/2022-IT-Root-CA.pem

file modified
+11 -11
@@ -10,7 +10,7 @@ 

      - "postfix/main.cf/main.cf.{{ datacenter }}"

      - "postfix/main.cf/main.cf"

    notify:

-   - restart postfix

+   - Restart postfix

    tags:

    - postfix

    - config
@@ -26,7 +26,7 @@ 

      - "postfix/master.cf/master.cf"

    when: inventory_hostname.startswith(('smtp-mm', 'mailman', 'noc02', 'bastion', 'smtp-auth'))

    notify:

-   - restart postfix

+   - Restart postfix

    tags:

    - postfix

    - config
@@ -36,7 +36,7 @@ 

    ansible.builtin.copy: src="{{private}}/files/smtpd/sender_access.{{postfix_group}}" dest="/etc/postfix/sender_access"

    when: postfix_group == "smtp-mm" or postfix_group == "mailman" or postfix_group == "gateway"

    notify:

-   - restart postfix

+   - Restart postfix

    tags:

    - postfix

    - config
@@ -49,7 +49,7 @@ 

      option: PrivateDevices

      value: false

    notify:

-   - reload systemd

+   - Reload systemd

    when: inventory_hostname.startswith(('buildvm-s390x'))

    tags:

    - postfix
@@ -66,8 +66,8 @@ 

    ansible.builtin.copy: src="postfix/{{ postfix_transport_filename }}" dest=/etc/postfix/transport

    when: inventory_hostname.startswith(('smtp-mm','bastion','noc02')) and env != 'staging'

    notify:

-   - rebuild postfix transport

-   - restart postfix

+   - Rebuild postfix transport

+   - Restart postfix

    tags:

    - postfix

    - base
@@ -77,8 +77,8 @@ 

    ansible.builtin.copy: src="postfix/bysender" dest=/etc/postfix/bysender

    when: inventory_hostname.startswith(('bastion')) and env != 'staging'

    notify:

-   - rebuild postfix bysender

-   - restart postfix

+   - Rebuild postfix bysender

+   - Restart postfix

    tags:

    - postfix

    - base
@@ -88,8 +88,8 @@ 

    ansible.builtin.copy: src="postfix/tls_policy" dest=/etc/postfix/tls_policy

    when: inventory_hostname.startswith(('bastion','smtp-mm','pagure')) and env != 'staging'

    notify:

-   - rebuild postfix tls_policy

-   - restart postfix

+   - Rebuild postfix tls_policy

+   - Restart postfix

    tags:

    - postfix

  
@@ -105,6 +105,6 @@ 

      mode=0600

    when: inventory_hostname.startswith(('bastion','smtp-mm')) and env != 'staging'

    notify:

-   - restart postfix

+   - Restart postfix

    tags:

    - postfix

file modified
+2 -2
@@ -74,7 +74,7 @@ 

  - name: Sshd_config

    ansible.builtin.template: src=sshd_config dest=/etc/ssh/sshd_config mode=0600

    notify:

-   - restart sshd

+   - Restart sshd

    tags:

    - basessh

    - sshd_config
@@ -217,7 +217,7 @@ 

    with_items: "{{certs_to_sign}}"

    register: certcopy

    notify:

-   - restart sshd

+   - Restart sshd

    tags:

    - basessh

    - sshd_cert

file modified
+3 -3
@@ -342,7 +342,7 @@ 

  - name: Install web server config for batcave (mimetypes)

    ansible.builtin.copy: src=mime-types.conf dest=/etc/httpd/conf.d/mime-types.conf mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - batcave

    - config
@@ -351,7 +351,7 @@ 

  - name: Install web server config for batcave (access rules)

    ansible.builtin.copy: src=allows dest=/etc/httpd/conf.d/allows mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - batcave

    - config
@@ -360,7 +360,7 @@ 

  - name: Install web server config for batcave (main config)

    ansible.builtin.template: src=infrastructure.fedoraproject.org.conf.j2 dest=/etc/httpd/conf.d/infrastructure.fedoraproject.org.conf mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - batcave

    - config

@@ -14,7 +14,7 @@ 

  - name: Setup blockerbugs apache conf

    ansible.builtin.copy: src=blockerbugs.conf dest=/etc/httpd/conf.d/blockerbugs.conf mode=644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

    - httpd
@@ -41,7 +41,7 @@ 

  - name: Setup blockerbugs app settings file

    ansible.builtin.template: src=blockerbugs-settings.py.j2 dest=/etc/blockerbugs/settings.py mode=640

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

    - httpd
@@ -53,7 +53,7 @@ 

    - blockerbugs

    - apache

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

    - httpd

@@ -153,8 +153,8 @@ 

      dest: /etc/fedora-messaging/koji_sync_listener.toml

    when: env == "production"

    notify:

-   - reload systemd

-   - restart fm-consumer@koji_sync_listener

+   - Reload systemd

+   - Restart fm-consumer@koji_sync_listener

    tags:

    - bodhi

    - koji-sync
@@ -405,7 +405,7 @@ 

      group: root

      mode: "0644"

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - bodhi

    - config
@@ -418,7 +418,7 @@ 

      group: root

      mode: "0644"

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - bodhi

    - config

file modified
+1 -1
@@ -23,7 +23,7 @@ 

      group: root

      mode: "0644"

    notify:

-   - reload systemd

+   - Reload systemd

    - Restart btrfs-balance

  

  

@@ -15,7 +15,7 @@ 

       src=moksha-hub.service

       dest=/usr/lib/systemd/system/moksha-hub.service

    notify:

-   - restart moksha-hub

+   - Restart moksha-hub

    tags:

    - bugzilla2fedmsg

  
@@ -40,7 +40,7 @@ 

      group=fedmsg

      mode=0640

    notify:

-   - restart moksha-hub

+   - Restart moksha-hub

    tags:

    - bugzilla2fedmsg

  
@@ -53,7 +53,7 @@ 

    - msg-client-fedora-prod.crt

    - msg-client-fedora-prod.key

    notify:

-   - restart moksha-hub

+   - Restart moksha-hub

    tags:

    - bugzilla2fedmsg

  

@@ -3,4 +3,4 @@ 

  - name: Conditionally restart check-compose consumer service

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fm-consumer@check-compose

    listen:

-   - restart check-compose

+   - Restart check-compose

@@ -134,7 +134,7 @@ 

    ansible.builtin.command: "python3 -m pip install --no-deps /root/check-compose"

    when: "gitcc is changed or instcc.rc != 0"

    notify:

-   - restart check-compose

+   - Restart check-compose

  

  - name: Create /etc/pki/fedora-messaging

    ansible.builtin.file:
@@ -179,7 +179,7 @@ 

  - name: Configure fedora-messaging check-compose consumer

    ansible.builtin.template: src=check-compose.toml.j2 dest=/etc/fedora-messaging/check-compose.toml owner=root group=root mode=0640

    notify:

-   - restart check-compose

+   - Restart check-compose

    tags:

    - config

  

file modified
+1 -1
@@ -9,7 +9,7 @@ 

  - name: Install chrony.conf

    ansible.builtin.template: src=chrony.conf.j2 dest=/etc/chrony.conf

    notify:

-   - restart chronyd

+   - Restart chronyd

    tags:

    - chrony

    - config

@@ -42,7 +42,7 @@ 

    tags:

    - collectd

    notify:

-   - restart collectd

+   - Restart collectd

  

  # install collectd-network config

  - name: /etc/collectd.d/network.conf
@@ -50,7 +50,7 @@ 

    tags:

    - collectd

    notify:

-   - restart collectd

+   - Restart collectd

    when: not inventory_hostname.startswith('log')

  

  # install collectd-network config
@@ -59,7 +59,7 @@ 

    tags:

    - collectd

    notify:

-   - restart collectd

+   - Restart collectd

    when: inventory_hostname.startswith('log')

  

  # apache - localhost only - pretty much any apache server
@@ -68,7 +68,7 @@ 

    tags:

    - collectd

    notify:

-   - restart collectd

+   - Restart collectd

    when: collectd_apache and ansible_distribution_major_version|int <= 7 and ansible_distribution == 'RedHat'

  

  - name: Install collectd-apache (dnf)
@@ -76,7 +76,7 @@ 

    tags:

    - collectd

    notify:

-   - restart collectd

+   - Restart collectd

    when: collectd_apache and ansible_distribution_major_version|int > 7 and ansible_distribution == 'RedHat'

  

  - name: Install collectd-apache (dnf)
@@ -84,7 +84,7 @@ 

    tags:

    - collectd

    notify:

-   - restart collectd

+   - Restart collectd

    when: collectd_apache and ansible_distribution_major_version|int >= 29 and ansible_distribution == 'Fedora'

  

  - name: /etc/collectd/apache.conf
@@ -92,7 +92,7 @@ 

    tags:

    - collectd

    notify:

-   - restart collectd

+   - Restart collectd

    when: collectd_apache

  

  - name: Install libsemanage-python so we can set an sebool below
@@ -107,7 +107,7 @@ 

    - collectd

    ignore_errors: true

    notify:

-   - restart collectd

+   - Restart collectd

    when: ( collectd_apache is defined ) and ansible_selinux.status != "disabled"

  

  - name: Enable collectd nfs module
@@ -115,7 +115,7 @@ 

    tags:

    - collectd

    notify:

-   - restart collectd

+   - Restart collectd

  

  # Three tasks for handling our (two) custom selinux modules.

  - name: Ensure a directory exists for our custom selinux module

@@ -12,4 +12,4 @@ 

      dest=/etc/collectd.d/bind.conf

    tags:

    - collectd

-   notify: restart collectd

+   notify: Restart collectd

@@ -12,7 +12,7 @@ 

      mode=0755

    tags:

    - collectd

-   notify: restart collectd

+   notify: Restart collectd

  

  - name: Copy in /etc/collectd.d/fcomm-queue.conf

    ansible.builtin.copy: >
@@ -20,7 +20,7 @@ 

      dest=/etc/collectd.d/fcomm-queue-conf

    tags:

    - collectd

-   notify: restart collectd

+   notify: Restart collectd

  

  # Three tasks for handling our custom selinux module.

  - name: Ensure a directory exists for our custom selinux module

@@ -3,13 +3,13 @@ 

    ansible.builtin.copy: src=fedmsg-map.py dest=/usr/local/bin/fedmsg-map mode=0755

    tags:

    - collectd

-   notify: restart collectd

+   notify: Restart collectd

  

  - name: Copy in /etc/collectd.d/fedmsg-activation/conf

    ansible.builtin.copy: src=fedmsg-activation.conf dest=/etc/collectd.d/fedmsg-activation.conf

    tags:

    - collectd

-   notify: restart collectd

+   notify: Restart collectd

  

  - seboolean: name=collectd_tcp_network_connect persistent=yes state=yes

    tags:

@@ -8,7 +8,7 @@ 

    tags:

    - collectd

    - collectd/fedmsg

-   notify: restart collectd

+   notify: Restart collectd

  

  - name: Copy in /etc/collectd.d/fedmsg-service.conf

    ansible.builtin.template: >
@@ -17,4 +17,4 @@ 

    tags:

    - collectd

    - collectd/fedmsg

-   notify: restart collectd

+   notify: Restart collectd

@@ -6,7 +6,7 @@ 

    - collectd/memcached

    - collectd

    - memcached

-   notify: restart collectd

+   notify: Restart collectd

  

  - name: Lastly, set some selinux booleans

    seboolean: name=collectd_tcp_network_connect persistent=yes state=yes

@@ -7,7 +7,7 @@ 

      mode=0755

    tags:

    - collectd

-   notify: restart collectd

+   notify: Restart collectd

  

  - name: Copy in /etc/collectd.d/postgres.conf

    ansible.builtin.template: >
@@ -15,4 +15,4 @@ 

      dest=/etc/collectd.d/postgres.conf

    tags:

    - collectd

-   notify: restart collectd

+   notify: Restart collectd

@@ -25,7 +25,7 @@ 

    tags:

    - collectd

    - config

-   notify: restart collectd

+   notify: Restart collectd

  

  - name: Let collectd talk to the RabbitMQ management interface

    seboolean: name=collectd_tcp_network_connect state=yes persistent=yes

@@ -9,7 +9,7 @@ 

    - collectd-web

    - collectd-rabbitmq-data

    notify:

-   - restart collectd

+   - Restart collectd

    tags:

    - config

    - collectd/server
@@ -23,7 +23,7 @@ 

    - collectd-rabbitmq-data

    - collectd-ipa-data

    notify:

-   - restart collectd

+   - Restart collectd

    tags:

    - config

    - collectd/server
@@ -37,7 +37,7 @@ 

    loop:

    - fmn-types.db

    notify:

-   - restart collectd

+   - Restart collectd

    tags:

    - config

    - collectd/server
@@ -52,7 +52,7 @@ 

    - fmn.conf

    - unixsock.conf

    notify:

-   - restart collectd

+   - Restart collectd

    tags:

    - config

    - collectd/server
@@ -100,7 +100,7 @@ 

      src: service.timeout.conf

      dest: /etc/systemd/system/collectd.service.d/timeout.conf

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - config

    - collectd/server

@@ -7,7 +7,7 @@ 

      mode=0755

    tags:

    - collectd

-   notify: restart collectd

+   notify: Restart collectd

  

  - name: Copy in /etc/collectd.d/web-service.conf

    ansible.builtin.template: >
@@ -15,7 +15,7 @@ 

      dest=/etc/collectd.d/{{ site }}.conf

    tags:

    - collectd

-   notify: restart collectd

+   notify: Restart collectd

  

  - name: Let collectd talk to apache over tcp

    seboolean: name=collectd_tcp_network_connect state=yes persistent=yes

@@ -1,16 +1,16 @@ 

  ---

- - name: chmod_key

+ - name: Chmod_key

    ansible.builtin.file: path=/etc/lighttpd/copr-be.fedoraproject.org.pem owner=root group=root mode=0600

  

- - name: restart copr-backend

+ - name: Restart copr-backend

    service: name="{{ copr_backend_target }}" state=restarted

    when: not services_disabled

  

- - name: systemctl daemon-reload

+ - name: Systemctl daemon-reload

    ansible.builtin.command: /usr/bin/systemctl daemon-reload

  

- - name: restart lighttpd

+ - name: Restart lighttpd

    action: service name=lighttpd state=restarted

  

- - name: restart node_exporter

+ - name: Restart node_exporter

    action: service name=node_exporter state=restarted

@@ -96,7 +96,7 @@ 

  - name: Install lighttpd.conf

    ansible.builtin.template: src="lighttpd/lighttpd.conf" dest=/etc/lighttpd/lighttpd.conf owner=root group=root mode=0644

    notify:

-   - restart lighttpd

+   - Restart lighttpd

    tags:

    - config

    - lighttpd_config
@@ -110,7 +110,7 @@ 

      - content-encoding-gzip-if-exists.lua

      - pulp-redirect.lua

    notify:

-   - restart lighttpd

+   - Restart lighttpd

    tags:

    - config

  
@@ -133,7 +133,7 @@ 

    - dirlisting.conf

    - mime.conf

    notify:

-   - restart lighttpd

+   - Restart lighttpd

    tags:

    - config

  
@@ -247,7 +247,7 @@ 

  - name: Copy copr-be.conf

    ansible.builtin.template: src="copr-be.conf.j2" dest=/etc/copr/copr-be.conf  owner=root group=copr mode=640

    notify:

-   - restart copr-backend

+   - Restart copr-backend

    tags:

    - config

    - copr_infrastructure_password
@@ -265,7 +265,7 @@ 

              owner=copr group=copr mode=0600

    when: copr_messaging

    notify:

-   - restart copr-backend

+   - Restart copr-backend

    tags:

    - config

  
@@ -406,6 +406,6 @@ 

      regexp: '^ARGS='

      line: 'ARGS=--collector.systemd'

      backrefs: yes

-   notify: restart node_exporter

+   notify: Restart node_exporter

    tags:

      - prometheus_node_exporter

@@ -67,7 +67,7 @@ 

  

            [Install]

            WantedBy=timers.target

-       notify: systemctl daemon-reload

+       notify: Systemctl daemon-reload

  

  - name: Prepare mount point

    ansible.builtin.file: state=directory path=/var/lib/copr/public_html

@@ -10,7 +10,7 @@ 

      value: ifcfg-rh

      backup: yes

    notify:

-   - restart NetworkManager

+   - Restart NetworkManager

  

  - name: Set up gateway

    lineinfile: dest=/etc/sysconfig/network line="GATEWAYDEV=eth0"

@@ -1,5 +1,5 @@ 

  ---

  - import_tasks: "{{ handlers_path }}/restart_services.yml"

  

- - name: restart postgresql

+ - name: Restart postgresql

    service: name=postgresql state=restarted

@@ -40,7 +40,7 @@ 

  

  - name: Configure crond

    ansible.builtin.copy: src=sysconfig.crond dest=/etc/sysconfig/crond

-   notify: restart crond

+   notify: Restart crond

  

  - name: Install base copr packages

    ansible.builtin.package:
@@ -66,7 +66,7 @@ 

                state=present

                line='MAILTO=copr-team@redhat.com'

                regexp="^MAILTO"

-   notify: restart crond

+   notify: Restart crond

  

  - name: Override the default rsyslog logrotate file

    ansible.builtin.copy: src=syslog-logrotate dest=/etc/logrotate.d/rsyslog

@@ -2,4 +2,4 @@ 

  

  case $1 in --init) exit 0 ;; esac

  

- systemctl restart httpd

+ systemctl Restart httpd

@@ -23,4 +23,4 @@ 

      pem_fixup "$domain"

  done

  

- systemctl restart lighttpd

+ systemctl Restart lighttpd

@@ -1,6 +1,6 @@ 

  ---

- - name: reload httpd

+ - name: Reload httpd

    service: name="httpd" state="restarted"

  

- - name: restart copr-dist-git

+ - name: Restart copr-dist-git

    service: name="copr-dist-git" state="restarted"

@@ -46,7 +46,7 @@ 

    - config

    - copr_infrastructure_password

    notify:

-   - restart copr-dist-git

+   - Restart copr-dist-git

  

  - name: Set git variables for copr-dist-git user

    ansible.builtin.copy: src=".gitconfig" dest="/home/copr-dist-git/.gitconfig"
@@ -61,7 +61,7 @@ 

    tags:

    - config

    notify:

-   - reload httpd

+   - Reload httpd

  

  - name: Letsencrypt for copr-dist-git

    include_role: name=copr/certbot
@@ -76,12 +76,12 @@ 

    tags:

    - config

    notify:

-   - reload httpd

+   - Reload httpd

  

  - name: Install /etc/httpd/conf.d/ssl.conf

    ansible.builtin.template: src="ssl.conf.j2" dest="/etc/httpd/conf.d/ssl.conf" owner=root group=root mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

  

  - name: Temporary logrotation fix until copr-dist-git 0.26 is released & deployed

    ansible.builtin.copy: src="logrotate.d/copr-dist-git" dest="/etc/logrotate.d/copr-dist-git"

@@ -1,14 +1,14 @@ 

  ---

  - import_tasks: "{{ handlers_path }}/restart_services.yml"

  

- - name: restart postgresql

+ - name: Restart postgresql

    service: name=postgresql

             state=restarted

  

- - name: restart copr-fe-fedora-messaging-reader

+ - name: Restart copr-fe-fedora-messaging-reader

    service: name="fm-consumer@copr_messaging"

             state=restarted

    when: not services_disabled|bool

  

- - name: restart node_exporter

+ - name: Restart node_exporter

    action: service name=node_exporter state=restarted

@@ -5,7 +5,7 @@ 

    with_items:

    - "coprs.conf"

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

    - certbot
@@ -13,7 +13,7 @@ 

  - name: Drop old and now unused coprs_ssl.conf

    ansible.builtin.file: path=/etc/httpd/conf.d/coprs_ssl.conf state=absent

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

  

@@ -86,8 +86,8 @@ 

  - name: Install copr configs

    ansible.builtin.template: src="copr.conf" dest=/etc/copr/copr.conf mode=600

    notify:

-   - reload httpd

-   - restart copr-fe-fedora-messaging-reader

+   - Reload httpd

+   - Restart copr-fe-fedora-messaging-reader

    tags:

    - config

    - copr_infrastructure_password
@@ -181,7 +181,7 @@ 

  - name: Install fedora messaging config for Copr

    ansible.builtin.template: src="fedora-messaging/copr_messaging.toml" dest="/etc/fedora-messaging/copr_messaging.toml"

    notify:

-   - restart copr-fe-fedora-messaging-reader

+   - Restart copr-fe-fedora-messaging-reader

    tags:

    - config

  
@@ -191,7 +191,7 @@ 

  - name: Install custom systemd service files

    ansible.builtin.copy: src=systemd dest=/etc

    notify:

-   - reload httpd

+   - Reload httpd

  

  - name: Compress rotated httpd logs

    ansible.builtin.copy: src="httpd.logrotate" dest="/etc/logrotate.d/httpd"
@@ -219,7 +219,7 @@ 

      regexp: '^ARGS='

      line: 'ARGS=--collector.textfile.directory="/var/lib/prometheus/node-exporter" --collector.systemd'

      backrefs: yes

-   notify: restart node_exporter

+   notify: Restart node_exporter

  

  - name: Install nrpe

    dnf: name=nrpe state=present
@@ -237,4 +237,4 @@ 

  - name: Install gai.conf

    ansible.builtin.copy: src=gai.conf dest=/etc

    notify:

-   - reload httpd

+   - Reload httpd

@@ -17,7 +17,7 @@ 

  - name: Copy pg_hba.conf

    ansible.builtin.copy: src="pg/pg_hba.conf" dest=/var/lib/pgsql/data/pg_hba.conf owner=postgres group=postgres mode=0600

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - config

  
@@ -61,7 +61,7 @@ 

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^shared_buffers ='

      line: 'shared_buffers = 8096MB'

-   notify: restart postgresql

+   notify: Restart postgresql

    tags:

    - config

  
@@ -70,7 +70,7 @@ 

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^effective_cache_size ='

      line: 'effective_cache_size = 2048MB'

-   notify: restart postgresql

+   notify: Restart postgresql

    tags:

    - config

  
@@ -79,7 +79,7 @@ 

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^work_mem ='

      line: 'work_mem = 4MB'

-   notify: restart postgresql

+   notify: Restart postgresql

    tags:

    - config

  
@@ -88,7 +88,7 @@ 

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^maintenance_work_mem ='

      line: 'maintenance_work_mem = 500MB'

-   notify: restart postgresql

+   notify: Restart postgresql

    tags:

    - config

  
@@ -97,7 +97,7 @@ 

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^checkpoint_completion_target ='

      line: 'checkpoint_completion_target = 0.9'

-   notify: restart postgresql

+   notify: Restart postgresql

    tags:

    - config

  
@@ -106,7 +106,7 @@ 

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^log_min_duration_statement ='

      line: 'log_min_duration_statement = 500'

-   notify: restart postgresql

+   notify: Restart postgresql

    tags:

    - config

  
@@ -115,7 +115,7 @@ 

      path: /var/lib/pgsql/data/postgresql.conf

      regexp: '^max_connections ='

      line: 'max_connections = 200'

-   notify: restart postgresql

+   notify: Restart postgresql

    tags:

    - config

  

@@ -48,7 +48,7 @@ 

  - name: Install libvirtd.conf

    ansible.builtin.copy: src="{{ files }}/virthost/libvirtd.conf" dest=/etc/libvirt/libvirtd.conf

    notify:

-   - restart libvirtd

+   - Restart libvirtd

    tags:

    - libvirtd

    - config
@@ -99,7 +99,7 @@ 

      virsh net-start host-bridge

      virsh net-autostart host-bridge

    when: libvirt_bridge_exists.changed

-   notify: restart libvirtd

+   notify: Restart libvirtd

    tags: libvirtd

  

  - name: Check if image pool exists
@@ -121,7 +121,7 @@ 

      virsh pool-start "{{ image_pool_name }}"

      virsh pool-autostart "{{ image_pool_name }}"

    when: libvirt_pool_exists.changed

-   notify: restart libvirtd

+   notify: Restart libvirtd

    tags: libvirtd

  

  - name: Allow copr user controlling libvirt
@@ -132,8 +132,8 @@ 

      value: libvirt

      backup: yes

    notify:

-     - reload systemd

-     - restart libvirtd.socket

+     - Reload systemd

+     - Restart libvirtd.socket

    tags: libvirtd

  

  - name: Create the copr user

@@ -9,7 +9,7 @@ 

  - name: Install copr-keygen

    dnf: state=present name=copr-keygen

    notify:

-   - restart haveged

+   - Restart haveged

  

  - name: Change owner of data to copr-signer

    ansible.builtin.file: path=/var/lib/copr-keygen owner=copr-signer group=copr-signer recurse=yes
@@ -17,14 +17,14 @@ 

  - name: Put keygen vhost for httpd

    ansible.builtin.copy: src="httpd/copr-keygen.conf" dest="/etc/httpd/conf.d/copr-keygen.conf"

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

  

  - name: Put config for signd

    ansible.builtin.template: src="sign.conf" dest="/etc/sign.conf"

    notify:

-   - restart obs-signd

+   - Restart obs-signd

    tags:

    - config

  

@@ -11,6 +11,6 @@ 

    with_items:

    - developer.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - developer

@@ -9,7 +9,7 @@ 

  - name: Setup dhcpd.conf

    ansible.builtin.copy: src=dhcpd.conf.{{ inventory_hostname }} dest=/etc/dhcp/dhcpd.conf mode=644

    notify:

-   - restart dhcpd

+   - Restart dhcpd

    tags:

    - sshd_config

    - config

@@ -1,3 +1,3 @@ 

  ---

- - name: restart pagure_milter

+ - name: Restart pagure_milter

    service: name=pagure_milter state=restarted

@@ -42,8 +42,8 @@ 

  #         dest=/usr/lib/systemd/system/stunnel.service

  #         owner=root group=root mode=0755

  #   notify:

- #   - reload systemd

- #   - restart stunnel

+ #   - Reload systemd

+ #   - Restart stunnel

  #   tags:

  #   - pagure

  #   - stunnel
@@ -61,7 +61,7 @@ 

  #             owner=root group=root mode=0600

  #   with_items:

  #   - { file: stunnel-conf.j2, dest: /etc/stunnel/stunnel.conf }

- #   notify: restart stunnel

+ #   notify: Restart stunnel

  #   tags:

  #   - pagure

  #   - stunnel
@@ -137,7 +137,7 @@ 

    - web

    - pagure

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Pagure configuration for the hooks

    ansible.builtin.template: src={{ item.file }}
@@ -151,7 +151,7 @@ 

    - web

    - pagure

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Create the database scheme

    ansible.builtin.command: /usr/bin/python3 /usr/share/pagure/pagure_createdb.py
@@ -204,7 +204,7 @@ 

    - config

    - pagure

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Install the wsgi file

    ansible.builtin.template: src={{ item }}
@@ -217,7 +217,7 @@ 

    - web

    - pagure

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Add default facl so apache can read git repos

    acl: default=yes etype=user entity=apache permissions="rx" name=/srv/git state=present
@@ -247,7 +247,7 @@ 

    - pagure_webhook

    - pagure_worker

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - pagure

  
@@ -268,7 +268,7 @@ 

    - config

    - pagure

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Create the /srv/cache/extras folder for the crons

    ansible.builtin.file: state=directory

file modified
+7 -7
@@ -30,14 +30,14 @@ 

  - name: Install the mod_auth_openidc configuration

    ansible.builtin.template: src=auth_openidc.conf dest=/etc/httpd/conf.d/auth_openidc.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - distgit

  

  - name: Install the http push configuration

    ansible.builtin.template: src=httppush.conf dest=/etc/httpd/conf.d/httpush.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - distgit

  
@@ -67,7 +67,7 @@ 

  - name: Install the mod_ssl configuration

    ansible.builtin.copy: src=ssl.conf dest=/etc/httpd/conf.d/ssl.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - distgit

  
@@ -87,7 +87,7 @@ 

          group=apache

          mode=0600

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - distgit

  
@@ -198,14 +198,14 @@ 

  - name: Install the DistGit related httpd config

    ansible.builtin.copy: src=git-smart-http.conf dest=/etc/httpd/conf.d/dist-git/git-smart-http.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - distgit

  

  - name: Symlink pkgs-git-repos-list

    ansible.builtin.copy: src=repolist.conf dest=/etc/httpd/conf.d/dist-git/repolist.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - distgit

  
@@ -241,7 +241,7 @@ 

    - lookaside.conf

    - lookaside-upload.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - distgit

    - sslciphers

file modified
+11 -11
@@ -12,7 +12,7 @@ 

  - name: Copy rndc config

    ansible.builtin.copy: src=rndc.conf dest=/etc/rndc.conf

    notify:

-   - restart named

+   - Restart named

    tags:

    - config

    - dns
@@ -20,7 +20,7 @@ 

  - name: Copy rndc key

    ansible.builtin.copy: src={{ private }}/files/dns/rndc.key dest=/etc/rndc.key

    notify:

-   - restart named

+   - Restart named

    tags:

    - config

    - dns
@@ -28,7 +28,7 @@ 

  - name: Copy named cache

    ansible.builtin.copy: src=named.ca dest=/var/named/named.ca

    notify:

-   - restart named

+   - Restart named

    tags:

    - config

    - dns
@@ -36,7 +36,7 @@ 

  - name: Copy geoip.py

    ansible.builtin.copy: src=geoip.py dest=/usr/local/bin/geoip.py mode=0755

    notify:

-   - restart named

+   - Restart named

    tags:

    - config

    - dns
@@ -44,7 +44,7 @@ 

  - name: Copy GeoIP.sh

    ansible.builtin.copy: src=GeoIP.sh dest=/var/named/GeoIP.sh mode=0755

    notify:

-   - restart named

+   - Restart named

    tags:

    - config

    - dns
@@ -53,14 +53,14 @@ 

  #  ansible.builtin.command: /var/named/GeoIP.sh

  #  changed_when: "1 != 1"

  #  notify:

- #  - restart named

+ #  - Restart named

  #  tags:

  #  - dns

  

  - name: Copy update-dns

    ansible.builtin.copy: src=update-dns dest=/usr/local/bin/update-dns mode=0755

    notify:

-   - restart named

+   - Restart named

    tags:

    - config

    - dns
@@ -68,7 +68,7 @@ 

  - name: Copy zones

    ansible.builtin.copy: src=zones.conf dest=/etc/named/zones.conf owner=root group=root mode=0644

    notify:

-   - restart named

+   - Restart named

    tags:

    - config

    - dns
@@ -76,7 +76,7 @@ 

  - name: Copy named config

    ansible.builtin.copy: src=named.conf dest=/etc/named.conf mode=0644 owner=root group=root

    notify:

-   - restart named

+   - Restart named

    tags:

    - config

    - dns
@@ -85,7 +85,7 @@ 

    ansible.builtin.command: /usr/local/bin/update-dns

    changed_when: "1 != 1"

    notify:

-   - restart named

+   - Restart named

    tags:

    - config

    - dns
@@ -114,7 +114,7 @@ 

    ansible.builtin.command: semanage port -a -t dns_port_t -p tcp 8053

    when: semanageoutput.stdout.find("8053") == -1

    notify:

-   - restart named

+   - Restart named

    tags:

    - dns

  

@@ -15,7 +15,7 @@ 

    ansible.builtin.template:

      src: config.yml.j2

      dest: "{{ conf_path }}"

-   notify: restart docker-distribution

+   notify: Restart docker-distribution

    tags:

    - docker-distribution

  

@@ -71,7 +71,7 @@ 

    - config

    - sslciphers

    notify:

-   - reload httpd

+   - Reload httpd

  

  - name: Make sure apache autoindex.conf is replaced with ours

    ansible.builtin.copy: src=httpd/dl.fedoraproject.org/autoindex.conf dest=/etc/httpd/conf.d/autoindex.conf
@@ -79,7 +79,7 @@ 

    - httpd

    - config

    notify:

-   - reload httpd

+   - Reload httpd

  

  - name: Configure httpd dl sub conf

    ansible.builtin.copy: src=httpd/dl.fedoraproject.org/ dest=/etc/httpd/conf.d/dl.fedoraproject.org/
@@ -87,7 +87,7 @@ 

    - httpd

    - config

    notify:

-   - reload httpd

+   - Reload httpd

  

  - name: Install haveged for entropy

    ansible.builtin.package: name=haveged state=present

@@ -11,7 +11,7 @@ 

      dest=/etc/httpd/conf.d/{{website}}/gather-easyfix.conf

      owner=root group=root mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - easyfix

    - easyfix/proxy

@@ -93,11 +93,11 @@ 

    - fedmsgdconfig

    - fedmsg/base

    notify:

-   - reload httpd

-   - restart fedmsg-gateway

-   - restart fedmsg-hub

-   - restart fedmsg-irc

-   - restart fedmsg-relay

+   - Reload httpd

+   - Restart fedmsg-gateway

+   - Restart fedmsg-hub

+   - Restart fedmsg-irc

+   - Restart fedmsg-relay

  

  - name: Dynamically generate policy from group/host vars.

    ansible.builtin.template: >
@@ -115,11 +115,11 @@ 

    - fedmsgdpolicy

    - fedmsg/base

    notify:

-   - reload httpd

-   - restart fedmsg-gateway

-   - restart fedmsg-hub

-   - restart fedmsg-irc

-   - restart fedmsg-relay

+   - Reload httpd

+   - Restart fedmsg-gateway

+   - Restart fedmsg-hub

+   - Restart fedmsg-irc

+   - Restart fedmsg-relay

  

  - name: Setup basic /etc/fedmsg.d/ contents for firewalled/external hosts

    ansible.builtin.template: >
@@ -139,11 +139,11 @@ 

    - fedmsgdconfig

    - fedmsg/base

    notify:

-   - reload httpd

-   - restart fedmsg-gateway

-   - restart fedmsg-hub

-   - restart fedmsg-irc

-   - restart fedmsg-relay

+   - Reload httpd

+   - Restart fedmsg-gateway

+   - Restart fedmsg-hub

+   - Restart fedmsg-irc

+   - Restart fedmsg-relay

  

  - name: Install fedmsg-relay in case we're in debug mode.

    ansible.builtin.package: name=fedmsg-relay state=present
@@ -152,11 +152,11 @@ 

    - fedmsg_loopback

    - fedmsg/base

    notify:

-   - reload httpd

-   - restart fedmsg-gateway

-   - restart fedmsg-hub

-   - restart fedmsg-irc

-   - restart fedmsg-relay

+   - Reload httpd

+   - Restart fedmsg-gateway

+   - Restart fedmsg-hub

+   - Restart fedmsg-irc

+   - Restart fedmsg-relay

  

  - name: Install fedmsg-relay in case we're in debug mode.

    dnf: name=fedmsg-relay state=present
@@ -165,11 +165,11 @@ 

    - fedmsg_loopback

    - fedmsg/base

    notify:

-   - reload httpd

-   - restart fedmsg-gateway

-   - restart fedmsg-hub

-   - restart fedmsg-irc

-   - restart fedmsg-relay

+   - Reload httpd

+   - Restart fedmsg-gateway

+   - Restart fedmsg-hub

+   - Restart fedmsg-irc

+   - Restart fedmsg-relay

  

  - name: Destroy standard config to make way for debug loopback.

    ansible.builtin.file: dest=/etc/fedmsg.d/{{item}} state=absent
@@ -181,11 +181,11 @@ 

    - fedmsg_loopback

    - fedmsg/base

    notify:

-   - reload httpd

-   - restart fedmsg-gateway

-   - restart fedmsg-hub

-   - restart fedmsg-irc

-   - restart fedmsg-relay

+   - Reload httpd

+   - Restart fedmsg-gateway

+   - Restart fedmsg-hub

+   - Restart fedmsg-irc

+   - Restart fedmsg-relay

  

  - name: Overwrite standard config with local fedmsg debugging loopback

    ansible.builtin.copy: src=relay-debug-loopback.py dest=/etc/fedmsg.d/relay.py
@@ -194,11 +194,11 @@ 

    - fedmsg_loopback

    - fedmsg/base

    notify:

-   - reload httpd

-   - restart fedmsg-gateway

-   - restart fedmsg-hub

-   - restart fedmsg-irc

-   - restart fedmsg-relay

+   - Reload httpd

+   - Restart fedmsg-gateway

+   - Restart fedmsg-hub

+   - Restart fedmsg-irc

+   - Restart fedmsg-relay

  

  - name: Start fedmsg-relay, only for loopback testing

    service: name=fedmsg-relay state=started

@@ -38,7 +38,7 @@ 

      dest=/etc/httpd/conf.d/{{website}}/fedmsg.conf

      owner=root group=root mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - fedmsg

    - fedmsg/crl

@@ -73,8 +73,8 @@ 

          dest=/usr/lib/systemd/system/stunnel.service

          owner=root group=root mode=0644

    notify:

-   - reload systemd

-   - restart stunnel

+   - Reload systemd

+   - Restart stunnel

    tags:

    - fedmsg/gateway

    - fedmsg/gateway/slave
@@ -91,7 +91,7 @@ 

              owner=root group=root mode=0600

    with_items:

    - { file: stunnel-conf.j2, dest: /etc/stunnel/stunnel.conf }

-   notify: restart stunnel

+   notify: Restart stunnel

    tags:

    - fedmsg/gateway

    - fedmsg/gateway/slave
@@ -101,7 +101,7 @@ 

      src={{private}}/files/httpd/wildcard-2024.fedoraproject.org.combined.cert

      dest=/etc/pki/tls/certs/wildcard-2024.fedoraproject.org.combined.cert

      owner=root group=root mode=0644

-   notify: restart stunnel

+   notify: Restart stunnel

    tags:

    - fedmsg/gateway

    - fedmsg/gateway/slave

@@ -22,7 +22,7 @@ 

    - config

    - fedmsg/gateway

    notify:

-   - restart fedmsg-gateway

+   - Restart fedmsg-gateway

  

  - name: Create systemd drop-in directory

    ansible.builtin.file: >
@@ -39,7 +39,7 @@ 

    - config

    - fedmsg/gateway

    notify:

-   - restart fedmsg-gateway

+   - Restart fedmsg-gateway

  

  - name: Enable on boot and start fedmsg-gateway

    service:

@@ -32,12 +32,12 @@ 

  - name: Enable the websocket server if we should

    ansible.builtin.copy: src=websockets.py dest=/etc/fedmsg.d/websockets.py

    when: enable_websocket_server

-   notify: restart fedmsg-hub

+   notify: Restart fedmsg-hub

  

  - name: Disable the websocket server if we should..

    ansible.builtin.file: dest=/etc/fedmsg.d/websockets.py state=absent

    when: not enable_websocket_server

-   notify: restart fedmsg-hub

+   notify: Restart fedmsg-hub

  

  - name: Set fedmsg ownership on /var/run/fedmsg

    ansible.builtin.file: >
@@ -68,7 +68,7 @@ 

    - fedmsg-hub

    - fedmsg-hub-3

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - fedmsg/hub

  
@@ -80,7 +80,7 @@ 

    - fedmsg-hub

    - fedmsg-hub-3

    notify:

-   - reload systemd

-   - restart fedmsg-hub

+   - Reload systemd

+   - Restart fedmsg-hub

    tags:

    - fedmsg/hub

@@ -27,7 +27,7 @@ 

    - config

    - fedmsg/irc

    notify:

-   - restart fedmsg-irc

+   - Restart fedmsg-irc

  

  - name: Setup fas credentials config file

    ansible.builtin.template: >
@@ -40,7 +40,7 @@ 

    - config

    - fedmsg/irc

    notify:

-   - restart fedmsg-irc

+   - Restart fedmsg-irc

  

  - name: Enable on boot and start fedmsg-irc

    service: name=fedmsg-irc state=started enabled=true

@@ -33,7 +33,7 @@ 

    - services

    - fedmsg/relay

    notify:

-   - restart fedmsg-relay

+   - Restart fedmsg-relay

    when: env != "staging"

  

  - name: Enable on boot and start fedmsg-relay
@@ -42,5 +42,5 @@ 

    - services

    - fedmsg/relay

    notify:

-   - restart fedmsg-relay

+   - Restart fedmsg-relay

    when: env == "staging"

@@ -21,7 +21,7 @@ 

    - budget.conf

    - languages.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/budget

@@ -38,7 +38,7 @@ 

    - fedora-docs.conf

    - fedora-docs-old.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-docs

    - fedora-docs/proxy
@@ -51,7 +51,7 @@ 

    - fedora-docs.conf

    - fedora-docs-old.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-docs

    - fedora-docs/proxy

@@ -13,7 +13,7 @@ 

    - alt.conf

    - languages.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/alt

@@ -3,7 +3,7 @@ 

    ansible.builtin.copy: src="{{private}}/files/docker-registry/{{env}}/candidate-htpasswd" dest=/etc/httpd/conf.d/candidate-registry.fedoraproject.org/passwd

          owner=root group=root mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/candidate-registry

@@ -12,7 +12,7 @@ 

    with_items:

    - codecs.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/codecs

@@ -13,7 +13,7 @@ 

    - fedoracommunity.org-web.conf

    - languages.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/community

@@ -18,7 +18,7 @@ 

    with_items:

    - matrix.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/fedora.im

@@ -13,7 +13,7 @@ 

    - flocktofedora.org.conf

    - languages.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/flocktofedora

@@ -14,7 +14,7 @@ 

    - languages.conf

    - csp.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/getfedora

@@ -13,7 +13,7 @@ 

    - iot.conf

    - languages.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/iot

@@ -13,7 +13,7 @@ 

    - labs.conf

    - languages.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/labs

@@ -60,7 +60,7 @@ 

    - matrix.conf

    - flathub-verified.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/main
@@ -74,7 +74,7 @@ 

    with_items:

    - 'sponsor.conf'

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/main
@@ -111,7 +111,7 @@ 

      src=browserid.fedoraproject.org dest=/srv/web/browserid.fedoraproject.org

      owner=root group=root mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/main
@@ -123,7 +123,7 @@ 

      owner=root group=root mode=0644

    when: env == "staging"

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/main
@@ -135,7 +135,7 @@ 

      owner=root group=root mode=0644

    when: env != "staging"

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/main

@@ -12,7 +12,7 @@ 

    with_items:

    - mirrors.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/mirrors

@@ -6,7 +6,7 @@ 

    with_items:

    - ols.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/ols

@@ -2,7 +2,7 @@ 

  - name: Copy ostree config file

    ansible.builtin.copy: src=ostree.conf dest=/etc/httpd/conf.d/ostree.fedoraproject.org/ostree.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - ostree

@@ -13,7 +13,7 @@ 

    ansible.builtin.copy: src="{{ private }}/files/fedora-ca.cert" dest=/etc/pki/httpd/fedora-server-ca.cert

          owner=root group=root mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/registry
@@ -29,7 +29,7 @@ 

          dest="/etc/pki/httpd/registry-ca-{{env}}.cert"

          owner=root group=root mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/registry
@@ -38,7 +38,7 @@ 

    ansible.builtin.copy: src="passwd-{{env}}" dest=/etc/httpd/conf.d/registry.fedoraproject.org/passwd

          owner=root group=root mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/registry

@@ -4,7 +4,7 @@ 

    ansible.builtin.package: name=mod_auth_gssapi

             state=present

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/src
@@ -16,7 +16,7 @@ 

          group=apache

          mode=0600

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/src
@@ -28,7 +28,7 @@ 

    with_items:

    - expires.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/src

@@ -13,7 +13,7 @@ 

    - start-web.conf

    - languages.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedora-web

    - fedora-web/start

@@ -3,4 +3,4 @@ 

  - name: Conditionally restart fedora_nightlies consumer service

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fm-consumer@fedora_nightlies

    listen:

-   - restart fedora_nightlies

+   - Restart fedora_nightlies

@@ -101,7 +101,7 @@ 

    ansible.builtin.command: "python3 -m pip install --no-deps /root/fedora_nightlies"

    when: "gitfn is changed or instfn.rc != 0"

    notify:

-   - restart fedora_nightlies

+   - Restart fedora_nightlies

  

  - name: Create /etc/pki/fedora-messaging

    ansible.builtin.file:
@@ -145,7 +145,7 @@ 

  - name: Configure fedora-messaging fedora_nightlies

    ansible.builtin.template: src=fedora_nightlies.toml.j2 dest=/etc/fedora-messaging/fedora_nightlies.toml owner=root group=root mode=0640

    notify:

-   - restart fedora_nightlies

+   - Restart fedora_nightlies

    tags:

    - config

  

@@ -18,6 +18,6 @@ 

    with_items:

    - fedoraloveskde.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fedoraloveskde

@@ -7,7 +7,7 @@ 

      name:

      - php

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - packages

  
@@ -24,7 +24,7 @@ 

      group=root

      mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

  

@@ -33,7 +33,7 @@ 

          group=root

          mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - geoip_config

    - config
@@ -61,7 +61,7 @@ 

          group=root

          mode=0775

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - geoip_config

    - config

@@ -5,7 +5,7 @@ 

      dest=/etc/httpd/conf.d/{{website}}/geoip-city-wsgi-proxy.conf

      owner=root group=root mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - geoip-city-wsgi

    - geoip-city-wsgi/proxy

@@ -46,4 +46,4 @@ 

    when: ansible_distribution_major_version|int == 6 and ansible_distribution == 'RedHat'

    tags: git/server

    notify:

-   - restart xinetd

+   - Restart xinetd

@@ -30,7 +30,7 @@ 

    - config

    - github2fedmsg

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Copy github2fedmsg wsgi script

    ansible.builtin.copy: >
@@ -42,7 +42,7 @@ 

    - config

    - github2fedmsg

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Copy github2fedmsg httpd config

    ansible.builtin.template: >
@@ -54,7 +54,7 @@ 

    - config

    - github2fedmsg

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Hotfix - allow velruse to do stateless openid

    ansible.builtin.copy: >
@@ -65,7 +65,7 @@ 

    - hotfix

    - github2fedmsg

    notify:

-   - restart apache

+   - Restart apache

  

    # Fix for https://pagure.io/fedora-infrastructure/issue/11776

  - name: Hotfix - Fix the KeyError when looking for user in github event
@@ -76,7 +76,7 @@ 

    - hotfix

    - github2fedmsg

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Ensure selinux lets httpd talk to postgres

    seboolean: name=httpd_can_network_connect_db persistent=yes state=yes

@@ -7,7 +7,7 @@ 

  

  - ansible.builtin.template: src=rewrite.conf dest=/etc/httpd/conf.d/{{website}}/haproxy.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - haproxy

    - haproxy/rewrite
@@ -15,7 +15,7 @@ 

  

  - ansible.builtin.template: src=rewrite.conf dest=/etc/httpd/conf.d/{{website}}/haproxy.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - haproxy

    - haproxy/rewrite

file modified
+1 -1
@@ -17,7 +17,7 @@ 

    with_items:

    - { file: haproxy.cfg, dest: /etc/haproxy/haproxy.cfg }

    notify:

-   - restart haproxy

+   - Restart haproxy

    tags:

    - haproxy

  

@@ -14,7 +14,7 @@ 

      mode=0644

    when: SSLCertificateChainFile is defined

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/certificate
@@ -30,7 +30,7 @@ 

    - "{{private}}/files/httpd/{{cert}}.cert"

    - "{{private}}/files/httpd/{{certname}}.cert"

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/certificate
@@ -46,7 +46,7 @@ 

    - "{{private}}/files/httpd/{{key}}.key"

    - "{{private}}/files/httpd/{{certname}}.key"

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/certificate

@@ -17,7 +17,7 @@ 

    - "{{  roles_path  }}/httpd/domainrewrite/templates/domainrewrite.{{destname}}.conf"

    - "{{  roles_path  }}/httpd/domainrewrite/templates/domainrewrite.conf"

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/domainrewrite

@@ -1,7 +1,7 @@ 

  ---

  - ansible.builtin.copy: src=fingerprints.html dest=/srv/web/fingerprints.html

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fingerprints

    - httpd
@@ -9,7 +9,7 @@ 

  

  - ansible.builtin.copy: src=fingerprints.conf dest=/etc/httpd/conf.d/{{website}}/fingerprints.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - fingerprints

    - httpd

@@ -3,7 +3,7 @@ 

      src=mime-types.conf dest=/etc/httpd/conf.d/{{website}}/mime-types.conf

      owner=root group=root mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/mime-type

@@ -2,7 +2,7 @@ 

  - name: Install mod_ssl

    ansible.builtin.package: name=mod_ssl state=present

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/mod_ssl
@@ -15,7 +15,7 @@ 

      group=root

      mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/certificate

@@ -3,14 +3,14 @@ 

    ansible.builtin.copy: src=/root/ticketkey_{{env}}.tkey dest=/etc/httpd/ticketkey_{{env}}.tkey

          owner=root group=root mode=0600

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

  

  - name: Copy in the main httpd.conf file for proxy nodes

    ansible.builtin.template: >

      src=httpd.conf.j2 dest=/etc/httpd/conf/httpd.conf

      owner=root group=root mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/proxy
@@ -32,7 +32,7 @@ 

    - 02-ticketkey.conf

    - 03-reqtimeout.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/proxy
@@ -40,7 +40,7 @@ 

  - name: Remove the keepalives configuration

    ansible.builtin.file: path=/etc/httpd/conf.d/01-keepalives.conf state=absent

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/proxy
@@ -48,7 +48,7 @@ 

  - name: Set the apache mpm to use event MPM

    ansible.builtin.copy: src=00-mpm.conf dest=/etc/httpd/conf.modules.d/00-mpm.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/proxy
@@ -113,4 +113,4 @@ 

    - httpd/proxy

    - httpdoverride

    notify:

-   - reload systemd

+   - Reload systemd

@@ -15,7 +15,7 @@ 

      owner=root

      group=root

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    with_first_found:

    - redirect.{{shortname}}.conf

    - redirect.conf

@@ -22,7 +22,7 @@ 

      owner=root

      group=root

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/redirect

@@ -19,7 +19,7 @@ 

    - "{{  roles_path  }}/httpd/reverseproxy/templates/reversepassproxy.{{destname}}.conf"

    - "{{  roles_path  }}/httpd/reverseproxy/templates/reversepassproxy.conf"

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/reverseproxy

@@ -17,7 +17,7 @@ 

      group=root

      mode=0755

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/website
@@ -37,7 +37,7 @@ 

      group=root

      mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/website
@@ -56,7 +56,7 @@ 

    - robots

    - securityheaders

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/website
@@ -70,7 +70,7 @@ 

      group=root

      mode=0755

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/website
@@ -88,7 +88,7 @@ 

    - robots/{{site_name}}-robots.txt

    - robots/robots.txt

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - httpd

    - httpd/website

@@ -14,7 +14,7 @@ 

      state: present

      group:

        - sysadmin-main

-   notify: clean sss caches

+   notify: Clean sss caches

    no_log: true

    loop: "{{ ipa_servers }}"

    when: ipa_servers is defined
@@ -25,7 +25,7 @@ 

      name: "usergroup/sysadmin-main"

      ipaadmin_password: "{{ ipa_server_admin_passwords[item] }}"

      state: enabled

-   notify: clean sss caches

+   notify: Clean sss caches

    no_log: true

    loop: "{{ ipa_servers }}"

    when: ipa_servers is defined
@@ -36,7 +36,7 @@ 

      name: allow_all

      ipaadmin_password: "{{ ipa_server_admin_passwords[item] }}"

      state: disabled

-   notify: clean sss caches

+   notify: Clean sss caches

    no_log: true

    loop: "{{ ipa_servers }}"

    when: ipa_servers is defined
@@ -55,7 +55,7 @@ 

      usercategory: "all"

      hbacsvcgroup:

        - sudo

-   notify: clean sss caches

+   notify: Clean sss caches

    no_log: true

    loop: "{{ ipa_servers }}"

    when: ipa_servers is defined
@@ -117,6 +117,6 @@ 

      action: member

      state: present

      group: "{{ ipa_server_host_groups_dict[item[0]][item[1]]['shell_groups'] }}"

-   notify: clean sss caches

+   notify: Clean sss caches

    loop: "{{ ipa_server_host_groups }}"

    when: ipa_server_host_groups is defined and ipa_server_host_groups_dict[item[0]][item[1]]['shell_groups'] is defined

@@ -1,3 +1,3 @@ 

  ---

- - name: restart ipa

+ - name: Restart ipa

    ansible.builtin.command: ipactl restart

@@ -199,7 +199,7 @@ 

      dest: /etc/httpd/conf.d/ipa-rewrite.conf

      mode: "0644"

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - ipa/server

    - config
@@ -216,7 +216,7 @@ 

    changed_when: "'Disabling plugin' in output.stdout"

    failed_when: "'Plugin is already disabled' not in output.stdout and output.rc != 0"

    notify:

-   - restart ipa

+   - Restart ipa

  

  - name: Disable the nis tree

    ansible.builtin.shell: |
@@ -229,7 +229,7 @@ 

    changed_when: "'Disabling plugin' in output.stdout"

    failed_when: "'Plugin is already disabled' not in output.stdout and output.rc != 0"

    notify:

-   - restart ipa

+   - Restart ipa

  

  - name: Set the expiration date for the admin user

    community.general.ipa_user:
@@ -741,7 +741,7 @@ 

      dest: /etc/httpd/conf.d/referer-override.conf

      mode: "0644"

    notify:

-   - reload apache

+   - Reload apache

    tags:

    - ipa/server

    - config

@@ -103,7 +103,7 @@ 

      tags:

      - collectd

      - config

-     notify: restart collectd

+     notify: Restart collectd

  

    - name: Let collectd talk to the RabbitMQ management interface

      ansible.posix.seboolean:

file modified
+6 -6
@@ -46,7 +46,7 @@ 

      chdir: /opt/ipsilon-fedora

    when: git_update is changed

    notify:

-   - restart apache

+   - Restart apache

    tags:

    - ipsilon

  
@@ -56,7 +56,7 @@ 

      chdir: /opt/ipsilon-fedora

      creates: "{{ ansible_facts['python3']['sitelib'] }}/ipsilon/providers/openidc/plugins/account-scopes.py"

    notify:

-   - restart apache

+   - Restart apache

    tags:

    - ipsilon

  
@@ -116,7 +116,7 @@ 

    - ipsilon

    - config

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Copy ipsilon admin configuration

    ansible.builtin.template:
@@ -129,7 +129,7 @@ 

    - ipsilon

    - config

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Copy ipsilon OIDC client config

    ansible.builtin.copy:
@@ -143,7 +143,7 @@ 

    - config

    - oidc-config

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Copy ipsilon httpd config

    ansible.builtin.template:
@@ -153,7 +153,7 @@ 

    - ipsilon

    - config

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Copy OIDC private key

    ansible.builtin.copy:

@@ -28,4 +28,4 @@ 

      - result.rc == 0

    failed_when: "'FAILED' in result.stdout"

    notify:

-   - restart apache

+   - Restart apache

@@ -20,7 +20,7 @@ 

    - config

    - keepalived

    notify:

-   - restart keepalived

+   - Restart keepalived

  

  - name: Install keepalived failover script for host (or default)

    ansible.builtin.copy: src={{ item }} dest=/usr/local/bin/keepalived-notify.sh mode=755

@@ -33,7 +33,7 @@ 

    - config

    - kerneltest

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Create the database scheme

    when: inventory_hostname.startswith('kerneltest01')

@@ -189,7 +189,7 @@ 

  - name: Override kojid.service file to set TasksMax to unlimited

    ansible.builtin.copy: src=kojid.service dest=/etc/systemd/system/kojid.service

    notify:

-   - reload systemd

+   - Reload systemd

    - Restart kojid

    tags:

    - koji_builder
@@ -245,7 +245,7 @@ 

  - name: Install libvirt/network.conf

    ansible.builtin.copy: src=network.conf dest=/etc/libvirt/network.conf

    notify:

-   - restart virtnetworkd

+   - Restart virtnetworkd

    tags:

    - koji_builder

    when: env != "staging"

file modified
+18 -18
@@ -27,7 +27,7 @@ 

    with_items:

    - koji-osbuild-hub

    notify:

-   - restart kojira

+   - Restart kojira

    tags:

    - packages

    - koji_hub
@@ -48,7 +48,7 @@ 

  - name: Fedmenu shim

    ansible.builtin.template: src=fedmenu-extra-footer.html dest=/usr/share/koji-web/static/extra-footer.html

    tags: koji_hub

-   notify: reload httpd

+   notify: Reload httpd

    # XXX - we only want to do this in staging for now because it requires a patch

    # to koji itself to include the extra-footer.html file in a sufficiently

    # advanced way.
@@ -58,7 +58,7 @@ 

  - name: Set the apache mpm to use event MPM

    ansible.builtin.copy: src=00-mpm.conf dest=/etc/httpd/conf.modules.d/00-mpm.conf

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - config

    - koji_hub
@@ -69,14 +69,14 @@ 

    - config

    - koji_hub

    - koji_hub_osbuild

-   notify: reload httpd

+   notify: Reload httpd

  

  - name: Kojiweb config

    ansible.builtin.template: src=web.conf.j2 dest=/etc/kojiweb/web.conf owner=apache group=apache mode=600

    tags:

    - config

    - koji_hub

-   notify: reload httpd

+   notify: Reload httpd

  

  - name: Enable httpd_can_network_connect SELinux boolean for fedmsg

    seboolean: name=httpd_can_network_connect state=yes persistent=yes
@@ -177,7 +177,7 @@ 

    - koji-fedoramessaging

    - python3-koji-fedoramessaging-messages

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - packages

    - koji_hub
@@ -231,7 +231,7 @@ 

    copy: src={{ private }}/files/keytabs/{{ env }}/koji-hub-{{ koji_instance }} dest=/etc/koji-hub/koji-hub.keytab

          owner=apache group=apache mode=0600

    notify:

-   - reload httpd

+   - Reload httpd

    when: env != 'staging'

    tags:

    - config
@@ -241,7 +241,7 @@ 

    ansible.builtin.copy: src={{ private }}/files/keytabs/{{ env }}/koji-gssapi-{{ koji_instance }} dest=/etc/koji-hub/gssapi.keytab

          owner=apache group=apache mode=0600

    notify:

-   - reload httpd

+   - Reload httpd

    when: env != 'staging'

    tags:

    - config
@@ -253,7 +253,7 @@ 

  - name: Install kojiweb_cert_key.pem

    ansible.builtin.copy: src={{ private }}/files/koji/kojiweb_cert_key.pem dest=/etc/pki/tls/private/kojiweb_cert_key.pem owner=apache mode=600

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

    - koji_hub
@@ -262,7 +262,7 @@ 

  - name: Install production koji_cert.pem

    ansible.builtin.copy: src={{ private }}/files/koji/koji_cert.pem dest=/etc/pki/tls/certs/koji_cert.pem owner=apache mode=600

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

    - koji_hub
@@ -271,7 +271,7 @@ 

  - name: Install production koji_key.pem

    ansible.builtin.copy: src={{ private }}/files/koji/koji_key.pem dest=/etc/pki/tls/private/koji_key.pem owner=apache mode=600

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

    - koji_hub
@@ -303,7 +303,7 @@ 

    tags:

    - config

    - koji_hub

-   notify: reload httpd

+   notify: Reload httpd

  

  - name: Koji web hub specific config files

    ansible.builtin.template: src={{ item }}.j2 dest=/etc/httpd/conf.d/{{ item }} owner=root group=root
@@ -313,14 +313,14 @@ 

    tags:

    - config

    - koji_hub

-   notify: reload httpd

+   notify: Reload httpd

  

  - name: Koji web staging config files

    ansible.builtin.copy: src=kojiweb.conf.stg dest=/etc/httpd/conf.d/kojiweb-stg.conf owner=root group=root

    tags:

    - config

    - koji_hub

-   notify: reload httpd

+   notify: Reload httpd

    when: env == "staging"

  

  - name: Koji robots.txt config
@@ -328,7 +328,7 @@ 

    tags:

    - config

    - koji_hub

-   notify: reload httpd

+   notify: Reload httpd

  

  - name: Kojira log dir

    ansible.builtin.file: dest=/var/log/kojira owner=root group=root mode=0750 state=directory
@@ -343,7 +343,7 @@ 

    - config

    - koji_hub

    notify:

-   - restart kojira

+   - Restart kojira

  

  - name: Make an empty /mnt/fedora_koji for stg.

    ansible.builtin.file: state=directory path=/mnt/fedora_koji/koji owner=root group=root
@@ -414,7 +414,7 @@ 

  - name: Set httpd service override for fedora-messaging to work

    ansible.builtin.copy: src=httpd-override.conf dest=/etc/systemd/system/httpd.service.d/override.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - service

    - koji_hub
@@ -424,7 +424,7 @@ 

    service: name=httpd enabled=yes

    ignore_errors: true

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - service

    - koji_hub

@@ -9,7 +9,7 @@ 

    with_items:

    - infrastructure.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - kojipkgs

  
@@ -18,14 +18,14 @@ 

    with_items:

    - kojipkgs.conf

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - kojipkgs

  

  - name: Make sure httpd listens on port 8080

    lineinfile: dest=/etc/httpd/conf/httpd.conf state=present regexp="^Listen 80" line="Listen 8080"

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - kojipkgs

  
@@ -51,7 +51,7 @@ 

    ansible.builtin.copy: dest=/etc/systemd/system/varnish.service.d/restart-on-fail.conf

          src=restart-on-fail.conf

    notify:

-     - reload systemd

-     - reload varnish

+     - Reload systemd

+     - Reload varnish

    tags:

    - kojipkgs

@@ -67,7 +67,7 @@ 

      group=root

      mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - letsencrypt

  
@@ -79,7 +79,7 @@ 

      group=root

      mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - letsencrypt

  
@@ -91,7 +91,7 @@ 

      group=root

      mode=0600

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - letsencrypt

  
@@ -103,7 +103,7 @@ 

      group=root

      mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - letsencrypt

    delegate_to: "{{ certbot_addhost }}"
@@ -118,7 +118,7 @@ 

      group=root

      mode=0644

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - letsencrypt

    delegate_to: "{{ certbot_addhost }}"
@@ -133,7 +133,7 @@ 

      group=root

      mode=0600

    notify:

-   - reload proxyhttpd

+   - Reload proxyhttpd

    tags:

    - letsencrypt

    delegate_to: "{{ certbot_addhost }}"
@@ -148,7 +148,7 @@ 

      group=root

      mode=0644

    notify:

-   - restart stunnel

+   - Restart stunnel

    tags:

    - letsencrypt

    delegate_to: "{{ certbot_bundlehost }}"

@@ -261,7 +261,7 @@ 

    tags:

      - mailman

      - hyperkitty

-   notify: handle static files

+   notify: Handle static files

  

  - name: Create the hyperkitty templates override dirs

    ansible.builtin.file:
@@ -588,7 +588,7 @@ 

      - webui-qcluster

      - webui-warm-up-cache

    notify:

-     - systemctl daemon-reload

+     - Systemctl daemon-reload

    tags:

      - config

      - mailman
@@ -600,7 +600,7 @@ 

      dest: "/etc/systemd/system/hyperkitty.target"

      mode: "0644"

    notify:

-     - systemctl daemon-reload

+     - Systemctl daemon-reload

    tags:

      - config

      - mailman
@@ -620,7 +620,7 @@ 

      - hyperkitty-weekly

      - hyperkitty-yearly

    notify:

-     - systemctl daemon-reload

+     - Systemctl daemon-reload

    tags:

      - config

      - mailman
@@ -640,7 +640,7 @@ 

      - hyperkitty-weekly

      - hyperkitty-yearly

    notify:

-     - systemctl daemon-reload

+     - Systemctl daemon-reload

    tags:

      - config

      - mailman
@@ -655,7 +655,7 @@ 

    with_items:

      - mailmanweb.conf

    notify:

-     - reload apache

+     - Reload apache

    tags:

      - config

      - httpd

@@ -25,7 +25,7 @@ 

      - my.cnf.{{ ansible_distribution_version }}

      - my.cnf.default

    notify:

-     - restart mariadb

+     - Restart mariadb

  

  - name: Enable and start mariadb database

    service: name=mariadb enabled=yes state=started

@@ -161,14 +161,14 @@ 

  

  - name: Install localsettings

    ansible.builtin.template: src=LocalSettings.php.{{wikiname}}.j2 dest=/srv/web/{{wikiname}}-wiki/LocalSettings.php owner=apache group=apache mode=600 setype=httpd_sys_content_t

-   notify: reload httpd

+   notify: Reload httpd

    tags:

    - mediawiki

    - localsettings

  

  - name: Httpd conf

    ansible.builtin.template: src=mediawiki-app.conf.j2 dest=/etc/httpd/conf.d/{{wikiname}}.conf

-   notify: reload httpd

+   notify: Reload httpd

    tags:

    - mediawiki

  

@@ -8,7 +8,7 @@ 

  - name: Setup memcached sysconfig

    ansible.builtin.template: src=memcached dest=/etc/sysconfig/memcached mode=644

    notify:

-   - restart memcached

+   - Restart memcached

    tags:

    - config

    - memcached
@@ -31,5 +31,5 @@ 

    tags:

    - memcached

    notify:

-   - reload systemd

+   - Reload systemd

    when: ansible_distribution == 'RedHat' and ansible_distribution_major_version|int == 7

@@ -110,7 +110,7 @@ 

      group: root

      mode: "0755"

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - config

    - mirror_pagure_ansible

@@ -103,7 +103,7 @@ 

    tags:

    - mirrorlist_proxy

    notify:

-   - reload systemd

+   - Reload systemd

  

  # enable both of them to run on boot

  - name: Enable mirrorlist1

@@ -27,6 +27,6 @@ 

  - name: Wsgi.conf

    ansible.builtin.copy: src="wsgi.conf" dest=/etc/httpd/conf.d/wsgi.conf

    notify:

-   - restart apache

+   - Restart apache

    tags:

    - config

file modified
+7 -7
@@ -17,7 +17,7 @@ 

    tags:

    - mote

    notify:

-   - restart memcached

+   - Restart memcached

  

  - name: Make systemd override dir

    ansible.builtin.file:
@@ -36,8 +36,8 @@ 

    tags:

    - mote

    notify:

-   - reload systemd

-   - restart memcached

+   - Reload systemd

+   - Restart memcached

  

  - meta: flush_handlers

  
@@ -63,8 +63,8 @@ 

    - config

    - mote

    notify:

-   - nuke mote json cache

-   - restart apache

+   - Nuke mote json cache

+   - Restart apache

  

  - name: Create /usr/share/httpd/.local for mote-updater to store the fedmsg CRL

    ansible.builtin.file: dest=/usr/share/httpd/.local owner=apache group=apache state=directory
@@ -126,7 +126,7 @@ 

      dest=/usr/share/mote/name_mappings.json

      setype=httpd_sys_content_t

    notify:

-   - nuke mote json cache

+   - Nuke mote json cache

    tags:

    - mote

    - selinux
@@ -136,7 +136,7 @@ 

      dest=/usr/share/mote/category_mappings.json

      setype=httpd_sys_content_t

    notify:

-   - nuke mote json cache

+   - Nuke mote json cache

    tags:

    - mote

    - selinux

@@ -153,7 +153,7 @@ 

    tags:

    - nagios_config

    - nagios_server

-   notify: restart nagios

+   notify: Restart nagios

  

  ## Copy over the contacts

  - name: Copy /etc/nagios/contacts
@@ -161,7 +161,7 @@ 

    tags:

    - nagios_config

    - nagios_server

-   notify: restart nagios

+   notify: Restart nagios

  

  ## Copy over the contactgroups

  - name: Copy /etc/nagios/contactgroups
@@ -169,7 +169,7 @@ 

    tags:

    - nagios_config

    - nagios_server

-   notify: restart nagios

+   notify: Restart nagios

  

  ## Copy over the hosts

  - name: Copy /etc/nagios/hosts
@@ -177,7 +177,7 @@ 

    tags:

    - nagios_config

    - nagios_server

-   notify: restart nagios

+   notify: Restart nagios

  

  ## Copy over the services

  - name: Copy /etc/nagios/services (PHX2 specific files)
@@ -199,7 +199,7 @@ 

    - nagios_server

    - nagios_hostgroups

    when: env == "production" and nagios_location == 'iad2_internal'

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Copy /etc/nagios/services (IAD2 specific files)

    ansible.builtin.copy: src=nagios/services/iad2_internal/{{ item }} dest=/etc/nagios/services/{{ item }}
@@ -221,7 +221,7 @@ 

    - nagios_server

    - nagios_hostgroups

    when: env == "production" and nagios_location == 'iad2_internal'

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Copy /etc/nagios/services (internal files)

    ansible.builtin.copy: src=nagios/services/{{ item }} dest=/etc/nagios/services/{{ item }}
@@ -248,7 +248,7 @@ 

    - nagios_server

    - nagios_hostgroups

    when: env == "production" and nagios_location == 'iad2_internal'

-   notify: restart nagios

+   notify: Restart nagios

  

  ## Copy over the services

  - name: Copy /etc/nagios/services (External)
@@ -262,7 +262,7 @@ 

    - nagios_config

    - nagios_server

    when: env == "production" and nagios_location == "external"

-   notify: restart nagios

+   notify: Restart nagios

  

  ## Drop services we don't need

  - name: Nuke unneded services from /etc/nagios/services (External)
@@ -273,7 +273,7 @@ 

    - nagios_config

    - nagios_server

    when: env == "production" and nagios_location == "external"

-   notify: restart nagios

+   notify: Restart nagios

  

  ## Copy over the servicegroups

  - name: Copy /etc/nagios/servicegroups
@@ -282,7 +282,7 @@ 

    - nagios_config

    - nagios_server

    when: nagios_location == 'iad2_internal'

-   notify: restart nagios

+   notify: Restart nagios

  

  ## Copy over the servicegroups

  - name: Copy /etc/nagios/servicegroups
@@ -297,7 +297,7 @@ 

    - nagios_config

    - nagios_server

    when: nagios_location == "external"

-   notify: restart nagios

+   notify: Restart nagios

  

  ## Copy over the plugins

  - name: Copy plugins
@@ -360,14 +360,14 @@ 

    tags:

    - nagios_server

    - nagios_config

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Override config.inc.php for the given environment

    ansible.builtin.template: src=nagios/config.inc.php.j2 dest=/usr/share/nagios/html/config.inc.php mode=0640 owner=root group=apache

    tags:

    - nagios_server

    - nagios_config

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Template over plugins

    ansible.builtin.template: src=nagios/plugins/{{item}}.j2 dest=/usr/lib64/nagios/plugins/{{item}} mode=0755 owner=root group=root
@@ -384,7 +384,7 @@ 

    tags:

    - nagios_server

    - nagios_config

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Template over services (internal)

    ansible.builtin.template: src=nagios/services/{{item}}.j2 dest=/etc/nagios/services/{{item}} mode=0644 owner=root group=root
@@ -395,7 +395,7 @@ 

    tags:

    - nagios_server

    - nagios_config

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Template over services (both)

    ansible.builtin.template: src=nagios/services/{{item}}.j2 dest=/etc/nagios/services/{{item}} mode=0644 owner=root group=root
@@ -406,7 +406,7 @@ 

    - nagios_server

    - nagios_config

    - websites

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Build out nagios host templates (production)

    ansible.builtin.template: src=nagios/hosts/{{item}}.j2 dest=/etc/nagios/hosts/{{item}} mode=0644 owner=root group=root
@@ -427,7 +427,7 @@ 

    - nagios_server

    - nagios_config

    - nagios_hosts

-   notify: restart nagios

+   notify: Restart nagios

  

  ## These are only available to the internal server

  - name: Build out nagios host templates (production)
@@ -441,7 +441,7 @@ 

    - nagios_server

    - nagios_config

    - nagios_hosts

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Copy Matrix-Notify script

    ansible.builtin.template: src=nagios/scripts/matrix-notify.sh.j2 dest=/usr/local/bin/matrix-notify.sh mode=0750 owner=root group=nagios
@@ -460,7 +460,7 @@ 

    - nagios_server

    - nagios_config

    - nagios_hosts

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Build out nagios host templates (production)

    ansible.builtin.template: src=nagios/hosts/{{item}}.j2 dest=/etc/nagios/hosts/{{item}} mode=0644 owner=root group=root
@@ -471,7 +471,7 @@ 

    tags:

    - nagios_server

    - nagios_config

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Build out nagios hostgroup templates (iad2)

    ansible.builtin.template: src=nagios/hostgroups/{{item}}.j2 dest=/etc/nagios/hostgroups/{{item}} mode=0644 owner=root group=root
@@ -487,7 +487,7 @@ 

    - nagios_server

    - nagios_config

    - nagios_hostgroups

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Build out nagios hostgroup templates (external)

    ansible.builtin.template: src=nagios/hostgroups/{{item}}.j2 dest=/etc/nagios/hostgroups/{{item}} mode=0644 owner=root group=root
@@ -498,7 +498,7 @@ 

    - nagios_server

    - nagios_config

    - nagios_hostgroups

-   notify: restart nagios

+   notify: Restart nagios

  

  - name: Build out nagios services templates

    ansible.builtin.template: src=nagios/services/{{item}}.j2 dest=/etc/nagios/services/{{item}} mode=0644 owner=root group=root
@@ -509,7 +509,7 @@ 

    - nagios_server

    - nagios_config

    - nagios_services

-   notify: restart nagios

+   notify: Restart nagios

  

  

  ## Copy over the servicedeps

@@ -3,17 +3,17 @@ 

  - name: Conditionally restart openQA scheduler consumer

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fm-consumer@fedora_openqa_scheduler

    listen:

-   - restart openqa consumers

-   - restart openqa scheduler consumer

+   - Restart openqa consumers

+   - Restart openqa scheduler consumer

  

  - name: Conditionally restart openQA ResultsDB reporter consumer

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fm-consumer@fedora_openqa_resultsdb_reporter

    listen:

-   - restart openqa consumers

-   - restart openqa resultsdb consumer

+   - Restart openqa consumers

+   - Restart openqa resultsdb consumer

  

  - name: Conditionally restart openQA wiki reporter consumer

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fm-consumer@fedora_openqa_wiki_reporter

    listen:

-   - restart openqa consumers

-   - restart openqa wiki consumer

+   - Restart openqa consumers

+   - Restart openqa wiki consumer

@@ -224,7 +224,7 @@ 

    ansible.builtin.command: "python3 -m pip install --no-deps /root/fedora_openqa"

    when: "gittools is changed or insttools.rc != 0"

    notify:

-   - restart openqa consumers

+   - Restart openqa consumers

  

  # FIXME: we should probably have the fedora-messaging consumers run as

  # someone other than root and then we'd need another token file for
@@ -241,7 +241,7 @@ 

  - name: Write schedule.conf

    ansible.builtin.template: src=schedule.conf.j2 dest=/etc/fedora-openqa/schedule.conf owner=root group=root mode=0600

    notify:

-   - restart openqa consumers

+   - Restart openqa consumers

    tags:

    - config

  
@@ -321,7 +321,7 @@ 

  - name: Configure fedora-messaging scheduler

    ansible.builtin.template: src=fedora_openqa_scheduler.toml.j2 dest=/etc/fedora-messaging/fedora_openqa_scheduler.toml owner=root group=root mode=0640

    notify:

-   - restart openqa scheduler consumer

+   - Restart openqa scheduler consumer

    when: "openqa_amqp_scheduler_queue is defined and openqa_amqp_scheduler_queue"

    tags:

    - config
@@ -329,7 +329,7 @@ 

  - name: Configure fedora-messaging wiki reporter

    ansible.builtin.template: src=fedora_openqa_wiki_reporter.toml.j2 dest=/etc/fedora-messaging/fedora_openqa_wiki_reporter.toml owner=root group=root mode=0640

    notify:

-   - restart openqa wiki consumer

+   - Restart openqa wiki consumer

    when: "openqa_amqp_wiki_reporter_queue is defined and openqa_amqp_wiki_reporter_queue"

    tags:

    - config
@@ -337,7 +337,7 @@ 

  - name: Configure fedora-messaging ResultsDB reporter

    ansible.builtin.template: src=fedora_openqa_resultsdb_reporter.toml.j2 dest=/etc/fedora-messaging/fedora_openqa_resultsdb_reporter.toml owner=root group=root mode=0640

    notify:

-   - restart openqa resultsdb consumer

+   - Restart openqa resultsdb consumer

    when: "openqa_amqp_resultsdb_reporter_queue is defined and openqa_amqp_resultsdb_reporter_queue"

    tags:

    - config

@@ -220,7 +220,7 @@ 

  - name: Set up Apache config

    ansible.builtin.template: src=openqa.conf.httpd.j2 dest=/etc/httpd/conf.d/openqa.conf owner=root group=root mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

  

@@ -4,4 +4,4 @@ 

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh openqa-worker@{{ item }}

    loop: "{{ range(1, openqa_workers + 1)|list }}"

    listen:

-   - restart openqa workers

+   - Restart openqa workers

@@ -82,7 +82,7 @@ 

      state: latest

      enablerepo: "{{ openqa_repo }}"

    notify:

-   - restart openqa workers

+   - Restart openqa workers

    tags:

    - packages

  
@@ -207,7 +207,7 @@ 

  - name: OpenQA worker config

    ansible.builtin.template: src=workers.ini.j2 dest=/etc/openqa/workers.ini owner=_openqa-worker group=root mode=0644

    notify:

-   - restart openqa workers

+   - Restart openqa workers

    tags:

    - config

  

@@ -26,7 +26,7 @@ 

    - install

    - openvpn

    # notify:

-   # - restart openvpn (Fedora)

+   # - Restart openvpn (Fedora)

  

  - name: Install certificate and key (rhel or fedora) for server

    ansible.builtin.copy: src={{ private }}/files/vpn/pki/ca.crt
@@ -36,7 +36,7 @@ 

    - install

    - openvpn

    # notify:

-   # - restart openvpn (Fedora)

+   # - Restart openvpn (Fedora)

    when: inventory_hostname.startswith('bastion0')

  

  - name: Install fix-routes.sh script

@@ -18,7 +18,7 @@ 

    - install

    - openvpn

  #  notify:

- #  - restart openvpn (Fedora)

+ #  - Restart openvpn (Fedora)

  

  - name: Install configuration files (rhel and fedora)

    ansible.builtin.copy: src={{ item.file }}
@@ -35,7 +35,7 @@ 

    - install

    - openvpn

  #  notify:

- #  - restart openvpn (Fedora)

+ #  - Restart openvpn (Fedora)

  

  - name: Make sure openvpn is running in rhel 8+

    service: name=openvpn-client@openvpn state=started enabled=true

@@ -3,7 +3,7 @@ 

      src=bugz.conf dest=/etc/httpd/conf.d/{{website}}/bugz.conf

      owner=root group=root mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - packages

    - packages/proxy

@@ -39,8 +39,8 @@ 

      dest=/etc/fedoracommunity/production.ini

      owner=apache group=fedmsg mode=0440

    notify:

-   - reload httpd

-   - restart fedmsg-hub

+   - Reload httpd

+   - Restart fedmsg-hub

    tags:

    - packages

    - packages/web
@@ -51,7 +51,7 @@ 

      dest=/etc/httpd/conf.d/fedora-packages.conf

      owner=root group=root mode=644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - packages

    - packages/web
@@ -62,7 +62,7 @@ 

      dest=/etc/fedmsg.d/fedoracommunity.py

      owner=root group=root mode=644

    notify:

-   - restart fedmsg-hub

+   - Restart fedmsg-hub

    tags:

    - packages

    - packages/web
@@ -87,8 +87,8 @@ 

      dest="{{pythonsitelib}}/fedoracommunity/search/distmappings.py"

      owner=root group=root mode=0644

    notify:

-   - reload httpd

-   - restart fedmsg-hub

+   - Reload httpd

+   - Restart fedmsg-hub

    tags:

    - packages

    - packages/web

@@ -2,7 +2,7 @@ 

  - name: Setup pager app config

    ansible.builtin.copy: src=pager-app.conf dest=/etc/httpd/conf.d/pager-app.conf mode=644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

    - pager_server

file modified
+13 -13
@@ -30,7 +30,7 @@ 

    ansible.builtin.command: /usr/bin/postgresql-setup initdb

             creates=/var/lib/pgsql/data

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - pagure

  
@@ -207,8 +207,8 @@ 

    - pagure

    - postfix

    notify:

-   - restart postfix

-   - restart pagure_milter

+   - Restart postfix

+   - Restart pagure_milter

  

  # Override pagure_ev systemd service file

  
@@ -217,8 +217,8 @@ 

          dest=/usr/lib/systemd/system/pagure_ev.service

          owner=root group=root mode=0644

    notify:

-   - reload systemd

-   - restart pagure_ev

+   - Reload systemd

+   - Restart pagure_ev

    tags:

    - pagure

    - pagure_ev
@@ -230,8 +230,8 @@ 

          dest=/usr/lib/systemd/system/stunnel.service

          owner=root group=root mode=0644

    notify:

-   - reload systemd

-   - restart stunnel

+   - Reload systemd

+   - Restart stunnel

    tags:

    - pagure

    - stunnel
@@ -242,7 +242,7 @@ 

              owner=root group=root mode=0600

    with_items:

    - {file: stunnel-conf.j2, dest: /etc/stunnel/stunnel.conf}

-   notify: restart stunnel

+   notify: Restart stunnel

    tags:

    - pagure

    - stunnel
@@ -258,7 +258,7 @@ 

    - pagure_slow_worker

    - pagure_mirror

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - pagure

  
@@ -368,7 +368,7 @@ 

    - web

    - pagure

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Install client_secrets for ipsilon

    ansible.builtin.template: src=client_secrets.json
@@ -401,7 +401,7 @@ 

    - pagure

    - sslciphers

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Install the wsgi file

    ansible.builtin.template: src={{ item }}
@@ -415,7 +415,7 @@ 

    - web

    - pagure

    notify:

-   - restart apache

+   - Restart apache

  

  - name: Let paguremirroring read the pagure config

    ansible.builtin.command: /usr/bin/setfacl -m user:paguremirroring:rx /etc/pagure/pagure.cfg
@@ -456,7 +456,7 @@ 

    - pagure

    - hotfix

    notify:

-   - restart pagure_ev

+   - Restart pagure_ev

  

  # Ensure all the services are up and running

  

@@ -9,7 +9,7 @@ 

  - name: Copy httpd config

    ansible.builtin.copy: src=pkgdb-gnome-software.conf dest=/etc/httpd/conf.d/admin.fedoraproject.org/pkgdb.conf owner=root group=root mode=755

    notify:

-   - reload apache

+   - Reload apache

    tags:

    - gnome-software

    - pkgdb2

@@ -15,7 +15,7 @@ 

      regexp: ^shared_preload_libraries =

      line: "shared_preload_libraries = 'timescaledb'"

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - datanommer

    - postgresql

@@ -70,7 +70,7 @@ 

    sysctl: name=kernel.shmmax value={{ kernel_shmmax }}

    when: kernel_shmmax is defined

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - postgresql

  
@@ -78,7 +78,7 @@ 

    ansible.builtin.command: /usr/bin/postgresql-setup initdb

             creates=/var/lib/pgsql/data/postgresql.conf

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - postgresql

  
@@ -86,7 +86,7 @@ 

    service: name=postgresql enabled=yes

    ignore_errors: true

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - service

    - postgresql
@@ -99,7 +99,7 @@ 

    with_items:

    - pg_hba.conf

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - config

    - postgresql
@@ -108,7 +108,7 @@ 

    ansible.builtin.template: dest=/var/lib/pgsql/data/postgresql.conf src=postgresql.conf

    when: ansible_distribution_major_version|int < 8 and ansible_distribution == 'RedHat'

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - config

    - postgresql
@@ -117,7 +117,7 @@ 

    ansible.builtin.template: dest=/var/lib/pgsql/data/postgresql.conf src=postgresql.conf-12

    when: (ansible_distribution_major_version|int == 8 and ansible_distribution == 'RedHat') or ansible_distribution != 'RedHat'

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - config

    - postgresql
@@ -126,7 +126,7 @@ 

    ansible.builtin.template: dest=/var/lib/pgsql/data/postgresql.conf src=postgresql.conf-15

    when: (ansible_distribution_major_version|int == 9 and ansible_distribution == 'RedHat')

    notify:

-   - restart postgresql

+   - Restart postgresql

    tags:

    - config

    - postgresql

@@ -1,9 +1,9 @@ 

  ---

- - name: restart nagios on noc

+ - name: Restart nagios on noc

    ansible.builtin.shell: nagios -v /etc/nagios/nagios.cfg && systemctl restart nagios

    delegate_to: "{{ queue_nagios_server }}"

  

- - name: restart nrpe on rabbitmq

+ - name: Restart nrpe on rabbitmq

    service:

      name: nrpe

      state: restarted

@@ -107,7 +107,7 @@ 

      owner: root

      group: root

      mode: "0644"

-   notify: restart nrpe on rabbitmq

+   notify: Restart nrpe on rabbitmq

    tags:

      - fedora-messaging

      - rabbitmq_cluster
@@ -118,7 +118,7 @@ 

    ansible.builtin.template:

      src: nagios.cfg.j2

      dest: /etc/nagios/services/rabbitmq-queue-{{ queue_name }}.cfg

- #  notify: restart nagios on noc

+ #  notify: Restart nagios on noc

    tags:

      - fedora-messaging

      - rabbitmq_cluster

@@ -71,7 +71,7 @@ 

    - rabbitmq.config

    - rabbitmq-env.conf

    notify:

-     - restart rabbitmq

+     - Restart rabbitmq

    tags:

    - rabbitmq_cluster

    - config
@@ -81,7 +81,7 @@ 

          owner=rabbitmq group=rabbitmq mode=0400

    when: "env == 'staging'"

    notify:

-     - restart rabbitmq

+     - Restart rabbitmq

    tags:

    - rabbitmq_cluster

    - config
@@ -91,7 +91,7 @@ 

          owner=rabbitmq group=rabbitmq mode=0400

    when: "env == 'production'"

    notify:

-     - restart rabbitmq

+     - Restart rabbitmq

    tags:

    - rabbitmq_cluster

    - config
@@ -109,7 +109,7 @@ 

      content: "[Service]\nLimitNOFILE={{rabbitmq_cluster_file_limit}}\n"

      dest: /etc/systemd/system/rabbitmq-server.service.d/override.conf

    notify:

-     - restart rabbitmq

+     - Restart rabbitmq

    tags:

    - rabbitmq_cluster

    - config

file modified
+1 -1
@@ -426,7 +426,7 @@ 

      group: root

      mode: "644"

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

    when: inventory_hostname.startswith('compose-x86-01')

@@ -3,9 +3,9 @@ 

  - name: Conditionally restart relvalconsumer consumer service

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fm-consumer@relvalconsumer

    listen:

-   - restart relvalconsumer

+   - Restart relvalconsumer

  

  - name: Conditionally restart relvalamiconsumer consumer service

    ansible.builtin.command: /usr/local/bin/conditional-restart.sh fm-consumer@relvalamiconsumer

    listen:

-   - restart relvalamiconsumer

+   - Restart relvalamiconsumer

@@ -152,7 +152,7 @@ 

    ansible.builtin.command: "python3 -m pip install --no-deps /root/relvalconsumer"

    when: "gitrvc is changed or instrvc.rc != 0"

    notify:

-   - restart relvalconsumer

+   - Restart relvalconsumer

  

  - name: Create /etc/pki/fedora-messaging

    ansible.builtin.file:
@@ -214,14 +214,14 @@ 

  - name: Configure fedora-messaging relvalconsumer

    ansible.builtin.template: src=relvalconsumer.toml.j2 dest=/etc/fedora-messaging/relvalconsumer.toml owner=root group=root mode=0640

    notify:

-   - restart relvalconsumer

+   - Restart relvalconsumer

    tags:

    - config

  

  - name: Configure fedora-messaging relvalamiconsumer

    ansible.builtin.template: src=relvalamiconsumer.toml.j2 dest=/etc/fedora-messaging/relvalamiconsumer.toml owner=root group=root mode=0640

    notify:

-   - restart relvalamiconsumer

+   - Restart relvalamiconsumer

    tags:

    - config

  

@@ -11,7 +11,7 @@ 

      dest=/etc/httpd/conf.d/{{website}}/review-stats.conf

      owner=root group=root mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - review-stats

    - review-stats/proxy

@@ -2,7 +2,7 @@ 

  - name: Install rkhunter (dnf)

    ansible.builtin.package: name=rkhunter state=present

    notify:

-   - run rkhunter

+   - Run rkhunter

    tags:

    - rkhunter

    - packages
@@ -10,7 +10,7 @@ 

  - name: Rkhunter.conf

    ansible.builtin.template: src=rkhunter.conf.j2 dest=/etc/rkhunter.conf mode=0640

    notify:

-   - run rkhunter

+   - Run rkhunter

    tags:

    - rkhunter

    - config
@@ -18,7 +18,7 @@ 

  - name: Rkhunter sysconfig

    ansible.builtin.copy: src=rkhunter.sysconfig dest=/etc/sysconfig/rkhunter mode=0640

    notify:

-   - run rkhunter

+   - Run rkhunter

    tags:

    - rkhunter

    - config

@@ -187,7 +187,7 @@ 

      mode: "0644"

    when: env == 'staging'

    notify:

-   - reload systemd

+   - Reload systemd

    - Restart robosignatory

    tags:

    - config
@@ -212,7 +212,7 @@ 

      mode: "0755"

    when: env != 'staging'

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - config

    - robosignatory
@@ -226,7 +226,7 @@ 

      mode: "0644"

    when: env != 'staging'

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - config

    - robosignatory

file modified
+1 -1
@@ -72,7 +72,7 @@ 

      - rsync.{{ rsync_group }}

      - rsync.default

    notify:

-   - restart xinetd

+   - Restart xinetd

    when: ansible_distribution_major_version|int < 9 and ansible_distribution == 'RedHat'

    tags:

    - config

@@ -8,6 +8,6 @@ 

  - name: Copy httpd config

    ansible.builtin.copy: src=security-txt.conf dest=/etc/httpd/conf.d/admin.fedoraproject.org/security-txt.conf owner=root group=root mode=755

    notify:

-   - reload apache

+   - Reload apache

    tags:

    - security.txt

@@ -20,6 +20,6 @@ 

  - name: Regenerate the password db file

    ansible.builtin.shell: postmap /etc/postfix/sasl_passwd

    when: smtp_relay_password_file.changed

-   notify: restart postfix

+   notify: Restart postfix

    tags:

      - smtp_auth_relay

@@ -22,14 +22,14 @@ 

  - name: Setup the sysconfig file

    ansible.builtin.copy: src=sysconfig dest=/etc/sysconfig/spamassassin

    notify:

-   - restart spamassassin

+   - Restart spamassassin

    tags:

    - config

  

  - name: Setup the config file

    ansible.builtin.copy: src=local.cf dest=/etc/mail/spamassassin/local.cf

    notify:

-   - restart spamassassin

+   - Restart spamassassin

    tags:

    - config

  

file modified
+2 -2
@@ -166,7 +166,7 @@ 

    ansible.builtin.copy: src=zodbot.service dest=/etc/systemd/system/zodbot.service

    when: env == "production"

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - config

    - supybot
@@ -182,7 +182,7 @@ 

    ansible.builtin.copy: src=ursabot.service dest=/etc/systemd/system/ursabot.service

    when: env == "staging"

    notify:

-   - reload systemd

+   - Reload systemd

    tags:

    - config

    - supybot

@@ -35,6 +35,6 @@ 

  - name: Set up Apache config

    ansible.builtin.copy: src=testcase_stats.conf.httpd dest=/etc/httpd/conf.d/01-testcase_stats.conf owner=root group=root mode=0644

    notify:

-   - reload httpd

+   - Reload httpd

    tags:

    - config

@@ -25,9 +25,9 @@ 

  - name: Generate testdays config

    ansible.builtin.template: src=settings.py.j2 dest=/etc/testdays/settings.py owner=root group=root mode=0644

    notify:

-     - reload httpd

+     - Reload httpd

  

  - name: Generate testdays apache config

    ansible.builtin.template: src=testdays.conf.j2 dest=/etc/httpd/conf.d/testdays.conf owner=root group=root mode=0644

    notify:

-     - reload httpd

+     - Reload httpd

file modified
+3 -3
@@ -25,8 +25,8 @@ 

  - name: Install varnish /etc/systemd/system/varnish.service file (fedora 29+)

    ansible.builtin.template: src=varnish.f29.j2 dest=/etc/systemd/system/varnish.service owner=root group=root

    notify:

-   - reload systemd

-   - restart varnish

+   - Reload systemd

+   - Restart varnish

    tags:

    - varnish

    when: ansible_distribution_major_version|int >= 29 and ansible_distribution == 'Fedora'
@@ -34,7 +34,7 @@ 

  - name: Install /etc/varnish/default.vcl (proxies)

    ansible.builtin.template: src={{ varnish_group }}.vcl.j2 dest=/etc/varnish/default.vcl owner=root group=root

    notify:

-   - restart varnish

+   - Restart varnish

    tags:

    - varnish

  

@@ -1,7 +1,7 @@ 

  ---

- - name: restart_zabbix_agent

+ - name: Restart zabbix agent

    service: name=zabbix-agent state=restarted

  

- - name: reload custom selinux files

+ - name: Reload custom selinux files

    ansible.builtin.shell: /usr/sbin/semodule -u "/etc/selinux/centos/centos-zabbix-agent.pp"

    when: ansible_selinux.mode == "enforcing"

@@ -60,7 +60,7 @@ 

    ansible.builtin.template:

      src: zabbix_agentd.conf.j2

      dest: "{{ zabbix_agentd }}"

-   notify: restart_zabbix_agent

+   notify: Restart zabbix agent

    tags:

      - zabbix_agent

  
@@ -102,7 +102,7 @@ 

      dest: "{{ zabbix_agentd_dir }}/{{ item }}"

      owner: zabbix

      mode: "0666"

-   notify: restart_zabbix_agent

+   notify: Restart zabbix agent

    with_items:

      - interface-alias.conf

    tags:

file modified
+5 -5
@@ -10,35 +10,35 @@ 

    tags:

    - config

    notify:

-   - restart openvpn

+   - Restart openvpn

  

  # - name: /etc/openvpn/crl.pem from vpn/openvpn/keys/crl.pem

  #  ansible.builtin.copy: src="{{ private }}/vpn/openvpn/keys/crl.pem" dest=/etc/openvpn/crl.pem mode=0644 owner=root group=root

  #  tags:

  #  - config

  #  notify:

- #  - restart openvpn

+ #  - Restart openvpn

  

  - name: /etc/openvpn/openvpn.conf

    ansible.builtin.copy: src="{{ files }}/openvpn/client.conf" dest=/etc/openvpn/openvpn.conf

    tags:

    - config

    notify:

-   - restart openvpn

+   - Restart openvpn

  

  - name: /etc/openvpn/client.crt

    ansible.builtin.copy: src="{{ private }}/files/vpn/openvpn/keys/{{ inventory_hostname }}.crt" dest=/etc/openvpn/client.crt mode=0600 owner=root group=root

    tags:

    - config

    notify:

-   - restart openvpn

+   - Restart openvpn

  

  - name: /etc/openvpn/client.key

    ansible.builtin.copy: src="{{ private }}/files/vpn/openvpn/keys/{{ inventory_hostname }}.key" dest=/etc/openvpn/client.key mode=0600 owner=root group=root

    tags:

    - config

    notify:

-   - restart openvpn

+   - Restart openvpn

  

  - name: Enable openvpn service for rhel 6

    service: name=openvpn state=started enabled=true

file modified
+5 -5
@@ -10,35 +10,35 @@ 

    tags:

    - config

    notify:

-   - restart openvpn 7

+   - Restart openvpn 7

  

  # - name: /etc/openvpn/crl.pem from vpn/openvpn/keys/crl.pem

  #  ansible.builtin.copy: src="{{ private }}/vpn/openvpn/keys/crl.pem" dest=/etc/openvpn/crl.pem mode=0644 owner=root group=root

  #  tags:

  #  - config

  #  notify:

- #  - restart openvpn

+ #  - Restart openvpn

  

  - name: /etc/openvpn/openvpn.conf

    ansible.builtin.copy: src="{{ files }}/openvpn/client.conf" dest=/etc/openvpn/openvpn.conf

    tags:

    - config

    notify:

-   - restart openvpn 7

+   - Restart openvpn 7

  

  - name: /etc/openvpn/client.crt

    ansible.builtin.copy: src="{{ private }}/files/vpn/openvpn/keys/{{ inventory_hostname }}.crt" dest=/etc/openvpn/client.crt mode=0600 owner=root group=root

    tags:

    - config

    notify:

-   - restart openvpn 7

+   - Restart openvpn 7

  

  - name: /etc/openvpn/client.key

    ansible.builtin.copy: src="{{ private }}/files/vpn/openvpn/keys/{{ inventory_hostname }}.key" dest=/etc/openvpn/client.key mode=0600 owner=root group=root

    tags:

    - config

    notify:

-   - restart openvpn 7

+   - Restart openvpn 7

  

  - name: Enable openvpn service for rhel or fedora

    service: name=openvpn@openvpn state=started enabled=true

file modified
+1 -1
@@ -16,7 +16,7 @@ 

      - "{{ roles_path }}/base/files/postfix/main.cf/main.cf.{{ datacenter }}"

      - "{{ roles_path }}/base/files/postfix/main.cf/main.cf"

    notify:

-   - restart postfix

+   - Restart postfix

    tags:

    - postfix

    - config

file modified
+1 -1
@@ -76,7 +76,7 @@ 

    tags:

      - swap.file.swapon

      - swap

-   notify: restart swap.swap

+   notify: Restart swap.swap

  

  - name: Remove zram-generator-defaults

    ansible.builtin.package:

This will unify all the handlers to use first uppercase letter for
ansible-lint to stop complaining.

I went through all notify: occurrences and fixed them by running

set TEXT "text_to_replace"; set REPLACEMENT "replacement_text"; git grep
-rlz "$TEXT" . | xargs -0 sed -i "s/$TEXT/$REPLACEMENT/g"

Then I went through all the changes and removed the ones that wasn't
expected to be changed.

Fixes https://pagure.io/fedora-infrastructure/issue/12391

Signed-off-by: Michal Konecny mkonecny@redhat.com

rebased onto d710450

a month ago

rebased onto d710450

a month ago

Thanks for this! I looked at yq and perl for doing this and neither seemed easy.

For anyone else reviewing, it will be a lot easier if you download the patch and run it through diff-so-fancy (yum install diff-so-fancy).

The only problem I saw was the missing 'r' before list, here:

  • name: restart mirrorlist-server
  • name: Restart mirrolist-server
    service: name=mirrorlist-server state=restarted

...there were a couple of extra changes with removing _'s or quotes, but I think they are fine.

So, note that service module you are passing the name of the unit file on the os. It's 100% not capatlized.

I just found another case that was meesed up:

2ad6517

I am wondering if we shouldn't just change everything back to lower case and tell ansible-lint to stop checking this. ;(

Is it only handlers that it complains about this on? Or every name: ?

rebased onto 2ad6517

a month ago

@james Fixed that

@kevin It basically complains about every name :/

I've also noticed lowercased handler names in roles/rabbit/queue/handlers/main.yml and roles/zabbix/zabbix_agent/handlers/main.yml

@abompard I must have missed those, thanks for pointing them out.

rebased onto 2ad6517

a month ago

Fixed the ones that @abompard found.

I can probably create some simple script that will fix the uppercase letters in every name and call of the task.

rebased onto 2ad6517

a month ago

Found another handler I didn't updated, but the reason was that it wasn't called anywhere.

rebased onto 2ad6517

a month ago

ok. Lets give this a go.

Hopefully things are better after it.

Pull-Request has been merged by kevin

a month ago
Metadata
Changes Summary 168
+63 -63
file changed
handlers/restart_services.yml
+2 -2
file changed
playbooks/groups/debuginfod.yml
+1 -1
file changed
playbooks/groups/ipa.yml
+1 -1
file changed
playbooks/groups/proxies.yml
+1 -1
file changed
playbooks/include/proxies-miscellaneous.yml
+1 -1
file changed
playbooks/include/proxies-reverseproxy.yml
+1 -1
file changed
playbooks/manual/copr/copr-keygen-upgrade.yml
+1 -1
file changed
playbooks/manual/copr/copr-pulp-upgrade.yml
+1 -1
file changed
playbooks/update_ticketkey.yml
+2 -2
file changed
roles/abrt/faf-post/handlers/main.yml
+2 -2
file changed
roles/abrt/faf-pre/handlers/main.yml
+8 -8
file changed
roles/abrt/faf-pre/tasks/main.yml
+8 -8
file changed
roles/abrt/faf-pre/tasks/setup_db.yml
+1 -1
file changed
roles/abrt/faf/handlers/main.yml
+2 -2
file changed
roles/abrt/faf/tasks/web.yml
+1 -1
file changed
roles/abrt/retrace/handlers/main.yml
+3 -3
file changed
roles/abrt/retrace/tasks/config.yml
+6 -6
file changed
roles/apache/tasks/main.yml
+1 -1
file changed
roles/apps-fp-o/tasks/main.yml
+2 -2
file changed
roles/base/tasks/main.yml
+11 -11
file changed
roles/base/tasks/postfix.yml
+2 -2
file changed
roles/basessh/tasks/main.yml
+3 -3
file changed
roles/batcave/tasks/main.yml
+3 -3
file changed
roles/blockerbugs/tasks/main.yml
+4 -4
file changed
roles/bodhi2/backend/tasks/main.yml
+1 -1
file changed
roles/btrfs/tasks/main.yml
+3 -3
file changed
roles/bugzilla2fedmsg/tasks/main.yml
+1 -1
file changed
roles/check-compose/handlers/main.yml
+2 -2
file changed
roles/check-compose/tasks/main.yml
+1 -1
file changed
roles/chrony/tasks/main.yml
+9 -9
file changed
roles/collectd/base/tasks/main.yml
+1 -1
file changed
roles/collectd/bind/tasks/main.yml
+2 -2
file changed
roles/collectd/fcomm-queue/tasks/main.yml
+2 -2
file changed
roles/collectd/fedmsg-activation/tasks/main.yml
+2 -2
file changed
roles/collectd/fedmsg-service/tasks/main.yml
+1 -1
file changed
roles/collectd/memcached/tasks/main.yml
+2 -2
file changed
roles/collectd/postgres/tasks/main.yml
+1 -1
file changed
roles/collectd/rabbitmq/tasks/main.yml
+5 -5
file changed
roles/collectd/server/tasks/main.yml
+2 -2
file changed
roles/collectd/web-service/tasks/main.yml
+5 -5
file changed
roles/copr/backend/handlers/main.yml
+6 -6
file changed
roles/copr/backend/tasks/main.yml
+1 -1
file changed
roles/copr/backend/tasks/mount_fs.yml
+1 -1
file changed
roles/copr/backend/tasks/network.yml
+1 -1
file changed
roles/copr/base/handlers/main.yml
+2 -2
file changed
roles/copr/base/tasks/main.yml
+1 -1
file changed
roles/copr/certbot/templates/httpd
+1 -1
file changed
roles/copr/certbot/templates/lighttpd
+2 -2
file changed
roles/copr/dist_git/handlers/main.yml
+4 -4
file changed
roles/copr/dist_git/tasks/main.yml
+3 -3
file changed
roles/copr/frontend/handlers/main.yml
+2 -2
file changed
roles/copr/frontend/tasks/httpd.yml
+6 -6
file changed
roles/copr/frontend/tasks/main.yml
+8 -8
file changed
roles/copr/frontend/tasks/psql_setup.yml
+5 -5
file changed
roles/copr/hypervisor/tasks/main.yml
+3 -3
file changed
roles/copr/keygen/tasks/main.yml
+1 -1
file changed
roles/developer/website/tasks/main.yml
+1 -1
file changed
roles/dhcp_server/tasks/main.yml
+1 -1
file changed
roles/distgit/pagure/handlers/main.yml
+9 -9
file changed
roles/distgit/pagure/tasks/main.yml
+7 -7
file changed
roles/distgit/tasks/main.yml
+11 -11
file changed
roles/dns/tasks/main.yml
+1 -1
file changed
roles/docker-distribution/tasks/main.yml
+3 -3
file changed
roles/download/tasks/main.yml
+1 -1
file changed
roles/easyfix/proxy/tasks/main.yml
+35 -35
file changed
roles/fedmsg/base/tasks/main.yml
+1 -1
file changed
roles/fedmsg/crl/tasks/main.yml
+4 -4
file changed
roles/fedmsg/gateway/slave/tasks/main.yml
+2 -2
file changed
roles/fedmsg/gateway/tasks/main.yml
+5 -5
file changed
roles/fedmsg/hub/tasks/main.yml
+2 -2
file changed
roles/fedmsg/irc/tasks/main.yml
+2 -2
file changed
roles/fedmsg/relay/tasks/main.yml
+1 -1
file changed
roles/fedora-budget/proxy/tasks/main.yml
+2 -2
file changed
roles/fedora-docs/proxy/tasks/main.yml
+1 -1
file changed
roles/fedora-web/alt/tasks/main.yml
+1 -1
file changed
roles/fedora-web/candidate-registry/tasks/main.yml
+1 -1
file changed
roles/fedora-web/codecs/tasks/main.yml
+1 -1
file changed
roles/fedora-web/community/tasks/main.yml
+1 -1
file changed
roles/fedora-web/fedora.im/tasks/main.yml
+1 -1
file changed
roles/fedora-web/flocktofedora/tasks/main.yml
+1 -1
file changed
roles/fedora-web/getfedora/tasks/main.yml
+1 -1
file changed
roles/fedora-web/iot/tasks/main.yml
+1 -1
file changed
roles/fedora-web/labs/tasks/main.yml
+5 -5
file changed
roles/fedora-web/main/tasks/main.yml
+1 -1
file changed
roles/fedora-web/mirrors/tasks/main.yml
+1 -1
file changed
roles/fedora-web/ols/tasks/main.yml
+1 -1
file changed
roles/fedora-web/ostree/tasks/main.yml
+3 -3
file changed
roles/fedora-web/registry/tasks/main.yml
+3 -3
file changed
roles/fedora-web/src/tasks/main.yml
+1 -1
file changed
roles/fedora-web/start/tasks/main.yml
+1 -1
file changed
roles/fedora_nightlies/handlers/main.yml
+2 -2
file changed
roles/fedora_nightlies/tasks/main.yml
+1 -1
file changed
roles/fedoraloveskde/website/tasks/main.yml
+2 -2
file changed
roles/freemedia/tasks/main.yml
+2 -2
file changed
roles/geoip-city-wsgi/app/tasks/main.yml
+1 -1
file changed
roles/geoip-city-wsgi/proxy/tasks/main.yml
+1 -1
file changed
roles/git/server/tasks/main.yml
+5 -5
file changed
roles/github2fedmsg/tasks/main.yml
+2 -2
file changed
roles/haproxy/rewrite/tasks/main.yml
+1 -1
file changed
roles/haproxy/tasks/main.yml
+3 -3
file changed
roles/httpd/certificate/tasks/main.yml
+1 -1
file changed
roles/httpd/domainrewrite/tasks/main.yml
+2 -2
file changed
roles/httpd/fingerprints/tasks/main.yml
+1 -1
file changed
roles/httpd/mime-type/tasks/main.yml
+2 -2
file changed
roles/httpd/mod_ssl/tasks/main.yml
+6 -6
file changed
roles/httpd/proxy/tasks/main.yml
+1 -1
file changed
roles/httpd/redirect/tasks/main.yml
+1 -1
file changed
roles/httpd/redirectmatch/tasks/main.yml
+1 -1
file changed
roles/httpd/reverseproxy/tasks/main.yml
+5 -5
file changed
roles/httpd/website/tasks/main.yml
+5 -5
file changed
roles/ipa/client/tasks/hbac.yml
+1 -1
file changed
roles/ipa/server/handlers/main.yml
+4 -4
file changed
roles/ipa/server/tasks/main.yml
+1 -1
file changed
roles/ipa/server/tasks/scripts.yml
+6 -6
file changed
roles/ipsilon/tasks/main.yml
+1 -1
file changed
roles/ipsilon/tasks/patches.yml
+1 -1
file changed
roles/keepalived/tasks/main.yml
+1 -1
file changed
roles/kerneltest/tasks/main.yml
+2 -2
file changed
roles/koji_builder/tasks/main.yml
+18 -18
file changed
roles/koji_hub/tasks/main.yml
+5 -5
file changed
roles/kojipkgs/tasks/main.yml
+7 -7
file changed
roles/letsencrypt/tasks/main.yml
+6 -6
file changed
roles/mailman3/tasks/main.yml
+1 -1
file changed
roles/mariadb_server/tasks/main.yml
+2 -2
file changed
roles/mediawiki/tasks/main.yml
+2 -2
file changed
roles/memcached/tasks/main.yml
+1 -1
file changed
roles/mirror_pagure_ansible/tasks/main.yml
+1 -1
file changed
roles/mirrormanager/mirrorlist_proxy/tasks/main.yml
+1 -1
file changed
roles/mod_wsgi/tasks/main.yml
+7 -7
file changed
roles/mote/tasks/main.yml
+23 -23
file changed
roles/nagios_server/tasks/main.yml
+6 -6
file changed
roles/openqa/dispatcher/handlers/main.yml
+5 -5
file changed
roles/openqa/dispatcher/tasks/main.yml
+1 -1
file changed
roles/openqa/server/tasks/main.yml
+1 -1
file changed
roles/openqa/worker/handlers/main.yml
+2 -2
file changed
roles/openqa/worker/tasks/main.yml
+2 -2
file changed
roles/openvpn/base/tasks/main.yml
+2 -2
file changed
roles/openvpn/client/tasks/main.yml
+1 -1
file changed
roles/packages3/bugz.fp.o/tasks/main.yml
+6 -6
file changed
roles/packages3/web/tasks/main.yml
+1 -1
file changed
roles/pager_server/tasks/main.yml
+13 -13
file changed
roles/pagure/tasks/main.yml
+1 -1
file changed
roles/pkgdb-proxy/tasks/main.yml
+1 -1
file changed
roles/postgresql_server/tasks/datanommer.yml
+7 -7
file changed
roles/postgresql_server/tasks/main.yml
+2 -2
file changed
roles/rabbit/queue/handlers/main.yml
+2 -2
file changed
roles/rabbit/queue/tasks/main.yml
+4 -4
file changed
roles/rabbitmq_cluster/tasks/main.yml
+1 -1
file changed
roles/releng/tasks/main.yml
+2 -2
file changed
roles/relvalconsumer/handlers/main.yml
+3 -3
file changed
roles/relvalconsumer/tasks/main.yml
+1 -1
file changed
roles/review-stats/proxy/tasks/main.yml
+3 -3
file changed
roles/rkhunter/tasks/main.yml
+3 -3
file changed
roles/robosignatory/tasks/main.yml
+1 -1
file changed
roles/rsyncd/tasks/main.yml
+1 -1
file changed
roles/security.txt/tasks/main.yml
+1 -1
file changed
roles/smtp-auth-relay/tasks/main.yml
+2 -2
file changed
roles/spamassassin/tasks/main.yml
+2 -2
file changed
roles/supybot/tasks/main.yml
+1 -1
file changed
roles/testcase_stats/tasks/main.yml
+2 -2
file changed
roles/testdays/tasks/main.yml
+3 -3
file changed
roles/varnish/tasks/main.yml
+2 -2
file changed
roles/zabbix/zabbix_agent/handlers/main.yml
+2 -2
file changed
roles/zabbix/zabbix_agent/tasks/main.yml
+5 -5
file changed
tasks/openvpn_client.yml
+5 -5
file changed
tasks/openvpn_client_7.yml
+1 -1
file changed
tasks/postfix_basic.yml
+1 -1
file changed
tasks/swap.yml