PR#2478: fix logrotate to match file with date - fedora-infra/ansible

fedora-infra / ansible

#2478 fix logrotate to match file with date

Merged a month ago by kevin. Opened 4 months ago by seddik.

fedora-infra/ seddik/ansible logrotate_fix into main

fix logrotate to match file with date

Seddik Alaoui Ismaili • a month ago

69e1153

files/httpd/httpd.logrotate.j2 ~~files/httpd/httpd.logrotate~~

file renamed

+5 -1

		`@@ -1,4 +1,8 @@`
		`- /var/log/httpd/*log {`
		`+ /var/log/httpd/*log`
		`+ {% if ansible_hostname.startswith("kojipkgs") %}`
		`+ /var/log/httpd/*.log.????-??-??`
		`+ {% endif %}`
		`+ {`
		`daily`
		`rotate 7`
		`missingok`

roles/apache/tasks/main.yml

file modified

+1 -1

		`@@ -83,7 +83,7 @@`
		`- apachestatus`

		`- name: Setup logrotate to our needs`
		`- ansible.builtin.copy: src="{{ files }}/httpd/httpd.logrotate" dest=/etc/logrotate.d/httpd`
		`+ ansible.builtin.template: src="{{ files }}/httpd/httpd.logrotate.j2" dest=/etc/logrotate.d/httpd`
		`tags:`
		`- config`
		`- apache`

seddik commented 4 months ago

zuul commented 4 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/8b9d22bad4724b9db506a5619a7dce40

fi-ansible-lint-diff : SUCCESS in 2m 10s
fi-yamllint-diff : SUCCESS in 2m 00s

kevin commented 4 months ago

This will take care of the YYYY-MM-DD ones... but there is still also a access_log one.

So perhaps 2 entries? or some regex that works for both?

rebased onto 6d4c6b0

4 months ago

seddik commented 4 months ago

PR updated

zuul commented 4 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/9996ead7b6e14a979f324267f93e13af

fi-ansible-lint-diff : SUCCESS in 2m 15s
fi-yamllint-diff : SUCCESS in 1m 59s

kevin commented 4 months ago

well, you shouldn't need *log and access_log right? the first one should match...

I think there may not be newlines between the logs to match? not 100% sure tho.

rebased onto f103010

3 months ago

zuul commented 3 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/558e5323f59e41be9572d63e771bec71

fi-ansible-lint-diff : SUCCESS in 2m 43s
fi-yamllint-diff : SUCCESS in 2m 08s

seddik commented 3 months ago

@kevin PR updated

Metadata Update from @kevin:
- Pull-request tagged with: post-freeze

3 months ago

rebased onto 2f67aad

3 months ago

rebased onto 2f67aad

3 months ago

zuul commented 3 months ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/780e9a2db66a4c16b0ac11a6bb3408bb

fi-ansible-lint-diff : SUCCESS in 2m 35s
fi-yamllint-diff : SUCCESS in 2m 10s

kevin commented 2 months ago

Sorry this one has lingered so long. ;(

So, this will only matter on those kojipkgs servers, but it will apply to everything. Will it cause problems for non matching hosts?

Or perhaps can we just do a specific one for kojipkgs instead of changing every one all over?

rebased onto 5561372

a month ago

zuul commented a month ago

Build succeeded.
https://fedora.softwarefactory-project.io/zuul/buildset/cfd4e79ee0f6418ea232627358f21368

fi-ansible-lint-diff : SUCCESS in 3m 06s
fi-yamllint-diff : SUCCESS in 2m 12s

seddik commented a month ago

@kevin I've just updated with condition !
Can you test this ??

kevin commented a month ago

That looks ok, but... this is a file, not a template. We would need to move it to a .j2 file and change the copy to a template in the ansible play(s) that call it.

Can you do that?

Sorry this is drawing out so long. Thanks for working on it!

rebased onto 8a9adc5

a month ago

seddik commented a month ago

That looks ok, but... this is a file, not a template. We would need to move it to a .j2 file and change the copy to a template in the ansible play(s) that call it.

Can you do that?

Sorry this is drawing out so long. Thanks for working on it!

yes I've just updated the PR , thank you

zuul commented a month ago

Build failed. More information on how to proceed and troubleshoot errors available at https://fedoraproject.org/wiki/Zuul-based-ci
https://fedora.softwarefactory-project.io/zuul/buildset/dd415917788e44b9b66ba965f46decef