Issue #116: rpmautospec generate-changelog is hard to call - rpmautospec

fedora-infra / rpmautospec

#116 rpmautospec generate-changelog is hard to call

Closed: Fixed May 25, 2021 by scoady. Opened Mar 25, 2021 by zbyszek.

Like fedpkg, most people are going to be calling this from a dist-git checkout.
rpmautospec generate-changelog does not work, rpmautospec generate-changelog . does not work, rpmautospec generate-changelog $PWD works, but is not intuitive.

$ rpmautospec generate-changelog
usage: rpmautospec generate-changelog [-h] worktree_path
rpmautospec generate-changelog: error: the following arguments are required: worktree_path
$ rpmautospec generate-changelog .
Traceback (most recent call last):
  File "/usr/bin/rpmautospec", line 33, in <module>
    sys.exit(load_entry_point('rpmautospec==0.1.3', 'console_scripts', 'rpmautospec')())
  File "/usr/lib/python3.9/site-packages/rpmautospec/cli.py", line 97, in main
    sys.exit(subcmd_module.main(args))
  File "/usr/lib/python3.9/site-packages/rpmautospec/changelog.py", line 234, in main
    changelog = produce_changelog(repopath)
  File "/usr/lib/python3.9/site-packages/rpmautospec/changelog.py", line 103, in produce_changelog
    shutil.copytree(repopath, repocopy)
  File "/usr/lib64/python3.9/shutil.py", line 557, in copytree
    return _copytree(entries=entries, src=src, dst=dst, symlinks=symlinks,
  File "/usr/lib64/python3.9/shutil.py", line 458, in _copytree
    os.makedirs(dst, exist_ok=dirs_exist_ok)
  File "/usr/lib64/python3.9/os.py", line 225, in makedirs
    mkdir(name, mode)
FileExistsError: [Errno 17] File exists: '/tmp/rpmautospec-ez47b0a6/.'

rpmautospec-0.1.3-5.fc34.noarch

Metadata Update from @amoloney:
- Issue tagged with: Needs Review

Apr 12, 2021

nphilipp commented Apr 12, 2021

Just to set expectations straight, a lot of functionality exposed in the rpmautospec CLI is for testing purposes, as a test bed for the Python package etc. We plan to implement/move user functionality in/into existing tools like fedpkg.

Metadata Update from @nphilipp:
- Issue untagged with: Needs Review

Apr 12, 2021

nphilipp commented May 21, 2021

I've added that to #158, with it you can use . or supply no argument at all to point rpmautospec at the current directory.

Metadata Update from @nphilipp:
- Issue assigned to nphilipp

May 21, 2021

scoady commented May 25, 2021

Commit b4d17ba5 fixes this issue

scoady commented May 25, 2021

Commit 72b03441 fixes this issue