fedora-infra / rpmautospec

#241 All leading dashes (-) in commit subject should be removed, no?
Closed: Invalid by nphilipp. Opened by kkleine.

Closed: Invalid
Reopen Issue

In https://pagure.io/fedora-infra/rpmautospec/blob/main/f/rpmautospec/pkg_history.py#_367 it says:

if commit_subject.startswith("-"):
    commit_subject = commit_subject[1:].lstrip()

This will only remove the first dash:

>>> a="--foobar"
>>> a[1:].lstrip()
'-foobar'

Isn't this what we want?

>>> a="--foobar"
>>> a.lstrip("-")
'foobar'

I've created a PR for this in #242

Closing, as per the reasons in #242.

Metadata Update from @nphilipp:
- Issue close_status updated to: Invalid
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.