fedora-infra / toddlers

#277 scm_request_processor - Branch request can race with repo creation
Closed by zlopez. Opened by jnsamyak.

Closed
Reopen Issue

Related releng ticket: https://pagure.io/releng/issue/11601/

A couple days ago, I requested a repo, a branch for f38, and a branch for f37. These were all done rather close to each other as I used fbrnch to request them all at the same time.

The repo and f37 branch requests both worked fine.

However, the f38 branch request was processed too quickly. It initially complained that:

qulogic is not a maintainer of the golang-github-sigurn-crc16 package

When I re-opened the issues, it then said:

Traceback (most recent call last):
  File "/code/toddlers/plugins/scm_request_processor.py", line 200, in process
    self.process_ticket(issue)
  File "/code/toddlers/plugins/scm_request_processor.py", line 312, in process_ticket
    self.create_new_branch(issue, issue_body)
  File "/code/toddlers/plugins/scm_request_processor.py", line 825, in create_new_branch
    self.dist_git.new_branch(
  File "/code/toddlers/utils/pagure.py", line 495, in new_branch
    raise PagureError(
toddlers.exceptions.pagure_error.PagureError: Couldn't create branch in project 'rpms/golang-github-sigurn-crc16'
Request to 'https://src.fedoraproject.org/api/0/rpms/golang-github-sigurn-crc16/git/branch':
{'branch': 'f38', 'from_commit': '4911bbe9948ce92b56995f075e669d3543db0be4'}
Response:
{'error': "Remote hook declined the push: error: cannot lock ref 'refs/heads/f38': reference already exists", 'error_code': 'ENOCODE'}
Status code: 400

So either the original request worked even though I didn't have permission, or the second one did it twice?

Despite the second error, the bot then posted that the branch was created and closed the issue as fixed like normal.

  • When do you need this? (YYYY/MM/DD) N/A

  • When is this no longer needed or useful? (YYYY/MM/DD) N/A

  • If we cannot complete your request, what is the impact? Random branch creation failures.

I think we fixed the original issue in https://pagure.io/fedora-infra/toddlers/c/d713b4f2784af55bffea794b281143ac3f298183?branch=main, but I'm not sure about the second run.

The second run is usually done on partially processed ticket, which is sometimes doing really strange things.

Also we shouldn't mention PDC anymore.

This should be fixed in https://pagure.io/fedora-infra/toddlers/issue/150 and the error looks like there was a git hook enabled on the repository that disallowed direct pushes to branch.

Metadata Update from @zlopez:
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.