I accidentally pushed retirements for two packages to the f41 branch today (rust-crossterm0.19, rust-pancurses0.16) because I hadn't updated my helper scripts.
Then I noticed that the packages were actually getting blocked in koji from the f41 tag too, so it looks like the toddlers don't take the final freeze into account, during which no packages should get retired.
@lenkaseg Could you look into that? As you are working on koji_block_retired plugin.
koji_block_retired
We discussed this issue on Infra standup. The old script was blocked during freeze. Excluding frozen releases from the koji blocking should fix this issue.
Metadata Update from @zlopez: - Issue assigned to lenkaseg - Issue tagged with: cpe
In the meantime, I blocked the toddler koji_block_retired for the time of the freeze, to avoid blocking on f41 and for rawhide and epel I'll be checking manually for now.
I'm not sure if tracking it manually is great, sometimes there are a lof of retirements and they come during weekends or other times people might not be around... how hard is it to adjust to not block frozen releases along with stable?
The fix is very simple, only removing the frozen branches from the koji blocking. I'd need to get this PR in first, because it introduces a lot of changes (playtime call, gentle koji_session retrier, epel tag solver and a lot of refactoring): https://pagure.io/fedora-infra/toddlers/pull-request/261 If I make the fix from main branch, I'll introduce a lot of merge conflicts.
Ah, I see.
Perhaps you could do a PR against the current base for the frozen part and then just rebase the big one?
But failing that, I guess I'd be in favor of trying the big pr, watching it closely and reverting if there's issues.
I did this with several commits already and it always end in mess, with possible introduction of bugs as it is difficult to track all the changes. I'd like to avoid that.
I can add it on top of the big PR, but even better would be to merge it first and open a new PR for adding this feature of not blocking on frozen branches.
ok. Yeah, then moving forward with the big pr seems reasonable to me... as long as we can revert back if it causes big problems somehow.
Fix to exclude frozen packages here: https://pagure.io/fedora-infra/toddlers/pull-request/281
The big PR is merged and deployed to staging, I'm testing it now. If everything is ok, the frozen fix can be deployed too and the toddler will be enabled.
This issue is fixed
Metadata Update from @lenkaseg: - Issue status updated to: Closed (was: Open)
Log in to comment on this ticket.