In the following tickets:
https://pagure.io/releng/fedora-scm-requests/issue/76973 https://pagure.io/releng/fedora-scm-requests/issue/76974 https://pagure.io/releng/fedora-scm-requests/issue/76975 https://pagure.io/releng/fedora-scm-requests/issue/76976
The "initial_commit": false option was not respected. rawhide branch was created and populated with an initial commit.
"initial_commit": false
Please investiate and fix this.
When do you need this? any time
When is this no longer needed or useful? when we no longer use this?
If we cannot complete your request, what is the impact? unexpected commits that are almost impossible to get rid of
originally reported at https://pagure.io/releng/issue/12791
I think the issue is here: https://pagure.io/fedora-infra/toddlers/blob/main/f/toddlers/plugins/scm_request_processor.py#_272 - if repo is created after a "valid" comment, the argument initial_commit is not set, ergo takes the default True value.
initial_commit
True
As opposed to another place in the code, where the function is called with the keyword: https://pagure.io/fedora-infra/toddlers/blob/main/f/toddlers/plugins/scm_request_processor.py#_498 (when repo is created after a "retry" comment via call to process_ticket()).
process_ticket()
The solution, hopefully, is as simple as passing the keyword arg on line 272.
Untested: https://pagure.io/fedora-infra/toddlers/pull-request/375
I merged the pull request, now we need to deploy it on both staging and production.
if you deploy it on staging, I can try to see if it helps
Deployed on staging.
Where is the staging deployment reading the issues from?
@churchyard https://stg.pagure.io/releng/fedora-scm-requests/issues
Then I must have made a typo when I tried that :D
https://stg.pagure.io/releng/fedora-scm-requests/issue/526
says:
Invalid body, missing required field: backend
There are a lot of commits that are currently in testing phase on staging. @amedvede How the requests should look now?
You could try adding "backend": "custom", perhaps
"backend": "custom",
After that I got:
Invalid body, missing required field: project_name
I assume just setting monitor to no-monitoring should be enough for the request to go through.
monitor
no-monitoring
Please reply "@releng-bot valid" to https://stg.pagure.io/releng/fedora-scm-requests/issue/526
Metadata Update from @zlopez: - Issue assigned to zlopez
Metadata Update from @zlopez: - Issue tagged with: cle
I tested it out on https://stg.pagure.io/releng/fedora-scm-requests/issue/526 and originally hit 500 on src.stg.fedoraproject.org, but it was a wrong owner of the rpms directory, so I fixed that. The second retry worked with the repository created here https://src.stg.fedoraproject.org/rpms/python3.15 without any commits. Could you check if that is what you want?
Yes! Thank you, this is what we want.
I also opened https://stg.pagure.io/releng/fedora-scm-requests/issue/529 with "initial_commit": true so we can verify the fix did not regress.
"initial_commit": true
Seems correct to me https://src.stg.fedoraproject.org/rpms/python3.666
Indeed. Thanks!
This is now deployed on production.
Metadata Update from @zlopez: - Issue status updated to: Closed (was: Open)
Thank you both!